What happened?

Function xqc_pacing_rate_calc() can returned 0 in some case (I encountered this problem once, not sure how to reproduce), and causing division-by-zero exception in xqc_pacing_time_until_send() at this line: https://github.com/alibaba/xquic/blob/7f362ee085a4a1eeb48fb7f90a3ae07f24481872/src/transport/xqc_pacing.c#L122

Steps To Reproduce

I encountered this problem once, not sure how to reproduce.

Relevant log output

No response

What happened?

Build error happens when I run "make -j"

Steps To Reproduce

Follow the README

Relevant log output

ld: unknown option: --whole-archive
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libxquic.dylib] Error 1
make[1]: *** [CMakeFiles/xquic.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 90%] Built target xquic-static
make: *** [all] Error 2

What happened?

1 Forward or schedule packet to xquic, send stream packet use function bellow void client_network_send(void *out_data, size_t out_dlen) { g_user_stream->send_body = out_data; g_user_stream->send_body_len = out_dlen; g_user_stream->send_offset = 0; client_stream_send(g_user_stream->stream, g_user_stream); }

2 Send iperf udp packet in limited bandwidth and get the packet lost

iperf -u -c 10.7.0.1 -b 1M -t 10 -p 6001 // drop rate 20% iperf -u -c 10.7.0.1 -b 2M -t 10 -p 6001 // drop rate 50%

3 The stream transport is unreliability and unstability 3.1 server stream segmentation fault

3.2 server close stream actively

3.3 client stream segmentation fault

Steps To Reproduce

1 Forward or schedule packet to xquic 2 send packet with function client_network_send( ) 3 use iperf test tool to detect the udp throughput 4 get some drop rate and unstability

Relevant log output

No response

Discussed in https://github.com/alibaba/xquic/discussions/87

What happened?

1 Forward or schedule packet to xquic, send stream packet use function bellow void client_network_send(void *out_data, size_t out_dlen) { g_user_stream->send_body = out_data; g_user_stream->send_body_len = out_dlen; g_user_stream->send_offset = 0; client_stream_send(g_user_stream->stream, g_user_stream); }

2 Send packet fragmentation would makes packet drop

3 Looks like transport stream packets have scheduling issue

Steps To Reproduce

1 forward or schedule packet to xquic 2 send packet with function client_network_send( ) 3 send packet with fragmentation gets packet drop

Relevant log output

No response

What happened?

As discussions #21 , build iOS failed using xqc_build.sh

Steps To Reproduce

As discussions #21

macOS 11.4 Xcode 12.5 cmake version 3.21.2

1.export IOS_CMAKE_TOOLCHAIN="xx/xquic/cmake/ios.toolchain.cmake" 2. sh xqc_build.sh ios ios_build ios_release xxx/xquic/third_party/boringssl

output: [ 1%] Generating crypto_test_data.cc make[2]: *** No rule to make target xxx/xquic/bssl_symbols.txt', needed by third_party/boringssl/symbol_prefix_include/boringssl_prefix_symbols.h'. Stop. make[1]: *** [third_party/boringssl/CMakeFiles/boringssl_prefix_symbols.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 1%] Building CXX object third_party/boringssl/CMakeFiles/boringssl_gtest.dir/third_party/googletest/src/gtest-all.cc.o [ 1%] Building CXX object third_party/boringssl/CMakeFiles/crypto_test_data.dir/crypto_test_data.cc.o [ 1%] Built target crypto_test_data [ 1%] Linking CXX static library ../../outputs/libboringssl_gtest.a [ 1%] Built target boringssl_gtest make: *** [all] Error 2

Relevant log output

No response

What happened?

按照最新版本的xquic中的platforms中在win10 64位上编译xquic，一直都报错，无法解决

Steps To Reproduce

windows环境： Win10 64位系统

软件版本： Go:1.18.1 Cmake:3.23.1 Nasm:2.15 Visual studio:2017 因为环境不联网，没有办法下载安装vcpkg，从而libevent是自己离线安装的

编译步骤： （1） 编译boringssl 当前下载的是4.23号的master分支代码，使用的是vs2017下的命令行提示符 如果按照platforms下的命令运行， cmake -DCMAKE_GENERATOR_PLATFORM=x64 --config Debug -DBUILD_SHARED_LIBS=0 -DCMAKE_C_FLAGS="-fPIC" -DCMAKE_CXX_FLAGS="-fPIC" .. 会报错，cmake error:unknown argument --config：

将config命令去掉，成功不报错

设置 set GO111MODULE=off 运行MSBuild.exe ALL_BUILD.vcxproj，生成lib

（2） 编译xquic 运行命令： cmake -DSSL_TYPE=boringssl -DCMAKE_BUILD_TYPE=Debug -G "Visual Studio 15 2017 Win64" .. 不报错 继续运行： MSBuild.exe ALL_BUILD.vcxproj 会报一堆无法解析的错误

Relevant log output

No response

What happened?

Xquic client can't complete handshake with quic-go server. Xquic was built with babassl, and it keep retrying when handshake with quic-go server.

Steps To Reproduce

Attached test client and server source file. Client can get connect_create_notify called but connect_handshake_finished never got called.

thanks

xquic.zip

Relevant log output

No response

What happened?

Seems BabaSSL has break changes, they renamed to Tongsuo.

/extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c: In function ‘xqc_gen_reset_token’:
/extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:1300:5: error: ‘HMAC_CTX_new’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
     HMAC_CTX *ctx = HMAC_CTX_new();
     ^~~~~~~~
In file included from /extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:9:0:
/extern_disk/home/lyf/xquic/third_party/babassl/include/openssl/hmac.h:33:33: note: declared here
 OSSL_DEPRECATEDIN_3_0 HMAC_CTX *HMAC_CTX_new(void);
                                 ^~~~~~~~~~~~
/extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:1301:5: error: ‘HMAC_CTX_reset’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
     HMAC_CTX_reset(ctx);
     ^~~~~~~~~~~~~~
In file included from /extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:9:0:
/extern_disk/home/lyf/xquic/third_party/babassl/include/openssl/hmac.h:34:27: note: declared here
 OSSL_DEPRECATEDIN_3_0 int HMAC_CTX_reset(HMAC_CTX *ctx);
                           ^~~~~~~~~~~~~~
/extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:1302:5: error: ‘HMAC_Init_ex’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
     HMAC_Init_ex(ctx, key, keylen, engine, NULL);
     ^~~~~~~~~~~~
In file included from /extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:9:0:
/extern_disk/home/lyf/xquic/third_party/babassl/include/openssl/hmac.h:43:27: note: declared here
 OSSL_DEPRECATEDIN_3_0 int HMAC_Init_ex(HMAC_CTX *ctx, const void *key, int len,
                           ^~~~~~~~~~~~
/extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:1303:5: error: ‘HMAC_Update’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
     HMAC_Update(ctx, input, input_len);
     ^~~~~~~~~~~
In file included from /extern_disk/home/lyf/xquic/src/transport/xqc_packet_parser.c:9:0:
/extern_disk/home/lyf/xquic/third_party/babassl/include/openssl/hmac.h:45:27: note: declared here
 OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data,
                           ^~~~~~~~~~~
.......
.......

Steps To Reproduce

just compile xquic following the build doc.

Relevant log output

No response

Before request a new feature

• [X] I have searched the issues of this repository and believe that this is not a duplicate.

Describe the feature you'd like supported

reference to RFC 2198、RFC 2733

Describe alternatives you've considered

No response

Additional context

No response

I found multiple typos in API.md. A few sentences are quite elusive to me. I changed them liberally. Please correct me if there are any distortions. I also found one comment (annotated with a TODO) repeated in different contexts,.

What happened?

使用master分支编译xquic会出现错误 commit id 6348479fbd8611034dfd5e633b59ef31931da94b
系统Ubuntu 20.04 focal x86_64 Linux 5.15.0-56-generic 以下是编译命令

# 获取 XQUIC 源码
git clone https://github.com/alibaba/xquic.git
cd xquic

# 编译 BabaSSL
git clone -b 8.3-stable https://github.com/Tongsuo-Project/Tongsuo.git ./third_party/babassl
cd ./third_party/babassl/
./config --prefix=/usr/local/babassl
make -j
SSL_TYPE_STR="babassl"
SSL_PATH_STR="${PWD}"
SSL_INC_PATH_STR="${PWD}/include"
SSL_LIB_PATH_STR="${PWD}/libssl.a;${PWD}/libcrypto.a"
cd -

git submodule update --init --recursive
mkdir -p build; cd build
cmake -DSSL_TYPE=${SSL_TYPE_STR} -DSSL_PATH=${SSL_PATH_STR} -DSSL_INC_PATH=${SSL_INC_PATH_STR} -DSSL_LIB_PATH=${SSL_LIB_PATH_STR} ..
make

cmake日志输出如下

[email protected]:~/xquic/xquic/build$ cmake -DSSL_TYPE=${SSL_TYPE_STR} -DSSL_PATH=${SSL_PATH_STR} -DSSL_INC_PATH=${SSL_INC_PATH_STR} -DSSL_LIB_PATH=${SSL_LIB_PATH_STR} ..
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
SSL_TYPE= babassl
SSL_PATH= /home/darren/xquic/xquic/third_party/babassl
SSL_LIB_PATH= /home/darren/xquic/xquic/third_party/babassl/libssl.a;/home/darren/xquic/xquic/third_party/babassl/libcrypto.a
SSL_INC_PATH= /home/darren/xquic/xquic/third_party/babassl/include
-- Configuring done
-- Generating done
-- Build files have been written to: /home/darren/xquic/xquic/build

Steps To Reproduce

cmake -DSSL_TYPE=${SSL_TYPE_STR} -DSSL_PATH=${SSL_PATH_STR} -DSSL_INC_PATH=${SSL_INC_PATH_STR} -DSSL_LIB_PATH=${SSL_LIB_PATH_STR} ..
make

Relevant log output

[email protected]:~/xquic/xquic/build$ make
Scanning dependencies of target xquic
[  0%] Building C object CMakeFiles/xquic.dir/src/http3/xqc_h3_conn.c.o
[  1%] Building C object CMakeFiles/xquic.dir/src/http3/xqc_h3_stream.c.o
[  2%] Building C object CMakeFiles/xquic.dir/src/http3/xqc_h3_request.c.o
[  3%] Building C object CMakeFiles/xquic.dir/src/http3/frame/xqc_h3_frame.c.o
[  4%] Building C object CMakeFiles/xquic.dir/src/http3/xqc_h3_header.c.o
[  4%] Building C object CMakeFiles/xquic.dir/src/http3/xqc_h3_ctx.c.o
[  5%] Building C object CMakeFiles/xquic.dir/src/http3/xqc_h3_defs.c.o
[  6%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_qpack.c.o
[  7%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_prefixed_int.c.o
[  8%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_prefixed_str.c.o
[  8%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_decoder.c.o
[  9%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_encoder.c.o
[ 10%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_rep.c.o
[ 11%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/xqc_ins.c.o
[ 12%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/stable/xqc_stable.c.o
[ 12%] Building C object CMakeFiles/xquic.dir/src/http3/qpack/dtable/xqc_dtable.c.o
[ 13%] Building C object CMakeFiles/xquic.dir/src/transport/xqc_engine.c.o
[ 14%] Building C object CMakeFiles/xquic.dir/src/transport/xqc_conn.c.o
[ 15%] Building C object CMakeFiles/xquic.dir/src/transport/xqc_client.c.o
In file included from /usr/include/string.h:495,
                 from /home/darren/xquic/xquic/src/common/xqc_str.h:8,
                 from /home/darren/xquic/xquic/src/common/xqc_common_inc.h:10,
                 from /home/darren/xquic/xquic/src/common/utils/var_buf/xqc_var_buf.h:8,
                 from /home/darren/xquic/xquic/src/http3/xqc_h3_stream.h:8,
                 from /home/darren/xquic/xquic/src/transport/xqc_client.c:6:
In function ‘strncpy’,
    inlined from ‘xqc_client_create_tls’ at /home/darren/xquic/xquic/src/transport/xqc_client.c:156:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/darren/xquic/xquic/src/transport/xqc_client.c: In function ‘xqc_client_create_tls’:
/home/darren/xquic/xquic/src/transport/xqc_client.c:149:16: note: length computed here
  149 |     alpn_cap = strlen(alpn) + 1;
      |                ^~~~~~~~~~~~
In file included from /usr/include/string.h:495,
                 from /home/darren/xquic/xquic/src/common/xqc_str.h:8,
                 from /home/darren/xquic/xquic/src/common/xqc_common_inc.h:10,
                 from /home/darren/xquic/xquic/src/common/utils/var_buf/xqc_var_buf.h:8,
                 from /home/darren/xquic/xquic/src/http3/xqc_h3_stream.h:8,
                 from /home/darren/xquic/xquic/src/transport/xqc_client.c:6:
In function ‘strncpy’,
    inlined from ‘xqc_client_create_tls’ at /home/darren/xquic/xquic/src/transport/xqc_client.c:166:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/darren/xquic/xquic/src/transport/xqc_client.c: In function ‘xqc_client_create_tls’:
/home/darren/xquic/xquic/src/transport/xqc_client.c:159:16: note: length computed here
  159 |     host_cap = strlen(hostname) + 1;
      |                ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [CMakeFiles/xquic.dir/build.make:297: CMakeFiles/xquic.dir/src/transport/xqc_client.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:78: CMakeFiles/xquic.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
[email protected]:~/xquic/xquic/build$

#include <assert.h>
#include <math.h>
#ifdef _WIN32
#include <intrin.h>
#define XQC_SYS_WINDOWS 1
#endif
/* make n to 2 pow  */
static int xqc_pow2(unsigned int n)
{
    int count1 = 0;    
    unsigned long power = sizeof(n);
#ifdef __GNUC__
    count1 = __builtin_popcount(n);
#else
    unsigned int t = n;
    while (t) {
        count1 += t & 1;
        t >>= 1;
    }
#endif
    if (count1 <= 1) {
        return n;
    }
#if defined(XQC_SYS_WINDOWS) && defined(_MSC_VER)
    /* __lzcnt available beginning VS2008 or up*/
    _BitScanReverse((unsigned long *)&power, n);    
#else
    power = (power << 3) - __builtin_clz(n) - 1;    
#endif
    return (int)pow(2, power);
}
int main()
{
    assert(xqc_pow2(4) == 4);
    assert(xqc_pow2(12) == 8);
    assert(xqc_pow2(1024) == 1024);
    assert(xqc_pow2(0) == 0);
    assert(xqc_pow2(1) == 1);
}

What happened?

multipath的 nonce计算时 path id应该是网络序，现在貌似是主机序？

问题可能出现在：https://github.com/alibaba/xquic/blob/ceeed29947e7ad148e097d75c26ba6407368af36/src/tls/xqc_crypto.c#L158

Steps To Reproduce

RFC测试实例：

# https://quicwg.org/multipath/draft-ietf-quic-multipath.html#name-packet-protection-for-quic-

IV: 6b26114b9cba2b63a9e8dd4f
PN: aead
SN: 3
==
nonce: 6b2611489cba2b63a9e873e2

Relevant log output

No response

What happened?

8.1.4.Address Validation Token Integrity An address validation token MUST be difficult to guess. Including a random value with at least 128 bits of entropy in the token would be sufficient, but this depends on the server remembering the value it sends to clients.

Xquic use ip address + expire time as token.

Steps To Reproduce

Read the code.

Relevant log output

No response

What happened?

I found many memory leak bugs, it seems xquic is not tested in extreme scenarios (e.g. high loss rate).

Steps To Reproduce

See my issues.

Relevant log output

No response

What happened?

The memory allocate for stream_frame may leak.

Steps To Reproduce

valgrind it in high loss environment.

Relevant log output

No response