I would like to launch a nanogui Screen in a thread of its own. This works as intended on Linux, but crashes and burns on a Mac. Any suggestions and pointers would be very welcome.

#include <iostream>
#include <thread>
#include <nanogui/screen.h>

namespace ng = nanogui;

int main(int argc, char *argv[])
{
    std::thread t([]()
    {
        try
        {
            nanogui::init();

            ng::Screen* app = new ng::Screen(ng::Vector2i { 800, 600 }, "Test");

            app->drawAll();
            app->setVisible(true);

            nanogui::mainloop();

            delete app;

            nanogui::shutdown();
        } catch (const std::runtime_error &e)
        {
            std::string error_msg = std::string("Caught a fatal error: ") + std::string(e.what());
            #if defined(WIN32)
                MessageBoxA(nullptr, error_msg.c_str(), NULL, MB_ICONERROR | MB_OK);
            #else
                std::cerr << error_msg << '\n';
            #endif
            return -1;
        }
    });
    t.join();

    return 0;
}

Added a widget for displaying an OpenGL scene within in, separately from the main GLFW window.

If there is anything crucial missing, I'm happy to add it. Serialization should work and with time, I'll add a couple more options (like drawing the border or not and setting callback functions for click, drag, release, etc.).

The widget itself right now just allows a callback (lambda) to be defined where the actual GL drawing code resides. No configuration effort beyond that, except maybe the background color.

Resizing does not yet change the GL texture; I didn't find any best practice in the other widgets on how to do that yet. This is a must though and I'll add it later on.

I also added example4 which just shows this widget in action. Could be added to one of the other examples as well instead, but they seemed a bit crowded already.

Replaces #282 with a much cleaner history.

BEFORE MERGE

• [x] Update the docs
• [x] Test windows build.
• [x] Place popup theme setting responsibility to parent (with docs indicating this). So ComboBox and PopupButton.
• [x] Get rid of FontWidget and put that all in Widget.
• [x] ~~Allow support for .otf in addition to .ttf.~~ redacted since requires libfreetype.
• [x] Fix the checkbox bindings
• [x] Add tooltip opacity theme override
• [x] restructure obtuse mFont / mFontExplicit logic.
• [x] post-mortem / rewrite history

This PR is large, but solves once and for all the ability to embed custom fonts. I will add a review highlighting the 2 problems. I'm opening up the PR for review now, docs and Windows testing TBD after I finish the docs on the subsidiary repos (there's an automated icon font generation repo!).

1. bin2c generates to ${CMAKE_CURRENT_BINARY_DIR}/nanogui. Makes installation easier (nanogui_resources.h was not being installed), and keeps the NANOGUI_EXTRA_INCS clean.
2. ~~No font names are hard-coded in any implementation, except Screen::tooltipFont.~~ Changed, Widget::mTooltipFont defines this per-widget now.
3. Theme defines the default fonts.
4. ~~Any class that was drawing non-icon font now inherits from FontWidget.~~ It's all in Widget now.
5. Python bindings with custom icon fonts was a little contrived, but (a) I don't think many people will use it, it's there to allow projects that really cannot use CC-BY-SA 4.0 from Entypo+, (b) there are numerous safeguards in place.

For build system changes, see first commit message.

/usr/ports/x11-toolkits/nanogui/work/nanogui-3e0b2c8/src/common.cpp:206:19: error: no matching function for call to 'file_dialog'
    auto result = file_dialog(filetypes, save, false);
                  ^~~~~~~~~~~
/usr/ports/x11-toolkits/nanogui/work/nanogui-3e0b2c8/src/common.cpp:205:13: note: candidate function not viable: requires 2 arguments, but 3 were provided
std::string file_dialog(const std::vector<std::pair<std::string, std::string>> &filetypes, bool save) {
            ^

clang-4.0

Hi,

When running the examples (example1, example2, example3), I have a mouse offset in positive Y direction for all widgets. Also when I move a window inside nanogui up to the upper border with that offset present, it is not drawn properly on that border. See pictures for details.

When I compile my own applications with nanogui, that doesn't happen. So something is off in the example code.

I have tried for hours to start with an empty project and then adding nanogui to it but it did not work. I tried mirroring the configuration properties, but the included examples are so different from a default empty project, so if I want to add it to an existing project I am affraid I will mess up other parts.

I have no idea what the issue could be or what I should pay attention to. This makes troubleshooting very difficult. I expected it to be straightforward (adding header and library directories, including nanogui/nanogui.h and linking nanogui.lib) but it is not. Perhaps someone could add a HOWTO on adding it to a VS project to get a minimal working example?

hey, i tried build from source but i get this error The NanoGUI dependency repositories (GLFW, etc.) are missing! You probably did not clone the project with --recursive. It is possible to recover by calling "git submodule update --init --recursive"

What should i do?

Definitely squash this, there was a lot of intermediate commits for the entypo stuff that have now been reverted or destroyed.

~~NOTE: I'm going through and doing a PR review right now. Don't review until this is gone since this is a huge update and most of it is just noise from doc comments.~~

1. It would be kind of tedious to separate this out into multiple PRs, but it can be done if you prefer. Things like docs links got added in a few different locations relating to entypo.

2. See annotations in PR review. Basically, this all boils down to the following:

   • Entypo+ updates
     • Some constants have changed, those are all fixed. Entypo+ file documentation enumerates everything, as well as there are CPP and python examples.
     • Python binding code changes slightly to allow auto-generation of Entypo+ constants without having to incorporate GLFW stuff in the gen code.
     • Important: icon sizes have changed. See relevant change to common.h. Here is a full index of where that applies:
       • first scale change
       • second scale change
       • third scale change
       • fourth scale change
       • fifth scale change
       • sixth scale change
       • seventh scale change
       • Basically, the ones using ih should be good. But a couple were not scaled the same as previous code.
   • ColorPicker has been modified
     • I believe the new functionality makes sense. These changes came about from writing the docs and not understanding how it worked. The callback gets executed too frequently. Since it's used in the form helper, I decided it needed to change ;)
   • Sad face. Docs required getting rid of using for eigen vector types :/

3. I'm going to split off onto another branch now for the remaining docs updates. I made a serializer example, but that and the changes made for the docs will be in their own self-contained PR because they aren't exactly trivial changes.

The rest is just docs updates really. Highlight of fake docs build entypo.h :)

P.S. In future merge, you may need to wipe the environment for RTD to build it right because of the change in requirements.txt and more specifically if exhale.pyc is still floating around it will complain about no setup(app) "are you sure it is a sphinx extension" because it wasn't.

I faced build failures and runtime crashes on windows build.

And I fixed them with this PR. Please review it.

Problems about Eigen

I faced build failures in example2 and example3. Error messages are these.

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2719	'<_Args_0>': formal parameter with requested alignment of 16 won't be aligned	example3	C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\functional	276	
Error	C2719	'v': formal parameter with requested alignment of 16 won't be aligned	example2	C:\Users\omochi\work\github\wjakob\nanogui\include\nanogui\formhelper.h	183	
Error	C2719	'<_Args_0>': formal parameter with requested alignment of 16 won't be aligned	example2	C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\functional	276	
Error	C2719	'v': formal parameter with requested alignment of 16 won't be aligned	example3	C:\Users\omochi\work\github\wjakob\nanogui\include\nanogui\formhelper.h	183	

I faced runtime crash in example1.

In example1, program crashes after launch it immediately with this message.

Assertion `(reinterpret_cast<size_t>(array) & (sizemask)) == 0 && "this assertion
is explained here: http://eigen.tuxfamily.org/dox-devel/group__TopicUnalignedArrayAssert.html
     READ THIS WEB PAGE !!! ****"' failed.

They are both from this Eigen design.

Details is explained at this page.

https://eigen.tuxfamily.org/dox/group__TopicUnalignedArrayAssert.html

I fixed them by following workaround in this article.

Commits are these.

• add alignment control for eigen problem 98c4ff3
• fix Arcball pybind type parameter bf99ec1
• change setter to const-ref for eigen types a716aab
• const-ref in pybind a329718

Problem about OpenGL

In example3, program crashes after launch it immediately at first OpenGL function calls without any messages. This is from lack of setting up GLAD for windows.

I fixed it in this commit.

• add glad init for windows b00670f

Problem about build python binding

In my environment, cmake does not detect python library for pybind module.

I solved problem with this.

• fix CMakeLists to build with python for windows bd1e7ef

I don't understand deeply it and cmake. Sorry. And I could not find out about original value ${MITSUBA_PYTHON_VERSION}.

I checked commits by building and running examples 1 to 4 with my windows PC and Mac.

My environment is below.

windows

• Windows 10
• Visual Studio Community 2015

mac

• macOS Sierra

popup.cpp#L65 to 67 are questionable, but the anchor height always seems to be a fixed value (previously).

Adjusting this changes the offset of the anchor (which we update when the vscrollpanel is scrolled)

Hi Wenzel,

I added some simple features to more quickly edit the value of IntBox, FloatBox and ComboBox using scrolling and dragging which makes it much more convenient than typing a value. Here are the full list:

• added scrollEvent support for ComboBox
• added right dragging control for IntBox and FloatBox (à la Blender)
• added scrollEvent for same effect
• added double right click to reset to default value for TextBox

Let me know if you have some feedback for improvements. You can easily test these features on Example 1 or 2. Also I did not add the Python bindings for these. When you approve the changes, you or I can add them quickly to the PR.

Thanks, Romain

I just want to use a new ttf Font, because the default font do not support CJK. but I do not find any API to load a new font, so How to include Custom Fonts？

in NanoGUI document, I find something.

# Including Custom Fonts

NanoGUI uses the [Roboto](https://fonts.google.com/specimen/Roboto) font for text, and [Entypo](http://www.entypo.com/) font for icons. If you wish to add your own custom font, all you need is a True Type file (a .ttf extension). NanoGUI will glob all fonts found in resources by expanding resources/*.ttf. So if you had the directory structure

myproject/
    CMakeLists.txt      <- where this code is
    fonts/
        superfont.ttf
    ext/
        nanogui/
            resources/

You simply need to copy the superfont.ttf to NanoGUI’s resources directory:

file(
  COPY ${CMAKE_CURRENT_SOURCE_DIR}/fonts/superfont.ttf
  DESTINATION ${CMAKE_CURRENT_SOURCE_DIR}/ext/nanogui/resources/superfont.ttf
)

When you build the code, there should be a file nanogui_resources.h generated. If everything worked, your new font should have been included.

Does this mean I have to recomplie NanoGUI? but I don't want to recomplie this library, who can help me please。 /(ㄒoㄒ)/~~

when i use clion (cmake) build example1，it was fail at 85% and throw the error : i don't know what should i do now . can every one help me ? thanks !!!

-Cpp/MinGW64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.2/../../../../x86_64-w64-mingw32/bin/as.exe: CMakeFiles\nanogui-obj.dir\src\colorwheel.cpp.obj: too many sections (32966)
C:\Users\majiao\AppData\Local\Temp\cckNLntO.s: Assembler messages:
C:\Users\majiao\AppData\Local\Temp\cckNLntO.s: Fatal error: can't write CMakeFiles\nanogui-obj.dir\src\colorwheel.cpp.obj: File too big
C:/PROGRA~2/Dev-Cpp/MinGW64/bin/../lib/gcc/x86_64-w64-mingw32/4.9.2/../../../../x86_64-w64-mingw32/bin/as.exe: CMakeFiles\nanogui-obj.dir\src\colorwheel.cpp.obj: too many sections (32966)
C:\Users\majiao\AppData\Local\Temp\cckNLntO.s: Fatal error: can't close CMakeFiles\nanogui-obj.dir\src\colorwheel.cpp.obj: File too big
mingw32-make.exe[3]: *** [CMakeFiles/nanogui-obj.dir/src/colorwheel.cpp.obj] Error 1
mingw32-make.exe[2]: *** [CMakeFiles/nanogui-obj.dir/all] Error 2
CMakeFiles\nanogui-obj.dir\build.make:412: recipe for target 'CMakeFiles/nanogui-obj.dir/src/colorwheel.cpp.obj' failed
CMakeFiles\Makefile2:173: recipe for target 'CMakeFiles/nanogui-obj.dir/all' failed
CMakeFiles\Makefile2:288: recipe for target 'CMakeFiles/example3.dir/rule' failed
Makefile:247: recipe for target 'example3' failed
mingw32-make.exe[1]: *** [CMakeFiles/example3.dir/rule] Error 2
mingw32-make.exe: *** [example3] Error 2

i download zip and unzip, use clion open dir and project, the clion cmake auto run, and back a error my os is windows10.

"H:\mysoft\clion\clionInstall\CLion 2021.1.3\bin\cmake\win\bin\cmake.exe" -DCMAKE_BUILD_TYPE=Debug -G "CodeBlocks - MinGW Makefiles" G:\Xubuntu_Work_Space\From_Xubuntu\codeTest_2019_2_21\git\gitclone\nanogui-master
CMake Error at CMakeLists.txt:15 (message):
  The NanoGUI dependency repositories (GLFW, etc.) are missing! You probably
  did not clone the project with --recursive.  It is possible to recover by
  calling "git submodule update --init --recursive"


-- Configuring incomplete, errors occurred!
See also "G:/Xubuntu_Work_Space/From_Xubuntu/codeTest_2019_2_21/git/gitclone/nanogui-master/cmake-build-debug/CMakeFiles/CMakeOutput.log".

[Finished]

what should i do now ? thanks !!!

I compiled the nanogui library and used it as a third-party library in the project. I also imported include and lib, but the error of undefined identifier "gluniform1i" occurred during generation. How can I solve it? Is it because the nanogui library is not compiled well?

Using vcpkg version 2020.06.15 with command vcpkg install nanogui:x64-windows-static, also had to rename occurrences <Eigen/...> to <eigen3/Eigen/...> to compile the executable, but running it fails without nanogui.dll in target directory