Bug report: https://bugs.chromium.org/p/v8/issues/detail?id=8594

Just 1.4% of the v8 codebase is Python but that code contains:

• Python 2: ~4 syntax errors and 26 undefined names.~
• Python 3: ~76 syntax errors and 42 undefined names.~

UPDATE:

• Python 2: 0 syntax errors and 0 undefined names.
• Python 3: 1 syntax errors and 1 undefined names.

Output: https://travis-ci.com/cclauss/v8

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

• F821: undefined name name
• F822: undefined name name in __all__
• F823: local variable name referenced before assignment
• E901: SyntaxError or IndentationError
• E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

The Python builtin basestring has been removed from all currently supported versions of Python so define basestring in Python 3 so that line 60 does not raise a NameError at runtime. @bmsdave @targos Please submit upstream.

Updated all the issues (in all 3 files) mentioned in https://github.com/v8/v8/pull/29#issuecomment-537490614 and https://github.com/nodejs/node/issues/24512#issuecomment-537665892 with their respective python3 functions

Hello I want to let you know that I have recently developed a function similar to Document.execCommand() with the latest javascript. As you might know, the mentioned function is obsolete and is subject to stop functioning on browsers, however, there is no alternative to it. Now I want to know if it is possible to implement the function I made into javascript source so that everyone can use it and do not waste their time on making it again.

This fixes a bug in CsvParser.prototype.escapeField that improperly handles single-character escapes like \\, which affects parsing paths on DOS-based file systems.

Originally found in https://github.com/thlorenz/v8-tools-core/pull/1 and needed for https://github.com/thlorenz/deoptigate/pull/13.

This proposed patch is based on the work of @kentonv here: https://github.com/nodejs/node/commit/0b882566078cb14537f9f91220f1a58530fa7687

It intends to fix this issue: https://bugs.chromium.org/p/v8/issues/detail?id=5338

As @kentonv mentions here (https://github.com/meteor/meteor/issues/9796#issuecomment-381715608) the patch created is probably not yet entirely suitable to be applied here, but placing this here for review.

Maybe someone with a better understanding of the internal workings of V8 can pick this up?

On line number 628 of time.cc, the variable ticks may be accessed without an initialized value. And while the return value of TimeTicks::HighResolutionNow will never be zero, it's always good to initialize variables, because if we try to access a value before it gets assigned any actual (non-garbage) value, then it results in undefined behavior.

There's a stage 3 proposal waiting to be implemented in at least two browsers in order to make it to stage 4.

Tests has been submitted to test262 by the champion ( @ljharb ) so the last bit would be to actually implement it in core.

These changes have been successfully tested already after a clean make native and double-verified manually within d8 console itself.

Thanks in advance for considering this PR or for clarifying what else is needed in order to integrate such proposal.

Best Regards

Replaced "the open source browser from Google" and replaced it with "the web browser from Google", because Google Chrome is not open source.

Change-Id: Ie7a653545ac34fe3ce2100a5e03eced57bc773b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3498173 Bot-Commit: v8-ci-autoroll-builder v8-ci[email protected] Cr-Commit-Position: refs/heads/10.1.60@{#1} Cr-Branched-From: 995217a31b1c110de5b1aceae2e0d8fc34a1142d-refs/heads/main@{#79353}

@jakobkummerow https://docs.python.org/3/library/exceptions.html#Exception is the base class for most Python errors and Error is undefined in this context so NameError will be raised instead of the desired exception message.