I found a problem.

This code causes assert in Suspend.

ImGui::Begin("Begin");
ImGui::Columns(2);
ImGui::NextColumn();

ed::SetCurrentEditor(g_Context);
ed::Begin("My Editor", ImVec2(0.0, 0.0f));

// assert!
ed::Suspend();
ed::Resume();

ed::End();
ed::SetCurrentEditor(nullptr);

ImGui::Columns(1);
mGui::End();

But this codes runs with Begin and End child.

ImGui::Begin("Begin");
ImGui::Columns(2);
ImGui::NextColumn();

// add
ImGui::BeginChild("Child");
ed::SetCurrentEditor(g_Context);
ed::Begin("My Editor", ImVec2(0.0, 0.0f));

ed::Suspend();
ed::Resume();

ed::End();
ed::SetCurrentEditor(nullptr);

// add
ImGui::EndChild();

ImGui::Columns(1);
mGui::End();

Is it a bug?

Best regards.

Hi,

Playing with big schematic , it tends to become unreadable with all the links. Is there a way to highlight all the links connected to a selected node ?

im on the develop branch.

in imgui_node_editor.cpp.. in ed::EditorContext::LoadSettings() ...

line 2045 there is this if statement, that guards assigning the deserialized m_Settings to the m_NavigateAction, specifically the scroll and zoom:

    if (ImRect_IsEmpty(m_Settings.m_VisibleRect))
    {
        m_NavigateAction.m_Scroll = m_Settings.m_ViewScroll;
        m_NavigateAction.m_Zoom   = m_Settings.m_ViewZoom;
    }
    else
    {
        m_NavigateAction.NavigateTo(m_Settings.m_VisibleRect, NavigateAction::ZoomMode::Exact, 0.0f);
    }

I think this test is inverted. That is, that it should read: if (!ImRect_IsEmpty(m_Settings.m_VisibleRect))

I found that when I invert this test, then my scroll and zoom deserialization works correctly.

The json that is saved out during normal serialization has a valid rectangle like this: "visible_rect":{"max":{"x":1623.708251953125,"y":-1014.2291259765625},"min":{"x":718.125244140625,"y":-1469.4290771484375}}

So the current code looks at that valid rectangle, and ImRect_IsEmpty correctly returns "false" (because it's not empty), and this skips the scroll and zoom assignment. What happens next is the "else" clause is used, which recomputes and uses new zoom and scroll values. So this "throws out" the deseralized zoom and scroll from the json file, and gives you a default-ish zoom and scroll.

Hi, I have a really wierd problem. When nodes are moved out of or created outside a invisible wierd area of the local editor space they are no longer really interactable. They can only be selected with area selection. Pins are not interactable, they dont get tagged as HotObject when hovered. No connections can be made. it can be deleted and existing links it has can be selected and deleted aswell. In the gif below i try to demonstrate how the node breaks when moved.

Hi, dear community! Could anybody please help me to find out how to make a save/load logic for all nodes and links to/from json., It would be great to see a code sample and any advices would be appreciated!!! Thank you very much

Hi, I'm using DearImGui docking branch 1.83, and I have initialized the editor context, and set the current example, and am currently using the default example for the simple node. I have the window created, and the node created, but nothing appears in the window. Any help would be appreciated.

Ho, I would like to disable mouse interaction when custom mouse interaction happens. In the example below I want to drag item out of the list:

Node selection should be turned off. Any ideas? Even if I had to modify the library?

Hi

I'm using the last develop branch and I can see that if i'm deleting a connected node , the link is not deleted and still exist in memory. It cannot be dwran anymore but you can see that the ports are still connected:

Steps to reproduce:

1. Clone imgui-node-editor
2. Replace all *.h and *.cpp imgui files in ThirdParty/imgui directory by files from latest imgui docking branch
3. Add all required ImGuiKey_* to enum in imgui.h
4. Compile Examples/BasicInteraction (for example)
5. Move one of the nodes far away from starting position
6. If try to move it again - fail, it is now inactive

This is because the node now is out of the mouse viewport rect. If comment this line imgui/imgui.cpp#L4675 everything works fine, but I think it's a bad idea...

If add this code before line #4675, we will be able to see that mouse viewport rect, out of which nodes become inactive

auto rect = g.MouseViewport->GetRect();
ImGui::GetWindowDrawList()->AddRect(rect.Min, rect.Max, IM_COL32(255, 0, 0, 255));

In the Simple example, is it expected that one can drag out a connection from on Out pin, and drag it to an In pin? I'm not able to left-drag a connection out of the Out. Before diving too deep into debugging, I thought I should ask this question first :)

I wish that the zoom level was configurable, in my case I only want to zoom out, which means zoomLevel >= 1.0f.

Also, there I think there is a bug. When I zoom in/out in a quick manner, it goes out of range. For example, I very often get the value:

which is not defined on this list:

const float ed::NavigateAction::s_ZoomLevels[] =
{
    0.1f, 0.15f, 0.20f, 0.25f, 0.33f, 0.5f, 0.75f, 1.0f, 1.25f, 1.50f, 2.0f, 2.5f, 3.0f, 4.0f, 5.0f, 6.0f, 7.0f, 8.0f
};

And from that value 0.8000... I can't easily get back to 1.0. Of course, there are more values not appearing on that list.

in imgui_node_editor.h, struct EditorContext is forward declared in ax::NodeEditor namespace, while it is defined in ax::NodeEditor::Detail. It seems to be wanted as the reinterpret_cast tells in CreateEditor, but it provokes unknown symbol dependency reflection while using your library with my reflection meta compiler. Is there a strong reason why it is like this ? I suggest in imgui_node_editor.h something like this to avoid compiler misleading :

namespace Detail
{
    struct EditorContext;
}
using EditorContext = Detail::EditorContext;

instead of struct EditorContext;

Hello, It would be nice to have an export macro to use your node editor as part of a dll.

ex: IMGUI_NODE_EDITOR_API void BeginNode(NodeId id);

It could be even two of them, to mimic how IMGUI used IMGUI_API and IMGUI_API_IMPL for public and internal api functions.

Is there a way to use index 0 as a node ID? Right now, if one of my nodes has an index of 0 it breaks the usability. Same thing is for links and pins.

Example: The "Multiplier" node moves when I hold LMB even if it is not selected. Instead, a selection rectangle should be drawn:

https://user-images.githubusercontent.com/83558889/204521694-5b72d4ee-a245-4cee-bcf1-10694f246b39.mp4

The "Multiplier" node id is 0, and the following nodes' ids are 1 and 2. When the "Multiplier" node id is 1 and the following nodes' ids are 2 and 3 it behaves as expected.

https://user-images.githubusercontent.com/83558889/204522834-d4777d0a-b188-40fa-ae06-601855e5baa9.mp4

I have tried the example, and found a shortcoming when linking the input and outout on the same control node. And I cannot delete it as the cursor cannot hover the link line to popup context menu. The image below shows what I have met.

The node type below is ok to delete even though It links to self.

if ImGuiEx::Canvas::Begin returns false (which can happen if the window is too small and the canvas is Clipped), then the subsequent call to ImGuiEx::Canvas::End() will trigger an IM_ASSERT

This is an issue I ran several times into.

I'm not sure weather this change helps or interrupts.

It's definitely not finished and needs work but I require some help with that since I'm still new to CMake.

Main reason I made these changes was to build my application in elegant way. I wanted to use your "application" class as starting point but I didn't want to wire CMakes to build directory.

After introducing changes, building and installing. Integration with imgui-node-editor looks like this.

Unfortunately I couldn't come up with solution to PUBLIC include directories. From my understanding mere linking to imgui_node_editor::imgui_node_editor should make them visible for the project but It doesn't. Hence ${CMAKE_INSTALL_PREFIX}/../imgui_...