Thanks for your implementation of this algorithm!

Beginner's question: I am trying to understand the training part of the NRC algorithm. I have read the paper several times and it's still not clear to me.

Say, you have a path x0 x1 x2 (x0 - camera, x1 - surface, x2 - surface). How do you train the cache?

1. Do you explicitly sample lights at each intermediate vertex, to get paths x0 x1 l2 (where l2 is now vertex on a light source) and x0 x1 x2 l3 and then put end vertices (in this case x1, and x2) and direction (x2 -> x1, and x1 -> x0) into cache?
2. How does the "path extension" work?
3. There was an issue with "flickering" that was solved by temporal smoothing. How do you solve this problem?

The VS solution compiles just fine, but when I run neural_radiance_cache.exe with the correct parameters, I get the following error: Error: CUDA call (cuGraphicsGLRegisterImage(&m_cudaGfxResource, glTexID, GL_TEXTURE_2D, flags) ) failed with error: 'OS call failed or operation not supported on this OS' (...\GfxExp\utils\cuda_util.cpp:677)

As a note, the program is able to identify my RTX 3060 card.

Howdy,

Thanks for making these interesting experiments available! Will you be making a license file for this project?

I think I found a bug in createGeometryInstance() starting on line 1599 of common_host.cpp where the aabb is being created.

for (int triIdx = 0; triIdx < triangles.size(); ++triIdx) {
        const shared::Triangle &tri = triangles[triIdx];
        const shared::Vertex (&vs)[3] = {
            vertices[tri.index0],
            vertices[tri.index1],
            vertices[tri.index2],
        };
        geomInst->aabb
            .unify(vertices[0].position)
            .unify(vertices[1].position)
            .unify(vertices[2].position);
    }

I think the correct code should be:

geomInst->aabb
            .unify(vs[0].position)
            .unify(vs[1].position)
            .unify(vs[2].position)

Hi,

When using a scene such as lost-empire I get the following error : Error: CUDA call (cuArray3DCreate(&m_array, &arrayDesc) ) failed with error: 'out of memory' (C:\Users\X\Documents\Shocker\GfxExp\utils\cuda_util.cpp:693). I think what is happening is that for every material in the mtl file the map_Ka and map_Kd attributes are loaded into memory even if those same textures have been loaded into memory already for another material. This is confirmed by the console output:

[ 4][  DISK CACHE]: Opened database: "C:\Users\X\AppData\Local\NVIDIA\OptixCache\optix7cache.db"
[ 4][  DISK CACHE]:     Cache data size: "1.8 MiB"
[ 4][   DISKCACHE]: Cache hit for key: ptx-538030-keyf4770f7ee17acca7955c0792d6c5b076-sm_61-rtc0-drv496.76
[ 4][COMPILE FEEDBACK]:
[ 4][   DISKCACHE]: Cache hit for key: ptx-40534-keyf6edc5a05105d08ef92e4c8cff25c7c6-sm_61-rtc0-drv496.76
[ 4][COMPILE FEEDBACK]:
[ 4][COMPILE FEEDBACK]: Info: Pipeline has 1 module(s), 35 entry function(s), 32 trace call(s), 0 continuation callable call(s), 54 direct callable call(s), 707 basic block(s) in entry functions, 19309 instruction(s) in entry functions, 0 non-entry function(s), 0 basic block(s) in non-entry functions, 0 instruction(s) in non-entry functions

Reading: ../scenes/lost-empire/lost_empire.obj ... done.
DefaultMaterial:
Stone:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Grass_Block:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Dirt:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Cobblestone:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Oak_Planks:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Stationary_Water:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Stationary_Lava:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Sand:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Gravel:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Iron_Ore:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Coal_Ore:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Oak_Log:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Oak_Leaves:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Bed:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Powered_Rail:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Detector_Rail:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Sticky_Piston:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Wool:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Dandelion:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Poppy:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Brown_Mushroom:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Double_Stone_Slab:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Stone_Slab:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Obsidian:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Torch:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... done.
Oak_Stairs:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Chest:
  Reading: ../scenes/lost-empire/lost_empire-RGB.png ... done.
Redstone_Wire:
  Reading: ../scenes/lost-empire/lost_empire-RGBA.png ... Error: CUDA call (cuArray3DCreate(&m_array, &arrayDesc) ) failed with error: 'out of memory' (C:\Users\X\Documents\Shocker\GfxExp\utils\cuda_util.cpp:693)

As you can see the same textures are loaded over and over.

For the neural radiance caching example, the paths of the mesh and texture are required in the No.808 line of "neural_radiance_caching_main.cpp" with function "parseCommandline(argc, argv);". However, I failed several times in giving the file path by command line parameters. Can you give an example of the command line parameters? like "-inst /ZeroDay_v1/MEASURE_ONE/MEASURE_ONE.fbx"

What does DynamicFunction class do? Is it an equivalent to a function pointer on a device?

I am interested in using this abstraction (function pointer) for one of my projects. Is there a simple example of how it's used in a kernel?

Thanks!

Hi,

https://github.com/shocker-0x15/GfxExp/blob/ec95e561121812b7224579e3190d05db77ff19a4/restir/optix_kernels.cu#L868 https://github.com/shocker-0x15/GfxExp/blob/ec95e561121812b7224579e3190d05db77ff19a4/restir/optix_kernels.cu#L1403 I noticed that emittance is divided by PI even when the primary hit of the ray was an emitter. I was wondering what the reason is for this? For example if a primary ray hits an emitter with emittance (1.0, 1.0, 1.0) the shading will result in (1/pi, 1/pi, 1/pi) resulting in a visually dimmed primitive on the screen. Naturally this is only noticeable with emitters with emitting strength lower than pi.

Here I am hovering a pixel for which the primary hit is an emitter with values (1.0, 1.0, 1.0) as you can see in the debug info. I think the pixel in that case should also have value (1.0, 1.0 ,1.0) unless I understand wrong.

This is the result when using contribution += emittance;

Hi,

I'm getting a consistent crash in all scenes I try using the path_tracing project in Debug mode only. Release mode works fine. The error message that appears using Nsight->CUDA Debugging is [Error 700: Illegal address during kernel execution].

And the debugger usually stops at this line

CUDA_DEVICE_KERNEL void RT_CH_NAME(pathTraceBaseline)() {
    pathTrace_closestHit_generic();
}

OptiX 7.40 / CUDA 11.7 Driver: 516.59 Visual Studio 2022 17.2.4 Windows 10 RTX 2070 SUPER

Can you confirm this using your environment? I wonder if it has anything to do with this thread. https://forums.developer.nvidia.com/t/illegal-address-error-when-using-both-geometrytriangles-and-geometry-nodes/218956/18