Would it be much work to reduce the compiler requirements to C++11 instead? E.g., the Ubuntu 12.04 compilers does not (as far as I know) support C++14, which makes travis.org builds difficult.

Summary

clang++-6.0 on Ubuntu generates an error when compiling Trompeloeil in std=c++17 or std=c++2a modes.

The latest version of Clang also generates this error.

Environment

Operating system: Ubuntu 18.04 LTS (Bionic Beaver)

Compiler: clang++-6.0 and clang++ pre 7.0.0 a.k.a. clang++-latest.

clang++-6.0 is from package clang-6.0 1:6.0-1ubuntu2.

clang++-latest is locally built each day. This build current as at 26 June 2018.

Flags: -std=c++17 or -std=c++2a.

Command line

clang++-6.0 \
-std=c++17 \
-Weverything \
-Wno-c++98-compat-pedantic \
-Wno-padded \
-Wno-weak-vtables \
-Wno-exit-time-destructors \
-Wno-global-constructors \
-I build/catch \
-I ./include \
-o compiling_tests \
test/compiling_tests.cpp \
test/compiling_tests_11.cpp \
test/compiling_tests_14.cpp

Expected behaviour

Expected compiling_tests to build without error.

Actual behaviour

Compile error

/usr/bin/../lib/gcc/x86_64-linux-gnu/8.0.1/../../../../include/c++/8.0.1/type_traits:945:14: error: base class has incomplete type
    : public is_constructible<_Tp, const _Tp&>
      ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

// ::: (some backtrace information omitted)

test/compiling_tests.hpp:257:3: note: in instantiation of function template specialization 'trompeloeil::call_matcher<void (int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > &),
      std::tuple<trompeloeil::wildcard, trompeloeil::wildcard> >::call_matcher<const trompeloeil::wildcard &, const trompeloeil::wildcard &>' requested here
  MAKE_MOCK2(func, void(int, std::string&), override);
  ^

// ::: (some more backtrace information omitted)

test/compiling_tests_11.cpp:178:26: note: in instantiation of function template specialization 'mock_c::trompeloeil_l_tag_type_trompeloeil_257::func<const trompeloeil::wildcard &, const trompeloeil::wildcard &>' requested here
    REQUIRE_CALL_V(obj2, func(_, _),
                         ^

Further information

This error was encountered as I was gathering information to enable builds of Trompeloeil for C++17 and C++2a.

These build configurations succeed (this is a subset of all the builds that succeed, with a focus on c++17 and c++2a):

                Language    Standard
Compiler        Standard    Library     Comment
----------      --------    --------    -------
g++-5           c++17       stdc++      OK - no warnings, Pass
g++-5           c++17       c++         OK - no warnings, Pass

g++-6           c++17       stdc++      OK - no warnings, Pass
g++-6           c++17       c++         OK - no warnings, Pass

g++-7           c++17       stdc++      OK - no warnings, Pass
g++-7           c++17       c++         OK - no warnings, Pass

g++-8           c++17       stdc++      OK - no warnings, Pass
g++-8           c++17       c++         OK - no warnings, Pass
g++-8           c++2a       stdc++      OK - no warnings, Pass
g++-8           c++2a       c++         OK - no warnings, Pass

g++-latest      c++17       stdc++      OK - no warnings, Pass
g++-latest      c++17       c++         OK - no warnings, Pass
g++-latest      c++2a       stdc++      OK - no warnings, Pass
g++-latest      c++2a       c++         OK - no warnings, Pass

clang++-5.0     c++17       stdc++ v8   OK - no warnings, Pass
clang++-5.0     c++17       c++         OK - no warnings, Pass
clang++-5.0     c++2a       stdc++ v8   OK - no warnings, Pass
clang++-5.0     c++2a       c++         OK - no warnings, Pass

clang++-6.0     c++11       stdc++ v8   OK - no warnings, Pass
clang++-6.0     c++11       c++         OK - no warnings, Pass
clang++-6.0     c++14       stdc++ v8   OK - no warnings, Pass
clang++-6.0     c++14       c++         OK - no warnings, Pass

clang++-latest  c++11       stdc++ v8   OK - no warnings, Pass
clang++-latest  c++11       c++         OK - no warnings, Pass
clang++-latest  c++14       stdc++ v8   OK - no warnings, Pass
clang++-latest  c++14       c++         OK - no warnings, Pass

Note that clang++-6.0 and clang++-latest succeeded in c++11 and c++14 modes.

Either something is wrong with clang++-6.0 in the c++17 and c++2a modes, or Clang has implemented a change from a proposal that has has had an affect on type deduction.

A quick look at the Clang bugzilla does not immediately reveal a previously filed defect report describing this problem.

It is the return of the user-defined conversion problems with wildcard, but I'm left a little concerned there is a limited chance of a workaround in the library code.

I'm raising this issue here, now, before I reduce the test case to the minimum required to reproduce the issue. I will add a comment with the test case once I have it.

Ideas or pointers on how to resolve this are welcomed.

Hello, we currently try to mock OpenVR.

This works fine in general however throws an unreachable code warning in Visual Studio 2017 in Release build (not Debug). Since we have a warning==error policy, this is a problem.

The problem occusr if I add this line

ALLOW_CALL(openvr_mock.GetSystem(), GetProjectionMatrix(_, _, _))
      .RETURN(vr::HmdMatrix44_t());

or any other return type where the return type is:

struct HmdMatrix44_t
{
	float m[4][4];
};

This seems to be related to the returning of structs, because this warning does not occur for any other of the mocked methods, retuning something else.

The warning is:

1>...\trompeloeil.hpp(2033): error C2220: warning treated as error - no 'object' file generated
1>...\trompeloeil.hpp(2033): warning C4702: unreachable code

Any ideas what could cause this, and how I could potentially circumvent it?

This solves the old issue #129. I feel very uncomfortable with this fix, because I don't understand why it solves the problem. It provably does so, across several tests, which is obviously good, but I really want to understand why. I have asked, and received no answers. The solution was found by chance, not through analysis.

@AndrewPaxie ?

Back ported Trompeloeil to C++11.  Changes by file and directory:
* `.travis.yml`
  * Added job for `g++-4.8` C++11 mode.
  * Accepted 4 errors in `check_errors.sh` when in C++11 mode.
* `CMakeLists.txt`
  * Allowed C++ dialect to be specified on command line using
    `CXX_STANDARD="11"` for C++11, default C++14.
  * Fixed Catch at version 1.11.0, given 2.0.1 triggers a defect
    in `g++` when compiling `libc++`.
  * Refined which sanitizers can be used based on given compiler
    and compiler version.
* `README.md`
  * Updated supported compiler list.
  * Added link to `docs/Backward.md`.
  * Added link to `docs/PlatformAndLibraries.md`.
* `include/trompeloeil.hpp`
  * Significantly reworked to accommodate the C++11 API and
    support compilation in a C++11 dialect.
* `check_errors.sh`
  * Require `CXXFLAGS` with either `-std=c++11` or `-std=c++14`.
* `docs/FAQ.md`
  * Updated supported compilers list.
  * Updated answer regarding C++11 support.
* `docs/`
  * New: "Backward compatibility with earlier versions of C++".
  * New: "Platform and library support for Trompeloeil".
* `compilation_errors/`
  * Support for C++11 expectation syntax in test cases.
* `test/`
  * Split `compiling_tests.cpp` into separately compilable files,
    for Catch main, C++11 test cases and C++14 test cases.

First round review.

Hi,

since v36 the following snippet does not compile with GCC 8.3 anymore (it still works with clang-9):

#include <catch2/catch.hpp>
#include <catch2/trompeloeil.hpp>

#include <QObject>

class Mock
{
public:
    MAKE_MOCK0(f, bool());
};

TEST_CASE("")
{
    Mock m;
    REQUIRE_CALL(m, f()).RETURN(true);
}

/usr/local/include/trompeloeil.hpp: In instantiation of ‘constexpr bool trompeloeil::is_null(const T&) [with T = bool]’:
/usr/local/include/trompeloeil.hpp:1274:16:   required from ‘void trompeloeil::print(std::ostream&, const T&) [with T = bool; std::ostream = std::basic_ostream<char>]’
/usr/local/include/trompeloeil.hpp:2962:14:   required from ‘T trompeloeil::trace_agent::trace_return(T&&) [with T = bool]’
/usr/local/include/trompeloeil.hpp:3104:45:   required from ‘Ret trompeloeil::trace_return(trompeloeil::trace_agent&, F&, P&) [with Ret = bool; F = ____C_A_T_C_H____T_E_S_T____1()::<lambda(auto:1&)>; P = std::tuple<>; <template-parameter-1-4> = void]’
/usr/local/include/trompeloeil.hpp:3128:44:   required from ‘trompeloeil::return_of_t<Sig> trompeloeil::return_handler_t<Sig, T>::call(trompeloeil::trace_agent&, trompeloeil::call_params_type_t<Sig>&) [with Sig = bool(); T = ____C_A_T_C_H____T_E_S_T____1()::<lambda(auto:1&)>; trompeloeil::return_of_t<Sig> = bool; trompeloeil::call_params_type_t<Sig> = std::tuple<>]’
/usr/local/include/trompeloeil.hpp:3123:5:   required from here
/usr/local/include/trompeloeil.hpp:1145:34: error: no matching function for call to ‘is_null(const bool&, tag)’
     return ::trompeloeil::is_null(t, tag{});
            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/usr/local/include/trompeloeil.hpp:1111:3: note: candidate: ‘template<class T> constexpr decltype ((t == nullptr)) trompeloeil::is_null(const T&, std::true_type)’
   is_null(
   ^~~~~~~
/usr/local/include/trompeloeil.hpp:1111:3: note:   template argument deduction/substitution failed:
/usr/local/include/trompeloeil.hpp: In substitution of ‘template<class T> constexpr decltype ((t == nullptr)) trompeloeil::is_null(const T&, std::true_type) [with T = bool]’:
/usr/local/include/trompeloeil.hpp:1145:34:   required from ‘constexpr bool trompeloeil::is_null(const T&) [with T = bool]’
/usr/local/include/trompeloeil.hpp:1274:16:   required from ‘void trompeloeil::print(std::ostream&, const T&) [with T = bool; std::ostream = std::basic_ostream<char>]’
/usr/local/include/trompeloeil.hpp:2962:14:   required from ‘T trompeloeil::trace_agent::trace_return(T&&) [with T = bool]’
/usr/local/include/trompeloeil.hpp:3104:45:   required from ‘Ret trompeloeil::trace_return(trompeloeil::trace_agent&, F&, P&) [with Ret = bool; F = ____C_A_T_C_H____T_E_S_T____1()::<lambda(auto:1&)>; P = std::tuple<>; <template-parameter-1-4> = void]’
/usr/local/include/trompeloeil.hpp:3128:44:   required from ‘trompeloeil::return_of_t<Sig> trompeloeil::return_handler_t<Sig, T>::call(trompeloeil::trace_agent&, trompeloeil::call_params_type_t<Sig>&) [with Sig = bool(); T = ____C_A_T_C_H____T_E_S_T____1()::<lambda(auto:1&)>; trompeloeil::return_of_t<Sig> = bool; trompeloeil::call_params_type_t<Sig> = std::tuple<>]’
/usr/local/include/trompeloeil.hpp:3123:5:   required from here
/usr/local/include/trompeloeil.hpp:1115:17: error: invalid operands of types ‘const bool’ and ‘std::nullptr_t’ to binary ‘operator==’
   -> decltype(t == nullptr)
               ~~^~~~~~~~~~
/usr/local/include/trompeloeil.hpp: In instantiation of ‘constexpr bool trompeloeil::is_null(const T&) [with T = bool]’:
/usr/local/include/trompeloeil.hpp:1274:16:   required from ‘void trompeloeil::print(std::ostream&, const T&) [with T = bool; std::ostream = std::basic_ostream<char>]’
/usr/local/include/trompeloeil.hpp:2962:14:   required from ‘T trompeloeil::trace_agent::trace_return(T&&) [with T = bool]’
/usr/local/include/trompeloeil.hpp:3104:45:   required from ‘Ret trompeloeil::trace_return(trompeloeil::trace_agent&, F&, P&) [with Ret = bool; F = ____C_A_T_C_H____T_E_S_T____1()::<lambda(auto:1&)>; P = std::tuple<>; <template-parameter-1-4> = void]’
/usr/local/include/trompeloeil.hpp:3128:44:   required from ‘trompeloeil::return_of_t<Sig> trompeloeil::return_handler_t<Sig, T>::call(trompeloeil::trace_agent&, trompeloeil::call_params_type_t<Sig>&) [with Sig = bool(); T = ____C_A_T_C_H____T_E_S_T____1()::<lambda(auto:1&)>; trompeloeil::return_of_t<Sig> = bool; trompeloeil::call_params_type_t<Sig> = std::tuple<>]’
/usr/local/include/trompeloeil.hpp:3123:5:   required from here
/usr/local/include/trompeloeil.hpp:1124:3: note: candidate: ‘template<class T> constexpr bool trompeloeil::is_null(const T&, std::false_type)’
   is_null(
   ^~~~~~~
/usr/local/include/trompeloeil.hpp:1124:3: note:   template argument deduction/substitution failed:
/usr/local/include/trompeloeil.hpp:1145:34: note:   cannot convert ‘tag{}’ (type ‘tag’ {aka ‘std::integral_constant<bool, true>’}) to type ‘std::false_type’ {aka ‘std::integral_constant<bool, false>’}
     return ::trompeloeil::is_null(t, tag{});
            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/usr/local/include/trompeloeil.hpp:1136:3: note: candidate: ‘template<class T> constexpr bool trompeloeil::is_null(const T&)’
   is_null(
   ^~~~~~~
/usr/local/include/trompeloeil.hpp:1136:3: note:   template argument deduction/substitution failed:
/usr/local/include/trompeloeil.hpp:1145:34: note:   candidate expects 1 argument, 2 provided
     return ::trompeloeil::is_null(t, tag{});
            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

So this is weird, but in

#include <fmt/format.h>
#include <trompeloeil.hpp>
#include <type_traits>

#if 1
namespace trompeloeil {

template<typename T>
struct printer<T, typename std::enable_if<fmt::is_formattable<T>::value>::type>
{
    static void print(std::ostream& os, const T& t) noexcept { os << fmt::format("{}", t); }
};

}
#endif

class mock
{
  public:
    MAKE_MOCK1(function_call, void(const std::string& text));
};

int main() {
	mock test;
	REQUIRE_CALL_V(test, function_call(trompeloeil::re("A")));
#if 0
	test.function_call("A");
#else
	test.function_call("B");
#endif
}

I get an infinite loop (optimized build) or segmentation fault with a backtrace with a loooooong recursion of trompeloeil::duck_typed_matcher<trompeloeil::lambdas::regex_check, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::operator char const*&&<char const*, void, bool>() const ( this=0x4632b8) at trompeloeil/include/trompeloeil.hpp:1151 (debug build) as long as those #if are as they are. If you remove the printer, or make the regular expression match, the problem goes away.

The problem happens with both gcc 11.2 and clang 13.

Using

• trompeloeil v25
• catch
• Mac OS 10.12.6
• apple-clang 8.1

Tests crash with:

libc++abi.dylib: terminating with uncaught exception of type std::__1::system_error: recursive_mutex lock failed: Invalid argument

in trompeloeil.hpp line 3224:

template <typename Sig>
  struct expectations
  {
    ~expectations() {
      active.decommission();
      saturated.decommission();
    }                                    # line 3224   
    call_matcher_list<Sig> active;
    call_matcher_list<Sig> saturated;
  };

Have you seen this before?

Please see the minimal test case. It seems that with all of the following options are met:

• using clang 6.0 or 7.0.1
• using libc++ v6 or v7
• TSAN (-fsanitize=thread) enabled
• optimizing at least -O2

...then line 666 causes two separate mutexes to be created. This quite likely has something to do with multiple translation units.

I cannot help but point out that it cannot be a mere coincidence that the offending line is line 666.

Here's what the thread sanitizer reports. Note that these two threads each lock a "different" mutex even though the actual mutex should be the same as far as I can tell.

==================
WARNING: ThreadSanitizer: data race (pid=4888)
  Write of size 8 at 0x7b0800000028 by thread T1 (mutexes: write M5):
    #0 trompeloeil::sequence_handler<1ul>::retire() <null> (doit+0x4b4871)
    #1 trompeloeil::call_matcher<void (), std::__1::tuple<> >::run_actions(std::__1::tuple<>&, trompeloeil::call_matcher_list<void ()>&) <null> (doit+0x4b31e3)
    #2 trompeloeil::return_of<void ()>::type trompeloeil::mock_func<false, void ()>(std::__1::integral_constant<bool, true>, trompeloeil::expectations<false, void ()>&, char const*, char const*) <null> (doit+0x4af37c)
    #3 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, main::$_0> >(void*) <null> (doit+0x4aed3d)

  Previous read of size 8 at 0x7b0800000028 by main thread (mutexes: write M9):
    #0 check(trompeloeil::sequence const&) <null> (doit+0x4b4f74)
    #1 main <null> (doit+0x4aeb63)

  Location is heap block of size 24 at 0x7b0800000020 allocated by main thread:
    #0 operator new(unsigned long) /var/tmp/portage/sys-libs/compiler-rt-sanitizers-6.0.0/work/compiler-rt-6.0.0.src/lib/tsan/rtl/tsan_new_delete.cc:57:3 (doit+0x4ad9f9)
    #1 main <null> (doit+0x4ae7bc)

  Mutex M5 (0x7b1000000018) created at:
    #0 pthread_mutex_init /var/tmp/portage/sys-libs/compiler-rt-sanitizers-6.0.0/work/compiler-rt-6.0.0.src/lib/tsan/rtl/tsan_interceptors.cc:1211:3 (doit+0x446143)
    #1 std::__1::__libcpp_recursive_mutex_init(pthread_mutex_t*) /var/tmp/portage/sys-libs/libcxx-7.0.1/work/libcxx-7.0.1.src/include/__threading_support:221:28 (libc++.so.1+0x82e6d)
    #2 std::__1::recursive_mutex::recursive_mutex() /var/tmp/portage/sys-libs/libcxx-7.0.1/work/libcxx-7.0.1.src/src/mutex.cpp:54:43 (libc++.so.1+0x82e6d)
    #3 _GLOBAL__sub_I_main.cpp <null> (doit+0x41daff)
    #4 __libc_csu_init /var/tmp/portage/sys-libs/glibc-2.25-r11/work/glibc-2.25/csu/elf-init.c:88:8 (doit+0x4b5274)

  Mutex M9 (0x7b1000000058) created at:
    #0 pthread_mutex_init /var/tmp/portage/sys-libs/compiler-rt-sanitizers-6.0.0/work/compiler-rt-6.0.0.src/lib/tsan/rtl/tsan_interceptors.cc:1211:3 (doit+0x446143)
    #1 std::__1::__libcpp_recursive_mutex_init(pthread_mutex_t*) /var/tmp/portage/sys-libs/libcxx-7.0.1/work/libcxx-7.0.1.src/include/__threading_support:221:28 (libc++.so.1+0x82e6d)
    #2 std::__1::recursive_mutex::recursive_mutex() /var/tmp/portage/sys-libs/libcxx-7.0.1/work/libcxx-7.0.1.src/src/mutex.cpp:54:43 (libc++.so.1+0x82e6d)
    #3 _GLOBAL__sub_I_check.cpp <null> (doit+0x41db9f)
    #4 __libc_csu_init /var/tmp/portage/sys-libs/glibc-2.25-r11/work/glibc-2.25/csu/elf-init.c:88:8 (doit+0x4b5274)

  Thread T1 (tid=4890, running) created by main thread at:
    #0 pthread_create /var/tmp/portage/sys-libs/compiler-rt-sanitizers-6.0.0/work/compiler-rt-6.0.0.src/lib/tsan/rtl/tsan_interceptors.cc:992:3 (doit+0x445035)
    #1 main <null> (doit+0x4aeb51)

SUMMARY: ThreadSanitizer: data race (/home/jkt/temp/clang-tsan-static-mutex/doit+0x4b4871) in trompeloeil::sequence_handler<1ul>::retire()
==================
ThreadSanitizer: reported 1 warnings

I would appreciate some help in minimizing this example so that it does not actually use Trompeloeil so that it can be reported to LLVM upstream.

I was trying an experiment with Catch and Trompeloeil with VS 2015 Update 3, but when including Trompeloeil, I get this:

1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2672: 'std::regex_search': no matching overloaded function found
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2784: 'bool std::regex_search(const std::basic_string<_Elem,_StTraits,_StAlloc> &,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': could not deduce template argument for 'const std::basic_string<_Elem,_StTraits,_StAlloc> &' from 'const auto'
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2965): note: see declaration of 'std::regex_search'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2784: 'bool std::regex_search(const std::basic_string<_Elem,_StTraits,_StAlloc> &&,std::match_results<basic_string<_Elem,_StTraits,_StAlloc>::const_iterator,_Alloc> &,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': could not deduce template argument for 'const std::basic_string<_Elem,_StTraits,_StAlloc> &&' from 'const auto'
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2953): note: see declaration of 'std::regex_search'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2784: 'bool std::regex_search(const std::basic_string<_Elem,_StTraits,_StAlloc> &,std::match_results<basic_string<_Elem,_StTraits,_StAlloc>::const_iterator,_Alloc> &,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': could not deduce template argument for 'const std::basic_string<_Elem,_StTraits,_StAlloc> &' from 'const auto'
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2936): note: see declaration of 'std::regex_search'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2784: 'bool std::regex_search(const _Elem *,std::match_results<const _Elem*,_Alloc> &,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': could not deduce template argument for 'const _Elem *' from 'const auto'
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2921): note: see declaration of 'std::regex_search'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2784: 'bool std::regex_search(const _Elem *,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': could not deduce template argument for 'const _Elem *' from 'const auto'
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2907): note: see declaration of 'std::regex_search'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2782: 'bool std::regex_search(_BidIt,_BidIt,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': template parameter '_BidIt' is ambiguous
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2894): note: see declaration of 'std::regex_search'
1>  c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): note: could be 'std::regex'
1>  c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): note: or       'auto'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2784: 'bool std::regex_search(_BidIt,_BidIt,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': could not deduce template argument for '_BidIt' from 'std::regex'
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2894): note: see declaration of 'std::regex_search'
1>c:\users\mlimber\desktop\test\catchtest\catchtest\trompeloeil.hpp(1402): error C2780: 'bool std::regex_search(_BidIt,_BidIt,std::match_results<_BidIt,_Alloc> &,const std::basic_regex<_Elem,_RxTraits> &,std::regex_constants::match_flag_type)': expects 5 arguments - 3 provided
1>  c:\program files (x86)\microsoft visual studio 14.0\vc\include\regex(2881): note: see declaration of 'std::regex_search'

Reducing my code to include ONLY trompeloeil, not include Catch or anything else, I still get these messages. I tried with the default settings and /std:c++14 just to be safe, but get the same result.

Hi, I have some problems using the trompeloeil in the Visual Studio 2015, it does not support full С++14. Therefore, I think in Visual Studio 2015 need use С++ 11 API trompeloeil.

Maybe it's worth adding test in Appveyor CI with Visual Studio 2015 and Visual Studio 2017.

The cmake file only requires v3.2 cmake_minimum_required(VERSION 3.2) but has at least one feature only introduced in v3.14. ARCH_INDEPENDENT was added in v3.14 https://cmake.org/cmake/help/v3.14/release/3.14.html#modules

This means building with cmake >=v3.2, <v3.14 fails:

user:~/.apps/trompeloeil/build$ cmake -G "Unix Makefiles" ..
-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /usr/share/cmake-3.10/Modules/WriteBasicConfigVersionFile.cmake:30 (message):
  Unknown keywords given to WRITE_BASIC_CONFIG_VERSION_FILE():
  "ARCH_INDEPENDENT"
Call Stack (most recent call first):
  /usr/share/cmake-3.10/Modules/CMakePackageConfigHelpers.cmake:207 (write_basic_config_version_file)
  CMakeLists.txt:9 (write_basic_package_version_file)

Hey

Currently the TIMES macro requires that its argument must be constexpr. This makes it not possible to use in a parametrized test or helper function where the number of calls depends on some parameter.

What is the reason behind this limitation, and can it be removed?

Thanks

I'm currently working in a environment where exceptions is disabled (No /EHxx flags in MSVC and _HAS_EXCEPTIONS=0). When I compile I get the warning: "C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc"

Is it possible to compile a exceptions free version? Something like: DOCTEST_CONFIG_NO_EXCEPTIONS I couldn't find any options in the source?

If not, would it be feasible to implement it, and would it be something of interest?

The state of things right now is that (line) coverage is collected with kcov for Linux builds only, and is forwarded to codecov.io.

There are several problems here, however.

• kcov is (not quite, but effectively) linux only, and it is incompatible with sanitizer builds, which requires a separate step. This project is not married to kcov, so we can use other solutions.
• codecov.io has a limit on the number of coverage uploads it accepts for a single commit SHA-1. We're currently close enough to that limit that a release-push to main plus a tag for the same commit causes uploads to fail because the number of allowed uploads for one commit has been exceeded.
• Regardless of why, the failure to upload coverage information is not a cause to fail a build, even though it is worthy of notice. Is there a middle ground between pass/fail? I have no problem with a release tag build failing an upload if it refers to a successful build of the same git commit, but i also want successful coverage information to PR builds so that I can easily judge if the PR should have more tests or not.
• Can we improve this by collecting coverage information for non-linux builds?

What options do we have to improve the above? Discus