hi, ccan change PCOMM frame size ?, to 512 or 4096 bytes. to get faster communication.

see: simple receive CAN frame 8bytes, send to PCCOMM 8192 bytes.

I changed the value in firmware and driver, but it didn't work.

thanks, Carlos.

channel.cpp:36:20: error: #if with no expression
 #if CFG_MACCHINA_M2
                    ^
exit status 1
#if with no expression

This is my MACCHINA_CONFIG.H:

#ifndef MACCHINA_CONFIG_H_
#define MACCHINA_CONFIG_H_

//#define FW_TEST


#define CFG_MACCHINA_M2
//#define CFG_MACCHINA_A0
//#define CFG_MACCHINA_ESP32_TEST

#endif

(on Windows 10-64)

hi, compiling Firmware.ino = ok, test PCOMM ok (usb) compiling driver = ok on vscode macchina_pt_driver.dll =ok

how to test dll with c# [ loader dll ] or other way

thanks, Carlos

hi, CAN test setup, send/recv frame =ok ISO15765 setup ok, get vin ok in hw.

problems, programa on pc not receive frama can iso.

see log serial: leg- END= pc cmd, LOD= log send to pc, CAN = frame CAN.

00 aa 01 00 01 45 4e 44 0d 0a 02 02 10 00 00 00 .ª...END........ 00 00 06 00 00 00 20 a1 07 00 00 00 00 00 45 4e ...... ¡......EN 44 0d 0a 00 01 16 00 53 74 61 6e 64 61 72 64 20 D......Standard 43 41 4e 20 64 65 74 65 63 74 65 64 21 20 4c 4f CAN detected! LO 47 0d 0a 00 01 22 00 4e 6f 72 6d 61 6c 20 49 53 G....".Normal IS 4f 2d 54 50 20 41 64 64 72 65 73 73 69 6e 67 20 O-TP Addressing 64 65 74 65 63 74 65 64 21 20 4c 4f 47 0d 0a 03 detected! LOG... 04 24 00 00 00 00 00 00 00 00 00 03 00 00 00 04 .$.............. 00 00 00 04 00 00 00 04 00 00 00 00 00 ff ff 00 .............ÿÿ. 00 07 e8 00 00 07 e0 45 4e 44 0d 0a 04 06 0e 00 ..è...àEND...... 00 00 00 00 40 00 00 00 00 00 07 df 09 02 45 4e [email protected]ß..EN 44 0d 0a 00 07 09 00 00 01 00 00 00 00 00 07 df D..............ß 20 43 41 4e 0d 0a 00 07 09 00 00 02 00 00 00 00 CAN............ 00 07 e8 20 43 41 4e 0d 0a 00 07 1d 00 00 00 00 ..è CAN......... 00 00 00 00 07 e8 49 02 01 39 42 57 44 42 34 35 .....èI..9BWDB45 55 34 45 54 30 39 38 37 36 35 20 43 41 4e 0d 0a U4ET098765 CAN..

[ log can bus data: 3-frame 0x7E8 and 1-frame 0x7E0 ]

[00]ª[01][00][01]END [02][02][10][00][00][00][00][00][06][00][00][00] ¡[07][00][00][00][00][00]END [00][01][16][00]Standard CAN detected! LOG [00][01]"[00]Normal ISO-TP Addressing detected! LOG [03][04]$[00][00][00][00][00][00][00][00][00][03][00][00][00][04][00][00][00][04][00][00][00][04][00][00][00][00][00]ÿÿ[00][00][07]è[00][00][07]àEND [04][06][0E][00][00][00][00][00]@[00][00][00][00][00][07]ß [02]END [00][07] [00][00][01][00][00][00][00][00][07]ß CAN [00][07] [00][00][02][00][00][00][00][00][07]è CAN [00][07][1D][00][00][00][00][00][00][00][00][07]èI[02][01]9BWDB45U4ET098765 CAN

read vin = 9BWDB45U4ET098765 send to pc ok

in programa, received rxMsgs.Count = 3 frame ( void , zero bytes )

thanks, Carlos.

GitHub added the old to the current and we ended up with this URL:

https://github.com/FransUrbo/Macchina-J2534/blob/main/github.com/rnd-ash/OpenVehicleDiag

Instead, we need to prefix the URL with https:// to "terminate" it properly.

Ran into compile errors running the build.sh in linux. Not sure if this is linux specific. os-release: NAME="Pop!_OS" VERSION="20.10"

Ended up being a missing dependency, apt install libudev-dev, resolved the issue. Still got a good number of warnings, but the script succeeded.

Nice to see you guys have made lots of progress over the years.

FYI I had started work on an opensource J2534 interface a few years ago and never finished it. The code for K-line was almost complete, maybe it can be useful for reference ? https://github.com/fenugrec/oj2534-fw/blob/master/src/iso_tx.c

It may look strangely constructed, because I was aiming for excellent compliance to timing parameters. That meant putting a timestamp on all bus activity (to enforce P3min, P4min) as well as all incoming bytes (P1max, P2...). It also did firmware-level handling of periodic messages - the idea was to keep all timing-sensitive stuff on the firmware side.

Hi,

I'm struggling to build the sketch for me M2 -> I've already tried to resolve multiple dependencies (FreeRTOS, PWM_Lib, ...) but I'm still not able to build:

Before installing FreeRTOS lib: firmware:1:30: fatal error: Arduino_FreeRTOS.h: No such file or directory

After installing (and resolving some path issues): esp32_can_builtin.h:39:25: fatal error: driver/gpio.h: No such file or directory

Could you maybe list the libraries needed for compilation? I'm not sure if I'm using the correct ones ...

Thank you!

Greetings! As the title above indicates, I have been unable to successfully compile for the M2 as of commit c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae. The merge at commit df450532f4d17fdc6a241bd5b6a6b1f55423dc75 compiles fine, but then the LIN changes afterwards breaks things for me.

The A0 compiles without issue on both builds. The hardware is standard retail M2 with no modifications. I have installed all of the libraries from the M2 documentation, as well as pwm_lib.

MacOS Big Sur (latest) Arduino IDE 1.8.15 (latest)

Arduino: 1.8.15 (Mac OS X), Board: "Macchina M2"

In file included from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channels.h:8:0,
                 from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:1:
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/j2534_mini.h:11:0: warning: "CAN" redefined [enabled by default]
 #define CAN    0x05 // CAN protocol (Uses CAN-D)
 ^
In file included from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/custom_can.h:8:0,
                 from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channels.h:7,
                 from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:1:
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/due_can.h:45:0: note: this is the location of the previous definition
 #define CAN  Can0
 ^
In file included from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/custom_can.h:8:0,
                 from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channels.h:7,
                 from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/channel.h:6,
                 from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/firmware.ino:3:
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/due_can.h:45:0: warning: "CAN" redefined [enabled by default]
 #define CAN  Can0
 ^
In file included from /Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/firmware.ino:2:0:
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/j2534_mini.h:11:0: note: this is the location of the previous definition
 #define CAN    0x05 // CAN protocol (Uses CAN-D)
 ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp: In member function 'void Iso9141Channel::write_data(uint8_t*, uint8_t, bool)':
comm_channel_iso9141.cpp:96:48: error: 'calc_cs' was not declared in this scope
         new_buf[buf_len] = calc_cs(buf, buf_len);
                                                ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp: In member function 'virtual void Iso9141Channel::ioctl_get(uint32_t)':
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:114:85: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
     PCCOMM::respond_err(MSG_IOCTL_GET, ERR_FAILED, "ISO9141 IOCTL get unimplemented");
                                                                                     ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp: In member function 'virtual void Iso9141Channel::wakeup(uint8_t, uint8_t*, uint8_t)':
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:118:41: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
     PCCOMM::log_message("Wakeup started");
                                         ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:121:84: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
         PCCOMM::respond_err(MSG_INIT_LIN_CHANNEL, ERR_FAILED, "Five baud init TODO");
                                                                                    ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:162:81: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
             PCCOMM::respond_err(MSG_INIT_LIN_CHANNEL, ERR_TIMEOUT, "ECU TIMEOUT");
                                                                                 ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:170:81: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
             PCCOMM::respond_err(MSG_INIT_LIN_CHANNEL, ERR_TIMEOUT, "ECU Timeout");
                                                                                 ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp: At global scope:
comm_channel_iso9141.cpp:175:61: error: no 'uint8_t Iso9141Channel::calc_cs(uint8_t*, uint8_t)' member function declared in class 'Iso9141Channel'
 uint8_t Iso9141Channel::calc_cs(uint8_t* buffer, uint8_t len) {
                                                             ^
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp: In member function 'virtual void Iso9141Channel::ioctl_set(uint32_t, uint32_t)':
/Users/savant/Desktop/Macchina-J2534-c9e2ffb6a0f00c01fbdd448c66af42ec92a915ae/firmware/comm_channel_iso9141.cpp:219:89: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
         PCCOMM::respond_err(MSG_IOCTL_SET, ERR_FAILED, "ISO9141 IOCTL set unimplemented");
                                                                                         ^
exit status 1
'calc_cs' was not declared in this scope

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

I've confirmed these same results in Windows 10 as well.

Cheers!

Hi Ashcon! Just curious: did you already think about adding some wireless support to this firmware? I'm not sure if this is at all possible... But maybe in a similar way to the one ESP32 RET is doing it (Serial communication disabled as soon as wifi is connected)?

Hello, first and foremost thank you for all your work on this project. I just received my A0 about 2 hours ago and this was the first thing I wanted to test out.

I appear to have compiled the driver and firmware correctly.

I tested J2534 connectivity in 3 different applications and no joy on any of them-- I took separate logs of each. For reference I have been using the 3 applications below with good success on a Tactrix Openport.

savvycan: device "connects", LED turns green, but no OBD data. If I try to change any settings (such as bitrate to 500K), application crashes.

VW_Flash: "setconfig param name is reserved / tool specific?" is what sticks out to me in the log? Application has a simple "read ECU info" button, which returns no result

Vehical: datalogging software, crashes upon initialization. What sticks out to me:

[WARN ] - Clear message filters unimplemented [WARN ] - Clear periodic messages unimplemented

Any thoughts or ideas? Logs below. Driver issue, firmware issue?Disclaimer I'm not an expert at this, it was my first time installing Rust or Arduino IDE, so user fail is a definite possibility.

macchina_savvycan.txt macchina_log_vw_flash.txt macchina_log_vehical.txt

the sketch compile failed

pt_device_m2.cpp:5:10: fatal error: M2_12VIO.h: No such file or directory
 #include <M2_12VIO.h>
          ^~~~~~~~~~~~
compilation terminated.
exit status 1
M2_12VIO.h: No such file or directory

The https://github.com/TDoust/M2_12VIO library should probably be added to the instructions edit: oops disregard. I had the wrong board selected