Hey! Great work on this, super excited to try DeskGap on a personal project.

Perhaps you could find some ideas on how to add linux from this project: https://github.com/zserge/webview

Using window.location.reload() in code removes the window.deskgap reference and all of the drag functionality from elements with the data-deskgap-drag attribute.

Reloading with BrowserWindow works fine.

Hello,

I was following the guide in the README on Ubuntu Linux 19.04. When I tried to run yarn start I encountered the following error:

$ yarn start
yarn run v1.16.0
warning package.json: No license field
$ deskgap .
/usr/bin/env: ‘node\r’: No such file or directory
error Command failed with exit code 127.

If I execute /usr/bin/env node directly it works as expected:

$ /usr/bin/env node
Welcome to Node.js v12.4.0.
Type ".help" for more information.
> 

Eventually I was able to resolve the issue by running dos2unix on the cli.js file:

$ dos2unix ./node_modules/deskgap/cli.js
dos2unix: converting file ./node_modules/deskgap/cli.js to Unix format...

The file command shows that cli.js (and it looks like the rest of the files too) has CRLF line terminators:

$ file ./node_modules/deskgap/cli.js    
./node_modules/deskgap/cli.js: a /usr/bin/env node script, ASCII text executable, with CRLF line terminators

Add support for 'will-finish-launching': https://electronjs.org/docs/api/app#event-will-finish-launching.

For what I analysed of the code, this seems right. I'm really interested in this project. We're build a tray app and we're just using Electron because of its cross-platform flexibility but I'm feeling it as an overkill. There are some APIs you don't support yet, but I'd like to help with some 😄

Hello!

I'm noticing that when I run DeskGap on MacOS, the created window stays below terminal.. Is there a way to force newly opened window to be on top?

Hello,

I'm currently trying to run a Vue CLI 4 project inside DeskGap 0.3.0 using the following code:

const { app, BrowserWindow } = require('deskgap');

app.on('ready', () => {
    const win = new BrowserWindow({
      frame: false
    });
    // win.loadFile('index.html');
    win.loadURL('http://localhost:8080/')
});

Problem is that the URL is not loaded and instead I get about:blank. This only happens when I load localhost. When loading an external URL (example.com) everything works. I also have the exact same code in electron and it works.

Platform is Win 10 20H1 and Node 13.10.

Bumps pyyaml from 3.13 to 5.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

This snippet create two window, one blank (mainWindow.show()) and one with the website loaded (mainWindow.loadURL())

const { app, BrowserWindow } = require('deskgap');

app.once('ready', () => {
    const win = new BrowserWindow();
	
	mainWindow = new BrowserWindow({
        show: false,
        width: 1280, height: 720,
    }).once('ready-to-show', () => {
        mainWindow.show();		
		// mainWindow.maximize();
    });	   
	mainWindow.loadURL("https://discordapp.com");
	
	mainWindow.on('closed', () => {
        mainWindow = null;
    });
});

My guess: loadURL should take effect inside the associated window instead of creating a new one

Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.

Below are docs for integrating FOSSA license checks into your CI:

• CircleCI
• TravisCI
• Jenkins
• Other

Currently, I'm ramping up with the project. I'm trying to add showItemInFolder support on Windows (just "copying" electron implementation). I encounter a strange issue that when the path string pass into the NAPI side:

shellObject.Set("showItemInFolder", Napi::Function::New(env, [](const Napi::CallbackInfo& info) {
        std::string pathName = info[0].As<Napi::String>();
        UISync(info.Env(), [&]() {
        	Shell::ShowItemInFolder(pathString);
        });
}

The js part pass-in the C:\\Users, but the pathName here is C:User (From debugger view). The inverse slashes are lost. I tried to add more inverse slashes, but none of them shows up here.

I'm a noob in CPP and NAPI. Is this a NAPI issue? I cannot find relative issue around NAPI topic.

The showItemInFolder implantation works... If I hardcode the pathName

shellObject.Set("showItemInFolder", Napi::Function::New(env, [](const Napi::CallbackInfo& info) {
       Napi::Env env = info.Env();
       std::string pathString = Napi::String::New(env, "C:\\Users");
       UISync(info.Env(), [&]() {
        	Shell::ShowItemInFolder(pathString);
       });
}

The folder shows up correctly.

been looking though the project to build a more native application than electron, i was looking to remove the requirement for a package.json but for the life of my cant find where the entry point is loaded (resources/app/package.json/main)

any chance you can point me the right direction before i lose my mind? ^^;

thanks

I understand that this project is no longer maintained and is pretty much dead. But the Electron like APIs and vastly reduced bundle size and support for vibrancy are a must for me. Only thing holding me back is the Node 12.x. I've built the project but can't work out how to upgrade Node. Anyone able to help on this..?

C:\Users\azlan>npm install deskgap npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated [email protected]: this library is no longer supported npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

[email protected] postinstall C:\Users\azlan\node_modules\deskgap node install.js

Downloading deskgap-v0.2.0-win32-ia32.zip Error: GET https://dl.bintray.com/patr0nus/DeskGap/deskgap-v0.2.0-win32-ia32.zip returned 403 Error: GET https://dl.bintray.com/patr0nus/DeskGap/deskgap-v0.2.0-win32-ia32.zip returned 403 at Request. (C:\Users\azlan\node_modules\nugget\index.js:169:61) at Request.emit (events.js:376:20) at Request.onRequestResponse (C:\Users\azlan\node_modules\request\request.js:1059:10) at ClientRequest.emit (events.js:376:20) at HTTPParser.parserOnIncomingClient (_http_client.js:647:27) at HTTPParser.parserOnHeadersComplete (_http_common.js:126:17) at TLSSocket.socketOnData (_http_client.js:515:22) at TLSSocket.emit (events.js:376:20) at addChunk (internal/streams/readable.js:309:12) at readableAddChunk (internal/streams/readable.js:284:9) npm WARN enoent ENOENT: no such file or directory, open 'C:\Users\azlan\package.json' npm WARN azlan No description npm WARN azlan No repository field. npm WARN azlan No README data npm WARN azlan No license field. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"ia32"})

npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! [email protected] postinstall: node install.js npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the [email protected] postinstall script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\azlan\AppData\Roaming\npm-cache_logs\2021-06-06T18_19_54_847Z-debug.log

Platform: Win64 Version: 0.2

Wanted to post this for anyone that runs into this issue. When you show a save dialog on the UI, none of the options will do anything (title, file list, etc...) it will be a generic save dialog with no way to customize.

To fix this you need to clone the project (make sure you download the v0.2 tag - it looks like 0.3 uses a new architecture of some sort without ipcMain & ipcRenderer), look for lib/src/platform/win/dialog.cpp in void Dialog::ShowSaveDialog function add PrepareDialog(saveDialog, options.commonOptions) just as it exists in the showOpenDialog function.

Then to rebuild the 0.2 version, you need to make 1 change in node/CMakeLists.txt where it says FetchContent_Declare(nod...) simply add a reference to the old version of this repository as of v0.2 so it pulls the older code from when 0.2 was current.

This is how it should look in CMakeLists.txt:

set(NOD_NODE_VERSION v12.13.0) FetchContent_Declare( nod GIT_REPOSITORY https://github.com/patr0nus/nod GIT_TAG b65ed548f363d1bd5fab5fe68e3a776351813c61 )

And then everything should rebuild and you can have custom save dialogs 👍

I'm trying to install deskgap from scratch on Ubuntu 20.04. but the npm install already fails during the installation script.

npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm ERR! code 1
npm ERR! path /home/maurice/Dokumente/Beruf/creactive/Bluepic/toolpic-editor/node_modules/deskgap
npm ERR! command failed
npm ERR! command sh -c node install.js
Downloading deskgap-v0.2.0-linux-x64.zip
npm ERR! Error: GET https://dl.bintray.com/patr0nus/DeskGap/deskgap-v0.2.0-linux-x64.zip returned 403
npm ERR! Error: GET https://dl.bintray.com/patr0nus/DeskGap/deskgap-v0.2.0-linux-x64.zip returned 403
npm ERR!     at Request.<anonymous> (/home/maurice/Dokumente/Beruf/creactive/Bluepic/toolpic-editor/node_modules/nugget/index.js:169:61)
npm ERR!     at Request.emit (node:events:369:20)
npm ERR!     at Request.onRequestResponse (/home/maurice/Dokumente/Beruf/creactive/Bluepic/toolpic-editor/node_modules/request/request.js:1059:10)
npm ERR!     at ClientRequest.emit (node:events:369:20)
npm ERR!     at HTTPParser.parserOnIncomingClient (node:_http_client:646:27)
npm ERR!     at HTTPParser.parserOnHeadersComplete (node:_http_common:129:17)
npm ERR!     at TLSSocket.socketOnData (node:_http_client:512:22)
npm ERR!     at TLSSocket.emit (node:events:369:20)
npm ERR!     at addChunk (node:internal/streams/readable:313:12)
npm ERR!     at readableAddChunk (node:internal/streams/readable:288:9)

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/maurice/.npm/_logs/2021-05-06T09_44_51_461Z-debug.log

This looks like an iussue not just with the system's version but with the sources that throw a 403