Hi,

I was using expo-sqlite package with TypeORM package in my React Native app, and I decided to change the adapter to this package.

Everything mostly works, however some of my content are stored using simple-json data type in TypeORM, which uses JSON.stringify to store JSON data in SQLite. When reading this data from SQLite using this package, some of the content are terminated unexpectedly. Not everything. But some of them for example are missing the final } in the string...

Do you have any ideas where this issue may be coming from? Thanks!

I am trying to use my existing DB file which I setup following the guide on rn-sqlite page

The code which I am trying to run is this, everything works fine with sqlite library

const db = QuickSQLite.open('prepop.db');

console.log('db', db.status);
// the db gets opened 0

const res = QuickSQLite.executeSql(
  'prepop.db',
  'SELECT * from employees',
  undefined,
);

// {"message": "[react-native-quick-sqlite] SQL execution error: no such table: employees", "rows": {"_array": [], "item": [Function item], "length": 0}, "status": 1}

I was using raw queries the other day and realized it is kinda awkward to use some of the methods. Also the fact that devs are using the TypeORM wrapper bothers me. I've refactored the code to throw errors (no point in fighting the JS patterns) which makes the code and APIs a bit easier to read/understand. This is however a major refactoring. @EduFrazao would you be willing to give a hand to test this changes?

The term sqlite is sufficiently common as to be inconvenient (for me) to be taken globally. It would be nice if I could import {sqlite as myOtherSqlite} from 'react-native-quick-sqlite';.

Potentially register global object (that is what you need for JSI, yes?) as rnQuickSqlite, which no one else is likely to use, and export const sqlite = rnQuickSqlite; for named imports from this lib.

Looking at this library as a replacement for react-native-sqlite-storage in a project I'm working on and first impressions are great.

I've got requirements for enabling FTS5 and Geopoly extensions. This seems possible with this library as opposed to RNSS since the SQLite source is compiled from /cpp for both iOS and Android, instead of using the phone's SQLite. Is there any method of setting compile-time options for enabling specific extensions (e.g. SQLITE_ENABLE_GEOPOLY) ?

The closest I have reached is presuming that you can set options somewhere in 'CMakeLists.txt' for Android and the podspec for iOS, but I've not been having any luck.

Thanks.

Hi, Is there a way to enable JSON1 module for Android in order to use json_extract in SQL queries ?

This also can be a good point about the cross-platform compatibility since iOS manage it already. Thanks for help.

This prevents partial transactions from committing.

Before this change, if a consuming application caught an error and didn't rethrow it (or a different error), the transaction would commit, leaving the consuming application to clean up bad data. This moves the COMMIT and ROLLBACK calls into the finally blocks for transactions so consuming applications can implement their own error handling and can't accidentally forget to throw an error if one is caught.

Note: the main change for this PR is 3c983cd. The commits leading to it add a missing development dependency and add prettier.

Closes #92.

Description

Hey! Thanks for making this great package. I'm attempting to use it with TypeORM but getting the following error when initializing

1. I have this package, typeorm, reflect-metadata and the required babel plugins installed (tried clearing all cache already)
2. I did the patch mentioned in the readme by adding "./package.json": "./package.json" to the TypeORM package.json file

DataSource setup:

datasource = new DataSource({
    type: 'react-native',
    database: '<db_name>',
    location: 'default',
    // seems like the error is coming from here
    driver: require('react-native-quick-sqlite'),
    entities: [...],
    synchronize: true,
  });

Also looks like the latest commit commented out the TypeORM code from the example project, so I was wondering if the readme is up to date on the necessary steps for getting setup

Additonal info

"react-native": "0.68.2",

I'm trying to use the Async Transactions API and I'm running into a couple issues. It's possible I'm doing it wrong but it doesn't seem like it right now.

After opening the database, I'm purposefully raising an error, hoping to catch it on the JavaScript side:

db.transactionAsync(tx =>
  tx
    .executeAsync("insert into dogs (name) values (?)", ["Sam"])
    .then(res =>
      tx.executeAsync("insert into people (dog_id, name) values (?, ?)", [
        res.insertId,
        "Kirsten",
      ]),
    )
    .then(() => tx.executeAsync(selectAll, []))
    .catch(e => console.log("ERROR", e)),
)

I haven't defined the people table yet so an error is raised.

SQL execution error: no such table: people

Which is what I expect. I'd like to catch this error rather than have a fatal React Native error:

Also, the database is locked after this failure and I'm not sure how to get around that. I assume it's because I was in the middle of a transaction when it failed?

Lastly, the code snippet doesn't type check. I get this TypeScript error:

Type 'Promise<void | QueryResult>' is not assignable to type 'Promise<void>'.
  Type 'void | QueryResult' is not assignable to type 'void'.
    Type 'QueryResult' is not assignable to type 'void'.

To fix this, I'm adding a Promise.resolve call as the last step, which doesn't feel quite right:

db.transactionAsync(tx =>
  tx
    .executeAsync("insert into dogs (name) values (?)", ["Sam"])
    .then(res =>
      tx.executeAsync("insert into people (dog_id, name) values (?, ?)", [
        res.insertId,
        "Kirsten",
      ]),
    )
    .then(() => tx.executeAsync(selectAll, []))
    .then(() => Promise.resolve())                // <----- Added this
    .catch(e => console.log("ERROR", e)),
)

I wonder if the typings should be updated to return either Promise<QueryResult> or Promise<void>?

Removes the version dependent JSError throwing as discussed in https://github.com/ospfranco/react-native-quick-sqlite/pull/83 because the interface changed with https://github.com/facebook/react-native/commit/0035cc9292aca15f07a9d2c51e3e340d5162d5e0. Tested on iOS with RN 0.67.4 and 0.70.0-rc.4 without errors.

throwJSError has been replaced by throwOrDie as per https://github.com/facebook/react-native/commit/0035cc9292aca15f07a9d2c51e3e340d5162d5e0

This works, but it break backward compatibility with RN < 0.70. What would be the best way to provide backward compatibility as well?

How do you typically test code that depends on react-native-quick-sqlite?

Right now, we generally don't write tests near react-native-quick-sqlite or else we crudely stub the library.

I'd like to improve our testing in this area, but I'm faced with either re-implementing quick-sqlite for node or maybe doing something with detox.

To reproduce:

1. npx react-native init BlobRepro --template react-native-template-typescript && cd BlobRepro
2. yarn add react-native-quick-sqlite && npx pod-install
3. Add a function to write maby blobs, e.g.:

  const dbTest = () => {
    const db = open({name: 'test_data.sqlite'});
    const res = db.execute('CREATE TABLE TEST (data blob)')
    // console.log({res})

    const arr = [...Array(100).keys()];
    console.log({a: arr})
    arr.forEach(i => {
      const res2 = db.execute('INSERT INTO TEST (data) VALUES (?)', [new ArrayBuffer(8)])
      console.log({res2})
    });

    db.close()
  }

4. yarn start --reset-cache , yarn ios
5. Run the test code, e.g. via <Button title='dbTest' onPress={dbTest} />
6. Observe app crashes: