I do NOT consider this PR merge-ready yet. It needs testing on Mac and iOS, and support for LoadBitmap needs to be added to the Canvas backend, and maybe the Cairo, AGG and Lice backends. That being said, I'm putting it up for review.

Major changes:

• New overloads for LoadBitmap(), LoadSVG(), and LoadFont() to enable loading resources directly from memory.
• xxd.py in the Scripts directory for generating C++ source/header files from binary files. Ideally this would become part of the build process for users who want to use this feature.

Describe the bug When a IKnobControl is binbed to a param and the param is automated from a DAW the IKnobControl is not updated with the new values of the param.

If I manually rescale the plugin window while the param is been automated a redraw is forced and the knob is properly updated.

To Reproduce

1. Duplicate the IPlugEffect example and compile it as VST3.
2. Create a new track on Ableton with the plugin
3. Automate the Gain parameter
4. Play the song
5. Gain parameter been automated in Live is not updated in the plugin (if you resize the plugin window manually from the windows corner the knob is redrawn and the param value is updated).

Expected behaviour Knob is updated with the new param value automatically.

Tested on Windows 10 as VST3 64bit with NanoVG. Ableton Live 10.

References issue #105 I've spent the last two days or so working on this. I managed to get VST2 and VST3 working in REAPER without too much trouble, GUI and all. It's a little laggy when resizing the GUI, but that could be because I'm using a VM.

The build system uses CMake for maximum compatibility, and will even copy resources into the appropriate folders for each target type. Note that all resources are currently dumped into their respective folder or just the root resources folder, relative paths are WIP.

Now the problem: standalone apps. For some reason the GUI doesn't resize correctly when you open the app. The main window and all internal variables are correct, but the view only displays the top-left 100x100 pixels (that being the default size). I'm not familiar enough with X11 to know what the issue is, so I was hoping some assistance there (@AZSlow3 ?).

I also don't have LV2 support implemented yet, but that experimental LV2 support shouldn't be too hard to add given there's already some code for it.

I also need some decisions on the CMake scripts. When naming variables and functions should I use iplug or iplug2 (e.g. iplug_configure_target vs iplug2_configure_target. I'm leaning towards just iplug given that the C++ namespace is just iplug.

Also: I need to add support for other IGraphics backends on Linux before I'd consider the CMake builds ready.

TL;DR: VST2 and VST3 working (NanoVG, GL2, GL3), need help with App (looks like embedded X11 window isn't resizing properly), and LV2 is NYI.

Just using the performance display, it seems I don't get over 40 frames per second on Windows, on my machine with an integrated GPU or on VM. Should investigate the timer that is used and see if there's a better option

Windows only!

Functions UTF8ToUTF16 and UTF16ToUTF8 seem to produce garbage if language specific characters like "ä","ö","ü" etc are involved. Currently the Windows functions MultiByteToWideChar and WideCharToMultiByte are called with the parameter "CP_UTF8" which seems to be the problem. Using "CP_ACP" instead seems to fix the issue.

All Windows based formats are affected (vst2, vst3, aax).

To Reproduce: Make a folder with with the name "Öffnen" (engl. open) and create a file in this folder. Call PromptForFile and open this file. Full file name shows garbage.

I apologize in advance for the meager description, but the facts are described in the topic along with the photo. I think this is a separate bug.

First - https://github.com/iPlug2/iPlug2/issues/846

Second:

Type plugin: compressor Configuration for Reaper (only) works fine (AUv2, VST3 the sidechain does not work when setting 4-4 channels):

#define PLUG_CHANNEL_IO "\
1-1 \
1.1-1 \
1.2-1 \
2.1-2 \
2-2 \
2.2-2 \
4-4 \
4.1-4 \
4.2-4"

Place this config in a compressor with a side chain. Compile the plugin in AU v2 and VST3 format. Turn on the side chain, or select 4 channels in the Reaper.

I seem to have come across a strange bug in iPlug2-clap, with strange comb filtering happening when using Reaper's FX oversampling feature. The comb filtering is even different between L and R channels. The comb filtering frequency seems to be related to sample rate and buffer size (e.g. 48kHz / buffer 256 => 48000/256 = 187.5 Hz notch, as well as odd multiples of that frequency).

Situation:

Windows 10, 64-bit, everything up to date; Reaper latest dev build: v6.67+dev0908; iPlug2-clap, CLAP_SDK, CLAP_HELPERS, all updated to the very latest versions; Reaper set to 48k (but this is irrelevant, as the same bug occurs on other sampling rates as well).

To reproduce the bug:

• Duplicate IPlugEffect;
• Compile CLAP version;
• Run in Reaper;
• Surround with Bertom EQ Analyzer instances (free), or any other frequency analysing tool;
• With no FX oversampling enabled in Reaper, everything works fine, the frequency response is a straight line;
• With any of Reaper’s FX oversampling settings enabled (make sure to hit Reaper's play button to activate o.s.), and the plugin's gain set to less than 100%, the plugin starts comb filtering, with the comb filtering effect different between left and right channels.
• Switching Reaper’s FX oversampling off (make sure to hit Reaper's play button to deactivate o.s.) makes the comb filtering go away again;
• Testing another CLAP plugin, such as e.g. the Surge effect plugin, does not show this problem, so that excludes Reaper as the source of the bug.
• Testing VST3 instead of CLAP shows no problem, so the problem is limited to CLAP only.

Expected behaviour:

• No comb filtering, straight EQ curve, as is the case in VST3.

I can't determine when exactly this occured, but since few days plugins don't load in Plugindoctor (win-x64, VST2/3). Debug mode shows it fails the assert, I guess it was in IPlugAPIBase::SetHost kHost = kHostUnInit. In Reaper the same binary works fine.

I recently cloned IPlug2 and have been able to build all example projects on windows10 with the exception of IPlugFaustDSP. I am sure that I need to configure the Dependencies/Extras/faust folder..... i'm just not sure how. I'm also curious as to what should go in the civetweb folder. When I open the VS solution for IPlug2FaustDSP, I get the following errors.... Error (active) E1696 cannot open source file "faust/gui/UI.h" IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 18

Error (active) E1696 cannot open source file "faust/gui/MidiUI.h" IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 19

Error (active) E1696 cannot open source file "swell.h" IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust_edit.h 8

Error (active) E1696 cannot open source file "curses.h" IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust_edit.h 9

Error (active) E1696 cannot open source file "curses_editor.h" IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust_edit.h 10

Error (active) E0262 not a class or struct name IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 36

Error (active) E0262 not a class or struct name IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 36

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 203

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 211

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 212

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 213

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 214

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 216

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 221

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 226

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 231

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 236

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 242

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 243

Error (active) E1455 member function declared with 'override' does not override a base class member IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 244

Error (active) E0020 identifier "Soundfile" is undefined IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 244

Error (active) E0282 the global scope has no "dsp" IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 317

Error (active) E0020 identifier "MidiUI" is undefined IPlug2FaustDSP-vst2 C:\SDKs\iPlug2\IPlug\Extras\Faust\IPlugFaust.h 318

Currently, the IPLUG2_ROOT setting in the SDK root's common-win.props overwrites the plugin project's own setting and makes the build fail. Is there any way to avoid this?

I want to put my plugin source code into my source code repo without adding the entire SDK.

Describe the bug Happens with controls inheriting from IKnobControlBase or other IControl base classes if the child class depends on the parent functions. When dragging the mouse the mMouseIsOver flag is not updated which can result in a wrong drawing.

To Reproduce Drag control + mouse up + do not move cursor. When the cursor is moved again OnMouseOut() will reset the flag and the control will draw correctly again. You can observer this behaviour in IPlugControls example.

Expected behaviour Don't have to move cursor, the state is already updated before.

I can never remember IRECT::SubRectXXX(), and now I wonder if they should be IRECT::GetSubRect()...

diff --git forkSrcPrefix/IGraphics/IGraphicsStructs.h forkDstPrefix/IGraphics/IGraphicsStructs.h
index 777d1da502fceef16fd6f95206d86540c70b6e0f..cbc5280a470d53ea2272295ad57d67a0b8843ba9 100644
--- forkSrcPrefix/IGraphics/IGraphicsStructs.h
+++ forkDstPrefix/IGraphics/IGraphicsStructs.h
@@ -936,9 +936,9 @@ struct IRECT
    * @param fromTopOrRight If true the new rectangle will expand from the top (Vertical) or right (Horizontal)
          otherwise it will expand from the bottom (Vertical) or left (Horizontal)
    * @return IRECT the new rectangle */
-  inline IRECT FracRect(EDirection layoutDir, float frac, bool fromTopOrRight = false) const
+  inline IRECT GetFracRect(EDirection layoutDir, float frac, bool fromTopOrRight = false) const
   {
-    if(layoutDir == EDirection::Vertical)
+    if (layoutDir == EDirection::Vertical)
       return FracRectVertical(frac, fromTopOrRight);
     else
       return FracRectHorizontal(frac, fromTopOrRight);
@@ -948,11 +948,11 @@ struct IRECT
    * @param frac width multiplier
    * @param rhs if true, the new IRECT will expand/contract from the right, otherwise it will come from the left
    * @return IRECT the new IRECT */
-  inline IRECT FracRectHorizontal(float frac, bool rhs = false) const
+  inline IRECT GetFracRectHorizontal(float frac, bool rhs = false) const
   {
     float widthOfSubRect = W() * frac;
     
-    if(rhs)
+    if (rhs)
       return IRECT(R - widthOfSubRect, T, R, B);
     else
       return IRECT(L, T, L + widthOfSubRect, B);
@@ -962,11 +962,11 @@ struct IRECT
    * @param frac height multiplier
    * @param fromTop if true, the new IRECT will expand/contract from the top, otherwise it will come from the bottom
    * @return IRECT the new IRECT */
-  inline IRECT FracRectVertical(float frac, bool fromTop = false) const
+  inline IRECT GetFracRectVertical(float frac, bool fromTop = false) const
   {
     float heightOfSubRect = H() * frac;
 
-    if(fromTop)
+    if (fromTop)
       return IRECT(L, T, R, T + heightOfSubRect);
     else
       return IRECT(L, B - heightOfSubRect, R, B);
@@ -979,7 +979,7 @@ struct IRECT
    * @param numSlices number of equal-sized parts to divide this IRECT into
    * @param sliceIdx which "slice" to select
    * @return IRECT the new IRECT */
-  inline IRECT SubRectVertical(int numSlices, int sliceIdx) const
+  inline IRECT GetSubRectVertical(int numSlices, int sliceIdx) const
   {
     float heightOfSubRect = H() / (float) numSlices;
     float t = heightOfSubRect * (float) sliceIdx;
@@ -994,7 +994,7 @@ struct IRECT
    * @param numSlices number of equal-sized parts to divide this IRECT into
    * @param sliceIdx which "slice" to select
    * @return IRECT the new IRECT */
-  inline IRECT SubRectHorizontal(int numSlices, int sliceIdx) const
+  inline IRECT GetSubRectHorizontal(int numSlices, int sliceIdx) const
   {
     float widthOfSubRect = W() / (float) numSlices;
     float l = widthOfSubRect * (float) sliceIdx;
@@ -1007,12 +1007,12 @@ struct IRECT
    * @param numSlices Number of equal-sized parts to divide this IRECT into
    * @param sliceIdx Which "slice" to return
    * @return IRECT the new rectangle */
-  inline IRECT SubRect(EDirection layoutDir, int numSlices, int sliceIdx) const
+  inline IRECT GetSubRect(EDirection layoutDir, int numSlices, int sliceIdx) const
   {
-    if(layoutDir == EDirection::Vertical)
-      return SubRectVertical(numSlices, sliceIdx);
+    if (layoutDir == EDirection::Vertical)
+      return GetSubRectVertical(numSlices, sliceIdx);
     else
-      return SubRectHorizontal(numSlices, sliceIdx);
+      return GetSubRectHorizontal(numSlices, sliceIdx);
   }
   
   /** Get a subrect of this IRECT expanding from the top-left corner

Describe the bug IPeakAvgSender::mBuffers[_][i] goes out of range when rapidly increasing the window size.

To Reproduce Create a knob and call SetPeakHoldTimeMs in onParameterChange.

Code https://github.com/iPlug2/iPlug2/blob/ca8f60f08c812896394ea3ed7a5391a9ae085ccd/IPlug/ISender.h#L272-L277 https://github.com/iPlug2/iPlug2/blob/ca8f60f08c812896394ea3ed7a5391a9ae085ccd/IPlug/ISender.h#L319-L341

Fix Do not resize the buffer (?)

IMPORTANT DETAILS

• What plug-in format does it relate to - all
• What platform does it relate to - Windows, probably all

Describe the bug IPlugInstrument (and other instruments) freeze when disconnecting headphones. Sometimes it freeze only after trying to switch to mac speakers.

To Reproduce -Build and run IPlugInstrument App on mac with headphones connected (make sure you get the sound on your headphones). -Disconnect the headphones. -Change output device in preferences to internal speakers.

Expected behaviour The app should not freeze, and follow the system default device automatically.

IMPORTANT DETAILS Mac App version, M1 and intel. Didn't test this on windows.

Additional context IplugEffect dose not freeze.

Some graphics dependencies are being added in the iPlug2_Core cmake library, we should add it only in iPlug2_IGraphicsCore (it is already included). This is causing iPlug2_NoGraphics to fail, as the necessary graphics sources are not included in that option.