First I want to say thanks for all your work and especially for publishing it all under GPLv3. You rock! Did you ever consider implementing some theming support based on xml configuration files? SDL already is a good framework for game development. The neogfx project adds lots of UI components / framework, but as far as I know there is no "decent enough" game theming project out there. Maybe something XML based (a little bit like done in WPF) would be great! That would allow users / theme designers / modders to edit the look and feel of the applications UI, and software developers could focus more on the game logic, graphics effects, fixing bugs,... without having to care about horribly bad / legacy self-made theming systems to allow users to modify the location, size, partial transparency,... of user interface elements.

Add support for font face object destruction (reference counted destruction); increase granularity of glyph texture bin packs so they can be freed more readily (suggest 512x512 textures for each font tace).

DesignStudio.exe!af_face_globals_get_metrics(AF_FaceGlobalsRec_ * globals, unsigned int gindex, unsigned int options, AF_StyleMetricsRec_ * * ametrics) Line 458	C
DesignStudio.exe!af_loader_load_glyph(AF_LoaderRec_ * loader, AF_ModuleRec_ * module, FT_FaceRec_ * face, unsigned int glyph_index, int load_flags) Line 306	C
DesignStudio.exe!af_autofitter_load_glyph(AF_ModuleRec_ * module, FT_GlyphSlotRec_ * slot, FT_SizeRec_ * size, unsigned int glyph_index, int load_flags) Line 489	C
DesignStudio.exe!FT_Load_Glyph(FT_FaceRec_ * face, unsigned int glyph_index, int load_flags) Line 978	C

DesignStudio.exe!neogfx::native_font_face::glyph_texture(const neogfx::glyph & aGlyph) Line 289 C++ DesignStudio.exe!neogfx::glyph_text_factory::to_glyph_text(const neogfx::i_graphics_context & aContext, const char32_t * aUtf32Begin, const char32_t * aUtf32End, const neogfx::i_font_selector & aFontSelector) Line 720 C++ DesignStudio.exe!neogfx::glyph_text_factory::to_glyph_text(const neogfx::i_graphics_context & aContext, const char * aUtf8Begin, const char * aUtf8End, const neogfx::i_font_selector & aFontSelector) Line 413 C++ default.nel!neogfx::i_glyph_text_factory::to_glyph_text(const neogfx::i_graphics_context & aContext, const std::basic_string_view<char,std::char_traits> & aString, std::function<neogfx::font __cdecl(unsigned __int64)> aFontSelector) Line 539 C++ default.nel!neogfx::graphics_context::to_glyph_text(std::_String_const_iterator<std::_String_val<std::_Simple_types>> aTextBegin, std::_String_const_iterator<std::_String_val<std::_Simple_types>> aTextEnd, std::function<neogfx::font __cdecl(unsigned __int64)> aFontSelector) Line 951 C++ default.nel!neogfx::graphics_context::to_glyph_text(std::_String_const_iterator<std::_String_val<std::_Simple_types>> aTextBegin, std::_String_const_iterator<std::_String_val<std::_Simple_types>> aTextEnd, const neogfx::font & aFont) Line 946 C++ default.nel!neogfx::graphics_context::to_glyph_text(const std::string & aText, const neogfx::font & aFont) Line 941 C++ default.nel!neogfx::basic_item_presentation_model<neogfx::basic_item_model<void *,0,neogfx::item_cell_data,neogfx::item_flat_container_traits<void *,neogfx::item_cell_data,0,0>>>::cell_glyph_text(const neogfx::item_presentation_model_index & aIndex, const neogfx::i_graphics_context & aGc) Line 781 C++ default.nel!neogfx::basic_item_presentation_model<neogfx::basic_item_model<void *,0,neogfx::item_cell_data,neogfx::item_flat_container_traits<void *,neogfx::item_cell_data,0,0>>>::cell_extents(const neogfx::item_presentation_model_index & aIndex, const neogfx::i_graphics_context & aGc) Line 792 C++ default.nel!neogfx::basic_item_presentation_model<neogfx::basic_item_model<void *,0,neogfx::item_cell_data,neogfx::item_flat_container_traits<void *,neogfx::item_cell_data,0,0>>>::column_width(unsigned int aColumnIndex, const neogfx::i_graphics_context & aGc, bool aIncludePadding) Line 273 C++ default.nel!neogfx::drop_list::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 977 C++ default.nel!neogfx::layout_item_cache::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 419 C++ default.nel!neogfx::layout::do_minimum_size<neogfx::layout::row_majorneogfx::vertical_layout>(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 167 C++ default.nel!neogfx::vertical_layout::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 72 C++ default.nel!neogfx::layout_item_cache::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 419 C++ default.nel!neogfx::layout::do_minimum_size<neogfx::layout::column_majorneogfx::horizontal_layout>(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 167 C++ default.nel!neogfx::horizontal_layout::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 72 C++ default.nel!neogfx::layout_item_cache::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 419 C++ default.nel!neogfx::layout::do_minimum_size<neogfx::layout::row_majorneogfx::vertical_layout>(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 167 C++ default.nel!neogfx::vertical_layout::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 72 C++ default.nel!neogfx::widgetneogfx::i_widget::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 1056 C++ default.nel!neogfx::framed_widget<neogfx::widgetneogfx::i_widget>::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 138 C++ default.nel!neogfx::window::client::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 138 C++ default.nel!neogfx::layout_item_cache::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 419 C++ default.nel!neogfx::layout::do_minimum_size<neogfx::layout::row_majorneogfx::vertical_layout>(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 167 C++ default.nel!neogfx::vertical_layout::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 72 C++ default.nel!neogfx::layout_item_cache::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 419 C++ default.nel!neogfx::layout::do_minimum_size<neogfx::layout::row_majorneogfx::vertical_layout>(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 167 C++ default.nel!neogfx::vertical_layout::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 72 C++ default.nel!neogfx::widgetneogfx::i_window::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 1056 C++ default.nel!neogfx::framed_widget<neogfx::widgetneogfx::i_window>::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 138 C++ default.nel!neogfx::window::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 550 C++ default.nel!neogfx::font_dialog::minimum_size(const neolib::optional<neogfx::basic_size> & aAvailableSpace) Line 272 C++ default.nel!neogfx::widgetneogfx::i_window::layout_items(bool aDefer) Line 763 C++ default.nel!neogfx::window::center_on_parent(bool aSetMinimumSize) Line 680 C++ default.nel!neogfx::font_dialog::init() Line 381 C++ default.nel!neogfx::font_dialog::font_dialog(neogfx::i_widget & aParent, const neogfx::font & aCurrentFont, const neolib::optionalneogfx::text_appearance & aCurrentAppearance) Line 226 C++ default.nel!neogfx::DesignStudio::sticky_note::sticky_note'::`2'::<lambda_5>::operator()'::`2'::<lambda_1>::operator()() Line 126 C++ default.nel!std::invoke<neogfx::DesignStudio::sticky_note::sticky_note'::2'::<lambda_5>::operator()'::2'::<lambda_1> &>(neogfx::DesignStudio::sticky_note::{ctor}::__l2::<lambda_5>::()::__l2::<lambda_1> & _Obj) Line 1586 C++ default.nel!std::_Invoker_ret<void,1>::_Call<neogfx::DesignStudio::sticky_note::sticky_note'::`2'::<lambda_5>::operator()'::`2'::<lambda_1> &>(neogfx::DesignStudio::sticky_note::{ctor}::__l2::<lambda_5>::()::__l2::<lambda_1> & _Func) Line 745 C++ default.nel!std::_Func_impl_no_alloc<neogfx::DesignStudio::sticky_note::sticky_note'::2'::<lambda_5>::operator()'::2'::<lambda_1>,void>::_Do_call() Line 921 C++ default.nel!std::_Func_class::operator()() Line 969 C++ default.nel!neolib::event<>::enqueue(std::optional<std::scoped_lockneolib::switchable_mutex> & aLock, neolib::event<>::handler & aHandler, bool aAsync, const std::optional & aAsyncTransaction) Line 763 C++ default.nel!neolib::event<>::sync_trigger() Line 580 C++ default.nel!neolib::event<>::trigger() Line 530 C++ default.nel!neolib::plugin_events::event<>::trigger() Line 82 C++ default.nel!neogfx::menu_item_widget::select_item(bool aOpenAnySubMenu) Line 429 C++ default.nel!neogfx::menu_item_widget::mouse_button_released(neogfx::mouse_button aButton, const neogfx::basic_point & aPosition) Line 230 C++ default.nel!neogfx::surface_window::native_window_mouse_button_released(neogfx::mouse_button aButton, const neogfx::basic_point & aPosition) Line 543 C++ DesignStudio.exe!neogfx::native_window::handle_event() Line 264 C++ DesignStudio.exe!neogfx::native_window::handle_event(const neolib::variant<neogfx::window_event,neogfx::basic_mouse_event<1>,neogfx::basic_mouse_event<2>,neogfx::keyboard_event> & aEvent) Line 163 C++ DesignStudio.exe!neogfx::native_window::pump_event() Line 154 C++ DesignStudio.exe!neogfx::opengl_renderer::process_events() Line 365 C++ DesignStudio.exe!neogfx::native::windows::renderer::process_events() Line 459 C++ DesignStudio.exe!neogfx::surface_manager::process_events(bool & aLastWindowClosed) Line 215 C++ DesignStudio.exe!neogfx::app::do_process_events() Line 748 C++ DesignStudio.exe!neogfx::app::process_events(neogfx::i_event_processing_context & __formal) Line 690 C++ default.nel!neogfx::context_menu::exec() Line 75 C++ default.nel!neogfx::text_edit::mouse_button_released(neogfx::mouse_button aButton, const neogfx::basic_point & aPosition) Line 515 C++ DesignStudio.exe!neogfx::surface_window::native_window_mouse_button_released(neogfx::mouse_button aButton, const neogfx::basic_point & aPosition) Line 543 C++ DesignStudio.exe!neogfx::native_window::handle_event() Line 264 C++ DesignStudio.exe!neogfx::native_window::handle_event(const neolib::variant<neogfx::window_event,neogfx::basic_mouse_event<1>,neogfx::basic_mouse_event<2>,neogfx::keyboard_event> & aEvent) Line 163 C++ DesignStudio.exe!neogfx::native_window::pump_event() Line 154 C++ DesignStudio.exe!neogfx::opengl_renderer::process_events() Line 365 C++ DesignStudio.exe!neogfx::native::windows::renderer::process_events() Line 459 C++ DesignStudio.exe!neogfx::surface_manager::process_events(bool & aLastWindowClosed) Line 215 C++ DesignStudio.exe!neogfx::app::do_process_events() Line 748 C++ DesignStudio.exe!neogfx::app::process_events(neogfx::i_event_processing_context & __formal) Line 690 C++ DesignStudio.exe!neogfx::app::exec(bool aQuitWhenLastWindowClosed) Line 352 C++ DesignStudio.exe!main(int argc, char * * argv) Line 45 C++ DesignStudio.exe!invoke_main() Line 79 C++ DesignStudio.exe!__scrt_common_main_seh() Line 288 C++ DesignStudio.exe!__scrt_common_main() Line 331 C++ DesignStudio.exe!mainCRTStartup(void * __formal) Line 17 C++ kernel32.dll!00007ffaae317c24() Unknown ntdll.dll!00007ffaae58d4d1() Unknown

Crash on drop list click off (regression).

To reproduce:

Click the show list button of the second test drop list; hover mouse over "Circle" click on main test app window.

Parent dialog not displayed disabled whilst child modal dialog is displayed; more specifically when the gradient selection dialog is opened in the neoGFX Test App this happens: it may be related to use of popup menu to open the dialog.

Kerning is being applied twice: once by Harfbuzz and once using Freetype kerning tables. Enabling/disabling kerning should be done via Harfbuzz and Freetype kerning should never be used.

Separate kerning support will still be required for sprite sheet fonts.

If you click and hold down mouse button on an item view cell with click to edit enabled then move mouse then release mouse button moving the mouse continues to move selection as if mouse still captured.

ZALGO text doesn't appear to render correctly (or at least not as Chrome renders it):

T̢̩̲̣̺͎̭̬̾̎͂̆̃̈ͯ̔ͤ͜ō̡͇͍͙͋̑̀ͥ͜ ̵͇̪̩̬̪͉͚̙͑́̍̊͐̀ȋ̿̀҉̰͇̪͔͇̪̝̯̭ṅ̯̟̤͎̀͒̓͝v̽̓̉̈́ͯ͏̬̦̪̯̙o̮̟̐͛ͨ̾ͧ͠k̶͉͔ͫ̋̽̉̊͊͝ë̪̮̬̮̪́̾͘͜ ̢̼̰͛ͧ̀ṯ̢̣͕̙̝̲̌ḩ̨̖̲̹̩̞̘̰̯̂́ͫeͩ҉҉͉̯͡ ̨͋҉̰̣̣h͗́̊ͨͭ̄̑ͣ̚͏̣̹̖̫͉͈̗̯i̴̧̛̩̪̰͔ͣ̄̌̅̽͐ͮv̷͍̣͔̳͂͗̈͒̄ͦ̚e̢̯̫ͪ͂̃ͮ̑ͭ̓-͎̘̄ͩ̎̀͋͘͝m̢͈̜͉̹͈̼͆́ͅi͚̫̜̯͚̬͙ͭ͛ͮ̿́̚͡n̨͚̘̞͆̋̓ͪ͌ͬ̇̽̽d̫͖̣͍̣̻͖̲̠͗̒͒̎͢͟ ̴̧̨͙̝͚̰̮̔̾̓̃ͥ͑̆̈́̐ŗ͙̮̝̳͖̞͔ͨ̇̐͊̀̕ĕ̥̗͎̰̮͑̾̋̉ͨͮ̓́p͙̯͕͓̭̲̈ͭ́͋̍ͦ̓͠r̷̢̙̹̤ͬ̅͋͐̊ͤͭȅ̖̗ͧͤ̍̕s̵̝̠͙̦͕̘͕ͨ͊̊̎̽ͅě̡͔̦͎͍̰̬͔ͦ̇̾̚͟ͅn̪̜̹͉̟ͩ́̍ͣ̍͜ẗ͓̯̖̞̭̝̤́ͪ̓̽ͧ̿ͦ̉į̣͇̞̥̻̞͐̈́́͘͡n̘̬͖͇̖̟͚ͯ̆̔̾̆͡͞g̢͎̫͓͎̬̥͆ͯͅ ̧̟̖̘̮̫͕̞̩ͥ̎c̸̘ͦ͞ḩ̵̩̤̦̟̖̒͒͗̋͡a̬̭̬ͪ͌ͤ̊̉͐͐́̀o̷̡̼̟͕̠̪̼̦̰͚͒͋ͯ̓͑̓͛́s̸̺̲̗ͩ̐͞.̛̻̩̞̬̝͍̗̼͒ͮ̓̂͂̊̅͘ ̂ͤ̎́͑̓̕͡͏͓̯I̶͉̲̠̻̪̱̽͊̀ñ̩̼̤̝̠͈̌ͫ́ͪ͊̚v̸͙̞̥͓̜̒̃̿̈́͘ͅò̮͈̙ͥ̈͗͗͜k̂̎̂̾ͨ͏̤̗̦̻̖͍̼i͆͛̅ͯ͑̚҉͍̺̗̹͎͉̣̖̠͘n̵̷̠̭̦̳̽͊ͩ̒̚g̷̪͚̮̟̻͍͐̅ͩ̅̄ ͎͖̭̟̻̞͚͒̆͛̆̔ͪ̚̕͢ṱ̟̪̄͑̀ͮ͋̂ḧ̵̢͖͍̺́̈́e̛̫̱̓ͤ̓ͩ̄̈́̓̕ ̸͐͐̊͋ͩ̆̍̅̚҉̷̲̭̲f͙̬̳̦̜̆͆e̴̡̛̲̺̘̣̝̘͋̓̐ͩ̾ͨ̈́̌e̡̻̭̤̦̞̱͈̘͂̍̿̄͟l̶̛̗̤̈́̊ͣ̎͂ȋ̶͖͍̖̽̀ͭņ̴̮͎̱͓ͯ͆͛ͮͨͭg̻̖̲̪̦͍͇̮̟ͯ̓̇̄ ̠͔͉̪͔̅̾̇̎͂͂ͅő̱̰̦͈͍̩̙̜́ͨ͜f̘̱ͨ ̸̲̬̯̤̝͇̦̯̌̆̿ͭͥ͋͐ç̷̛̥͍̳̗̠͚̄͑̐h͚͈͓͈͇͙͉̭͌̽ͦ͋ͧ̓̐a̷̩̻̽͋͊̀͑̕͢o̸̶͇̰̦ͪ͐́̿̆̔̾š̶̵̫̫̠̝̪̮͑͜.̢̲̪͆͑̇͛̈̊ͬ̕ ̺͎͔̪̜̜̣͚̅̏ͥ̋̈͘W̘̙͓̻͎͖͉̖̣͆̔̅ͥ̅̈́̾͡i̊͗͏̡̱̜̙̖̹͘t̨͖͖̙ͯͯͥ͘h̼͖̘ͥ́ͮ̎ͫ̈̐͗͝͠ ̴̥̳̖̩̺̠̳̋͑͛̽͗͒̋͜ǫ̵̬̩̌̍͑́̀u͎̩͔͆ͮ͐̈́̓͛t̡͓͔͖̤̽̌ ̴͙̫̤̖̭̰̲̹͗̄ͥͤ̈́ͥ͆̂́oͫ̃̈́̃͏̳̙͔͉͍̕͝ř̸̢̰͈͇̰͓͙ͦ͌̀ͨ̆͗̚d̍͢҉̻͍̙̯͕̘͓͙̹ë͇̝̪͕̣͓̀͢͠r̙̩̗͉̘̎͛ͧ̈́̎̋̋̅͘͝.̳̦ͯ̊͑̆̋̓͋ ̛̮͚̜̣̟̄ͪ͑͡T̸̸͚̣͍̺̀ͪ̀h͓̱̫͙̮̣̉͗̇͝ͅe̾ͭ̍҉̴̯̹̦͎̺͞ ̴͇͈͑̀́ͅṈ̟̠̝̝̟̪͚̔͐̎̋̄̑̃̚͞e̵̝̎ͭ͌̐̇̋z̧͎̳̻͙͖̾̿̓ͫͭ̚͞͝p̵̠͖͙͓̀͑͑ͨͤ̆̇͘ȩ̷̤̤̮̫̼̮̍͗͑͘r̶̸͉͚͎̞̐ͪd̷̈́̈́ͯ̉ͭͯ͏̩̭͔͎̥̻̩̮i̹̹̋̽̐̉ͤ̽̅̇͡ͅa̴̘̻̔̎̐̿ͤ́̔͌ͣ͝n̨͈̫̝͈̹̟̙̣̂ͭͥ̑̀ ͒̄̊͛͌̃̽̉͏̖͈̺̙h̜͉͊ͬ̔̈́̉ͮ̅͜í̬̖̅v̩̺̹͔̼̈́e̴̫̺̳͍̲̩͈ͫ͐ͥ̂͆͑-̢̨̘̯͖͛́m̨̳̜̮̗͕̟̬̼͋̇͗͟ͅi̪ͦͤ́̂n̴͕͚͉̆̾ͮ͌̐͛́ḋ̢̰̥͉̪̏ͫ̑͟͝ ͙̯̤͉͇͔ͨͧ͐͗̋͞͞o̶̠̳̭͛͗͐ͨ͛ͭ͂ͫf͔̹ͥ͛̋ ̶̮͖̟̩̺̲̝̤͇̽͂č̲͚̜͖̙̃̔̌́ͅḧ̽͏̧͏̥͍͇̼̙̺a̷̼̮̓̑̅ͬͯ̚̕ō͚̞̭̿ͫ͊ͧͅs̨͓̫͔̰̦̠̼ͭ̀ͯ.͓̖̤̳̘̮̙̞͔͆̇͞ ̄́̎̌͊҉͈̭̳Z̸̩̼ͪ̎͌a̧̱̖͉̰̔̃ͥ͞l̝̀ͨ̈́̚͞g̓ͪ̉̾̈͋͏͏̺͉ơ̫̲͛̔͆͌ͬ̄͢.̢̪͉̠̱̥̬͇͉͑̓ͬͨ͊̋͌͌͜ ͫ̓ͫͪ̒̈͋҉͖͇͇H̶͔̺̭͚ͬͫ͒̈́͆͝e͖̺̤͉̹͓̲ͭͪ̊̐̎̍͊̀̀͡ ̪̣̺̅̏ͬͩͮͫͩ̔w̞̪̥ͦ͝h̬̻͉̥͎̺͖̺̰͒̉̋̎ͪo̢̪̤̺̹͓͈̫̿ͩͤͣ̍͠ ̂̎̌͌̾̏̎̀҉̝͍͖͕͕̼̲W̵̢͕̺͍̩̓ä́̓̊̓͝҉͔̣͉̠̯̭̲i̶̮͎͖ͦ̊́̽̉̅̀̚t̻̣̝̭̘͔͆͒͋s̋ͩ̉ͥ̂͐͐̀҉̯͈̩̳̖̱̳ ̡̝̩͕͇͔͔͋ͫ́B̼̹̩̯͎ͫͪ̎̈̅͌̉͠e̘͇̘ͣ̓͐͆͂ͩ̈́̏͝͠h̴̬͇̪̞̳͗ͧi̲̠̫̭͓͌͋ͦ́ň̾̔͐͊̒̉ͧ҉҉͍͉͇͓d̘̞̗͉ͭͧ͛͛ͪ̌͡ ̏̽̽͆̃̂̐͘҉̟̞̗̙̱̙T̵͉͆͐̇́ͪ̚͢h̨̯̫̮̤͛̎ͣ̉ͦͯͪ̎̽ḙ̡̅̍ͅ ͇͍̜ͯ̏ͫ͘W̴̼̝̊̓̔ͥ͆ͩ̚̚͢ạ̟͍̌ͭ̇ͧ̿̓̽ͣl̓ͤͧ҉̴̯͚̥͉͙͍͈͔l̓͟҉̣̣̦̝͔̺.̢͇̘͖̟͎̬̹͔̆ͫ̈́ͬ͛͌ͣ̎̅͘͝ ̼̗̩̼̹̦͎̆͆̇ͬ͗̊̒̀̀Z̸̬̽̉ͯ͒ͣ̈́͆͌A̸̠̖̙͎̻̯̤̮ͩͥ͋͌̒ͪͣͬ̃͟L̸͎̪̣̞̦ͯ̄̎̀̆̏G̜̠̝ͬ͒ͧ͆ͦͭ͒̚ͅO͚̘̩͍̬̱͌̓̎̈́̊̉̽!̛̠̜͙̰͎̻ͪ

Create font token (uint16_t) concept. Store font tokens in glyphs allowing removal of explicit font fallback information in glyphs. Investigate possibility of moving even further down the flyweight pattern road.