I followed the instructions as given here - http://s2geometry.io/about/platforms.html but I am getting these errors when I run cmake

-- The following features have been enabled:

• GFLAGS, allows changing command line flags.
• GLOG, provides logging configurability.
• SHARED_LIBS, builds shared libraries instead of static.

GTEST_ROOT: /usr/src/googletest File "/usr/lib/python3.6/site.py", line 183 file=sys.stderr) ^ SyntaxError: invalid syntax CMake Error at src/python/CMakeLists.txt:30 (install): install TARGETS given no LIBRARY DESTINATION for module target "_pywraps2".

CMake Error at src/python/CMakeLists.txt:31 (install): install FILES given no DESTINATION!

-- Configuring incomplete, errors occurred! See also "/home/winash12/S2source/s2geometry/CMakeFiles/CMakeOutput.log". See also "/home/winash12/S2source/s2geometry/CMakeFiles/CMakeError.log". This is on Ubuntu 18.04 LTS.

We're trying to track down the source of a warning that we are required to silence for the R package s2 (in order to keep the package on CRAN). A new test has been added to the CRAN servers with the development version of gcc (i.e., gcc11). Compiling the s2 package gives new warnings with -Warray-bounds in s2/util/gtl/btree.h, and nether myself nor @edzer have the expertise to know if these errors are (1) a bug in gcc11, (2) real but not important, or (3) an actual out-of-bounds array error. There is an issue thread of our struggles with this here: https://github.com/r-spatial/s2/issues/79

I've put together a reprex to illustrate the problem...unfortunately it involves building gcc11 from source (which is what CRAN has done). The gist version is here: https://gist.github.com/paleolimbot/51db5e587b5f3e57a637b6a24655fe87

Note that all of

• gcc11/devel
• map[4] = 4; (i.e., insertion)
• -DNDEBUG and
• -O2

...are necessary to reproduce.

git clone https://gist.github.com/51db5e587b5f3e57a637b6a24655fe87.git gcc11-gtl-btree
cd gcc11-gtl-btree
# this takes several hours
docker build . --tag r-gcc11
docker run --rm r-gcc11 g++ --version

g++ (GCC) 11.0.0 20201024 (experimental)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

# with latest github s2
curl -L https://github.com/google/s2geometry/archive/master.zip --output s2.zip
unzip s2.zip
docker run --rm -v $(pwd):/test -w /test r-gcc11 g++ -std=c++11 -I s2geometry-master/src -O2 -DNDEBUG -Warray-bounds test.cpp -o test

In file included from s2geometry-master/src/s2/util/gtl/btree_map.h:34,
                 from test.cpp:3:
s2geometry-master/src/s2/util/gtl/btree.h: In function ‘int main()’:
s2geometry-master/src/s2/util/gtl/btree.h:604:22: warning: array subscript [33, 287] is outside array bounds of ‘absl::container_internal::Allocate<8, std::allocator<std::pair<int* const, std::pair<int, bool> > > >::M [32]’ [-Warray-bounds]
  604 |     mutable_child(i) = c;
      |     ~~~~~~~~~~~~~~~~~^~~
In file included from /usr/local/include/c++/11.0.0/x86_64-pc-linux-gnu/bits/c++allocator.h:33,
                 from /usr/local/include/c++/11.0.0/bits/allocator.h:46,
                 from /usr/local/include/c++/11.0.0/memory:64,
                 from s2geometry-master/src/s2/util/gtl/btree_map.h:30,
                 from test.cpp:3:
/usr/local/include/c++/11.0.0/ext/new_allocator.h:121:48: note: referencing an object of size between 48 and 256 allocated by ‘void* operator new(std::size_t)’
  121 |         return static_cast<_Tp*>(::operator new(__n * sizeof(_Tp)));
      |                                  ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
In file included from s2geometry-master/src/s2/util/gtl/btree_map.h:34,
                 from test.cpp:3:
s2geometry-master/src/s2/util/gtl/btree.h:597:58: warning: array subscript [32, 287] is outside array bounds of ‘absl::container_internal::Allocate<8, std::allocator<std::pair<int* const, std::pair<int, bool> > > >::M [32]’ [-Warray-bounds]
  597 |   btree_node *child(int i) const { return GetField<3>()[i]; }
      |                                                          ^
In file included from /usr/local/include/c++/11.0.0/x86_64-pc-linux-gnu/bits/c++allocator.h:33,
                 from /usr/local/include/c++/11.0.0/bits/allocator.h:46,
                 from /usr/local/include/c++/11.0.0/memory:64,
                 from s2geometry-master/src/s2/util/gtl/btree_map.h:30,
                 from test.cpp:3:
/usr/local/include/c++/11.0.0/ext/new_allocator.h:121:48: note: referencing an object of size between 48 and 256 allocated by ‘void* operator new(std::size_t)’
  121 |         return static_cast<_Tp*>(::operator new(__n * sizeof(_Tp)));
      |                                  ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~

Hey, having read #40, I'd like to push again for a tagged release. Reason for asking is that package managers, e.g. Homebrew, won't accept a package for S2 unless there is a tagged version. It would be very much appreciated.

I added some code which should make the exactfloat class compatible with OpenSSL 1.1 Could probably be faster by using unaligned memory access on x86 https://github.com/google/s2geometry/issues/5

For reference see the manual page: https://www.openssl.org/docs/man1.1.0/crypto/BN_bn2lebinpad.html

Hi, great to see the new version of S2 out - very cool!

I know a lot of people use the old version of S2 (us for example) and link it statically into their application. That was fairly easy to do with the old version, but now with the GFlags, GLog dependencies it's a lot more onerous and also affects downstream build system requirements.

Is there any chance you might consider an option to allow building the core without requiring any dependencies, aside from libssl of course.

Best

I am trying to write a function to check if two MBRs intersect. My first thought was to create two S2Polygons and use the intersectsmethod. In order to do that I have to create S2Loops from the points of each MBR with something like this:

    vector<S2Point> points1;

    points1.push_back(S2Point(s.xLow, s.yLow,0));
    points1.push_back(S2Point(s.xHigh, s.yLow,0));
    points1.push_back(S2Point(s.xHigh, s.yHigh,0));
    points1.push_back(S2Point(s.xLow, s.yHigh,0));
    S2Polygon a(make_unique<S2Loop>(points1));

I do not use .Normalize() as my points are already normalized. I get the following error ERROR Edge 1 crosses edge 3. I believe that this is caused because S2Loop creates the full loop and connects every point with every other.

Question 1: Is it possible to connect only the 4 points I give in that order?

Following the recommendations given at the S2Loop manual, I then tried S2Builder. I had the same error as before when I was using S2Loop. I somehow managed to bypass it using S2Polyline and here comes

Question 2: How can I use S2Builder to check for intersection?

I found no documentation regarding S2Builder, even though it is recommended for unsorted collection of edges. As a result, all my efforts are based on reading tests from the source code and trying to adapt the methods to my problem.

Exposing the "using" directive in the port header will cause it to be leaked into any codebase that uses this library. While it is possible to just fix up the headers and use the directive only in the source files, this change uses std::string everywhere.

as of 8a8746c7f4d4c53e8561e78e6ca380e8d4a0b9d3

compilation is failing on Arch because of openssl 1.1:

In file included from /home/akh/tmp/s2geometry/src/s2/s2predicates_internal.h:29:0,
                 from /home/akh/tmp/s2geometry/src/s2/s2edge_crossings.cc:28:
/home/akh/tmp/s2geometry/src/s2/util/math/exactfloat/exactfloat.h:516:10: error: field ‘bn_’ has incomplete type ‘BIGNUM {aka bignum_st}’
   BIGNUM bn_;
          ^~~
In file included from /usr/include/openssl/bn.h:32:0,
                 from /home/akh/tmp/s2geometry/src/s2/util/math/exactfloat/exactfloat.h:119,
                 from /home/akh/tmp/s2geometry/src/s2/s2predicates_internal.h:29,
                 from /home/akh/tmp/s2geometry/src/s2/s2edge_crossings.cc:28:
/usr/include/openssl/ossl_typ.h:80:16: note: forward declaration of ‘BIGNUM {aka struct bignum_st}’
 typedef struct bignum_st BIGNUM;
                ^~~~~~~~~
In file included from /home/akh/tmp/s2geometry/src/s2/s2predicates_internal.h:29:0,
                 from /home/akh/tmp/s2geometry/src/s2/s2edge_crossings.cc:28:
/home/akh/tmp/s2geometry/src/s2/util/math/exactfloat/exactfloat.h: In constructor ‘ExactFloat::ExactFloat()’:
/home/akh/tmp/s2geometry/src/s2/util/math/exactfloat/exactfloat.h:576:3: error: ‘BN_init’ was not declared in this scope
   BN_init(&bn_);
   ^~~~~~~
/home/akh/tmp/s2geometry/src/s2/util/math/exactfloat/exactfloat.h:576:3: note: suggested alternative: ‘BN_print’
   BN_init(&bn_);
   ^~~~~~~
   BN_print
make[2]: *** [CMakeFiles/s2.dir/build.make:879: CMakeFiles/s2.dir/src/s2/s2edge_crossings.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:105: CMakeFiles/s2.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

BN_init() was removed in OpenSSL 1.1.0; use BN_new() instead. source https://www.openssl.org/docs/man1.1.0/crypto/BN_new.html

Solution for Arch is: cmake -DOPENSSL_INCLUDE_DIR="/usr/include/openssl-1.0" -DOPENSSL_SSL_LIBRARY=/usr/lib/openssl-1.0/libssl.so ..

It will become an issue for every distribution with recent openssl.

I would love to package libs2 for Debian (in fact I have a local packaging repo at at https://salsa.debian.org/Mobian-team/puremaps-packaging/s2geometry-deb), but would love to package a nice reference release, instead of a random commit hash. The last formal release is 2 years ago, libs2 already announces itself as 0.10.0 to the world, so can we make a release please?

Would be appreciated, and thanks for s2geometry!

We've been working on integrating S2 into our project for a little while, and we've found a few issues with portability (especially compiling on Windows), and with some extraneous compile warnings (e.g. with gcc-7.2). This PR contains a mish-mash of small changes to address these concerns, hopefully in a way that can benefit everyone.

Hi, I am trying to cmake s2 using the following command, cmake -DWITH_GFLAGS=ON -WITH_GTEST=ON \ -DGTEST_ROOT=/usr/src/gtest \ -DOPENSSL_INCLUDE_DIR=/usr/include/openssl -Dabsl_DIR=/home/vidhi/Documents/BII/abseil/Source/abseil-cpp/build -DWITH_PYTHON=ON ..

I get this error on running the command, -- The following features have been enabled:

• GFLAGS, allows changing command line flags.
• GLOG, provides logging configurability.
• SHARED_LIBS, builds shared libraries instead of static.
• PYTHON, provides python interface to S2

CMake Error at /home/vidhi/Documents/BII/abseil/Source/abseil-cpp/build/abslConfig.cmake:32 (include): include could not find load file:

/home/vidhi/Documents/BII/abseil/Source/abseil-cpp/build/abslTargets.cmake

Call Stack (most recent call first): CMakeLists.txt:74 (find_package)

I have abseil build and installed following the instructions from here https://abseil.io/docs/cpp/quickstart-cmake. But I cannot find this abslTargets.cmake file anywhere. What did I miss?

• Require C++14 instead of C++11 (abseil-cpp requires it now)
• Require googletest >= 1.10 (for gmock)
  • Location is now specified with -DGOOGLETEST_ROOT
• New classes:
  • S2CellIterator
  • S2CellIteratorJoin
  • S2Coder
• New StableAngle function
• Delete many deprecated functions
• S2Point is now a different class from Vector3_d, not a typedeffor it

Fixes #259, #280, #295.

Improve s2region_term_indexer:

• Add ability to reuse term buffer
• Add option for optimize index size if query only points

Add access to coverer

Add access to S2Polygon::subregion_bound_

Add S2_SYSTEM_HEADERS cmake options to avoid s2 compile time warnings from s2 headers

Add S2_INSTALL option with keeping old behavior

Needs tests run! PR now mostly for discussion.

https://github.com/google/s2geometry/blob/master/src/s2/s2region_term_indexer.cc#L213

It looks like same possible for index terms, am I right?

Why do I need other terms (not true_max_level) if query contains only points?

Compiler warns about

/<<PKGBUILDDIR>>/src/s2/s2winding_operation.cc: In member function ‘bool s2builderutil::WindingLayer::MatchesRule(int) const’:
/<<PKGBUILDDIR>>/src/s2/s2winding_operation.cc:413:1: warning: control reaches end of non-void function [-Wreturn-type]
  413 | }
      | ^

bool WindingLayer::MatchesRule(int winding) const {
  switch (op_.rule_) {
    case WindingRule::POSITIVE:  return winding > 0;
    case WindingRule::NEGATIVE:  return winding < 0;
    case WindingRule::NON_ZERO:  return winding != 0;
    case WindingRule::ODD:       return (winding & 1) != 0;
  }
}

And indeed, if winding were a different value than POS, NEG, ODD or NON_ZERO, we would return void, so a catchall return is needed to make the compiler happy. Perhaps return False if we fall through?

Hi, s2geometry is in Debian, great. However, it fails to build on 2 architectures, and I have no clue what could be wrong, or how to fix it. (This is tag/v0.10.0, BTW)

The Debian issue is at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023961 pointing to the build protocol at: https://buildd.debian.org/status/fetch.php?pkg=s2geometry&arch=ppc64el&ver=0.10.0-2&stamp=1667081576&raw=0

The relevant bit seems to be:

/<<PKGBUILDDIR>>/src/s2/s2edge_crossings.cc: In instantiation of ‘bool S2::internal::GetStableCrossProd(const Vector3<T>&, const Vector3<T>&, Vector3<T>*) [with T = long double]’:
/<<PKGBUILDDIR>>/src/s2/s2edge_crossings.cc:127:54:   required from here
/<<PKGBUILDDIR>>/src/s2/s2edge_crossings.cc:115:31: error: ‘(6.15348059642740421245081038903225e-15l / 5.40431955284459475358983848622456e+16l)’ is not a constant expression
  115 |       (32 * kSqrt3 * DBL_ERR) /
      |       ~~~~~~~~~~~~~~~~~~~~~~~~^
  116 |       (kRobustCrossProdError.radians() / T_ERR - (1 + 2 * kSqrt3));
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/s2/s2edge_crossings.cc: In instantiation of ‘bool S2::GetIntersectionSimple(const Vector3<T>&, const Vector3<T>&, const Vector3<T>&, const Vector3<T>&, Vector3<T>*) [with T = long double]’:
/<<PKGBUILDDIR>>/src/s2/s2edge_crossings.cc:485:28:   required from here
/<<PKGBUILDDIR>>/src/s2/s2edge_crossings.cc:458:10: error: ‘(1.2e+1l / 7.20575940379279305358983848622456e+16l)’ is not a constant expression
  458 |       12 / (kIntersectionError.radians() / T_ERR - (2 + 2 * kSqrt3));
      |       ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [CMakeFiles/s2.dir/build.make:653: CMakeFiles/s2.dir/src/s2/s2edge_crossings.cc.o] Error 1