which include:

• ast fixes
• extern enum(i32) is now enum(i32)
• there is no need for ZIG_SYSTEM_LINKER_HACK on macOS

The last change depends on ziglang/zig#9229

Hope you don't mind the PR @floooh; I used your awesome project as a test ground for my linker work so thought I might as well contribute fixes for latest master. If you feel this should go in a different branch than main, lemme know and I'll redo a PR onto a different branch!

on macos 10.15.7 with zig 0.8.0. setting DbgStartRound in [0,2,8,12,14,15] all work fine but values in [16,32,64] cause an integer overflow panic as soon as i eat a powerup. The panic appears to be somewhere in gameUpdateSprites() but i can't tell exactly where because of this.

BTW I love this code! ❤️

I noticed your are building an object file manually for macOS. You don’t have to do that. Zig can compile Sokol metal no problem. Here is what my build file looks like for one of my projects that used Sokol: https://github.com/prime31/zig-upaya/blob/master/src/deps/sokol/build.zig

We circumvent the miscompilation by moving all @ Vector fn args as final args.

@floooh this is not a final solution, but rather a temp one which makes the project run correctly on arm64 macOS. Lemme know if you're OK with this fix, or whether you'd rather leave it as-is until a fix to upstream LLVM is provided.

Fixes #8

The Metal/MacOS build works great, but building for iOS or iOS simulator fails trying to find string.h--any advice on how to "correctly" hack in paths here would be great :)

kev@mini pacman.zig % zig version
0.9.0

kev@mini pacman.zig % xcode-select -p
/Applications/Xcode.app/Contents/Developer

kev@mini pacman.zig % zig build -Dtarget=aarch64-ios
error(compilation): clang failed with stderr: In file included from /Users/kev/src/pacman.zig/src/sokol/sokol.c:13:
/Users/kev/src/pacman.zig/src/sokol/sokol_app.h:1539:10: fatal error: 'string.h' file not found

/Users/kev/src/pacman.zig/src/sokol/sokol.c:1:1: error: unable to build C object: clang exited with code 1
pacman...The following command exited with error code 1:
/Users/kev/zig/zig build-exe /Users/kev/src/pacman.zig/src/pacman.zig -lc -cflags -ObjC -- /Users/kev/src/pacman.zig/src/sokol/sokol.c --cache-dir /Users/kev/src/pacman.zig/zig-cache --global-cache-dir /Users/kev/.cache/zig --name pacman -target aarch64-ios -mcpu generic --pkg-begin sokol /Users/kev/src/pacman.zig/src/sokol/sokol.zig --pkg-end -framework Cocoa -framework AudioToolbox -framework QuartzCore -framework MetalKit -framework Metal --enable-cache 
error: the following build command failed with exit code 1:
/Users/kev/src/pacman.zig/zig-cache/o/2a84dfe8266a0ba257d5a9640258a651/build /Users/kev/zig/zig /Users/kev/src/pacman.zig /Users/kev/src/pacman.zig/zig-cache /Users/kev/.cache/zig -Dtarget=aarch64-ios

kev@mini pacman.zig % zig build -Dtarget=aarch64-ios-simulator
error(compilation): clang failed with stderr: In file included from /Users/kev/src/pacman.zig/src/sokol/sokol.c:13:
/Users/kev/src/pacman.zig/src/sokol/sokol_app.h:1539:10: fatal error: 'string.h' file not found

/Users/kev/src/pacman.zig/src/sokol/sokol.c:1:1: error: unable to build C object: clang exited with code 1
pacman...The following command exited with error code 1:
/Users/kev/zig/zig build-exe /Users/kev/src/pacman.zig/src/pacman.zig -lc -cflags -ObjC -- /Users/kev/src/pacman.zig/src/sokol/sokol.c --cache-dir /Users/kev/src/pacman.zig/zig-cache --global-cache-dir /Users/kev/.cache/zig --name pacman -target aarch64-ios-simulator -mcpu generic --pkg-begin sokol /Users/kev/src/pacman.zig/src/sokol/sokol.zig --pkg-end -framework Cocoa -framework AudioToolbox -framework QuartzCore -framework MetalKit -framework Metal --enable-cache 
error: the following build command failed with exit code 1:
/Users/kev/src/pacman.zig/zig-cache/o/2a84dfe8266a0ba257d5a9640258a651/build /Users/kev/zig/zig /Users/kev/src/pacman.zig /Users/kev/src/pacman.zig/zig-cache /Users/kev/.cache/zig -Dtarget=aarch64-ios-simulator

Using source-built zig 0.8.0, I get:

frarees@MBP18 pacman.zig % zig build run                                                                              
error(compilation): clang failed with stderr: In file included from /Users/frarees/Documents/pacman.zig/src/sokol/sokol.c:13:
In file included from /Users/frarees/Documents/pacman.zig/src/sokol/sokol_app.h:996:
/Users/frarees/Documents/zig/build/lib/zig/include/stdint.h:20:43: fatal error: cannot open file '/Users/frarees/Documents/zig/build/lib/zig/libc/include/x86_64-macos-gnu/stdint.h': No such file or directory

/Users/frarees/Documents/pacman.zig/src/sokol/sokol.c:1:1: error: unable to build C object: clang exited with code 1
pacman...The following command exited with error code 1:
/Users/frarees/Documents/zig/build/bin/zig build-exe /Users/frarees/Documents/pacman.zig/src/pacman.zig -lc -cflags -ObjC -- /Users/frarees/Documents/pacman.zig/src/sokol/sokol.c --cache-dir /Users/frarees/Documents/pacman.zig/zig-cache --global-cache-dir /Users/frarees/.cache/zig --name pacman --pkg-begin sokol /Users/frarees/Documents/pacman.zig/src/sokol/sokol.zig --pkg-end -framework Cocoa -framework AudioToolbox -framework QuartzCore -framework MetalKit -framework Metal --enable-cache 
error: the following build command failed with exit code 1:
/Users/frarees/Documents/pacman.zig/zig-cache/o/15f2ba0993916df07b056287db8a15ea/build /Users/frarees/Documents/zig/build/bin/zig /Users/frarees/Documents/pacman.zig /Users/frarees/Documents/pacman.zig/zig-cache /Users/frarees/.cache/zig run

Seems like stdint.h is in /zig/build/lib/zig/libc/include/any-macos-any, and not in /zig/build/lib/zig/libc/include/x86_64-macos-gnu

Looks like this might be an issue with zig, but wanted to report it to you here since this project is where I could repro.

Hello! I'm new to Zig and have been pouring through this repo (which is really great btw! it's complicated enough to be interesting, but presented in a very reader-friendly way. thank you!)

I don't understand this piece of the code, and I'm hoping someone can explain it to me:

// all mutable state is in a single nested global
const State = struct {
    ...
    audio: struct {
        ...
        num_samples: u32 = 0,
        // sample_buffer is separate in UndefinedData
    } = .{},
    ...
};
var state: State = .{};

// keep the big undefined data out of the state struct, mixing initialized
// and uninitialized data bloats the executable size
const UndefinedData = struct {
    tile_ram:       [DisplayTilesY][DisplayTilesX]u8 = undefined,
    color_ram:      [DisplayTilesY][DisplayTilesX]u8 = undefined,
    vertices:       [MaxVertices]Vertex = undefined,
    tile_pixels:    [TileTextureHeight][TileTextureWidth]u8 = undefined,
    color_palette:  [256]u32 = undefined,
    sample_buffer:  [NumSamples]f32 = undefined,
};
var data: UndefinedData = .{};

Specifically, why is data separate from state? I tried making data a field in state to see what the difference would be:

const State = struct {
    ...
    data: struct {
        tile_ram: [DisplayTilesY][DisplayTilesX]u8 = undefined,
        color_ram: [DisplayTilesY][DisplayTilesX]u8 = undefined,
        vertices: [MaxVertices]Vertex = undefined,
        tile_pixels: [TileTextureHeight][TileTextureWidth]u8 = undefined,
        color_palette: [256]u32 = undefined,
        sample_buffer: [NumSamples]f32 = undefined,
    } = .{},
};
var state: State = .{};

$ zig version
0.10.0-dev.423+40c9ce2ca

# without any changes:
$ zig build -Drelease-small && du zig-out/bin/pacman.exe
122K    zig-out/bin/pacman.exe

# moving data to be state.data, and making the necessary changes to the rest of the code:
$ zig build -Drelease-small && du zig-out/bin/pacman.exe
296K    zig-out/bin/pacman.exe

keep the big undefined data out of the state struct, mixing initialized and uninitialized data bloats the executable size

This is clearly true, but why? Why does mixing initialized and uninitialized data bloat the exe from 120K to 300K?

I noticed this pattern is not present in pacman.c, so it's something about Zig in particular?

When cross-compiling to macOS from Linux say, it is required to point to a valid sysroot via the --sysroot flag:

zig build --sysroot /path/to/macos-sdk-sysroot/ -Dtarget=x86_64-macos
zig build --sysroot /path/to/macos-sdk-sysroot/ -Dtarget=aarch64-macos

• fix build script deprecations
• update sokol-bindings
• fixed function pointer syntax
• changed asRange() param to pointer
• change Vertex struct packed to extern
• fix a whitespace problem in the playfield map (unrelated to Zig 0.10.0)

building:ERROR: Closure compiler run failed:

building:ERROR: /var/folders/dz/g9ydwg8973z9nn5bvffcwf3h0000gn/T/emscripten_temp_musl3rsg/pacman.js.jso.js.jso.js.jso.js.jso.js:572:14: ERROR - [JSC_UNDEFINED_VARIABLE] variable allocateUTF8OnStack is undeclared
  572|    var cstr = allocateUTF8OnStack(pasted_str);
                     ^^^^^^^^^^^^^^^^^^^

This is because of this change in the Emscripten SDK:

https://groups.google.com/g/emscripten-discuss/c/GqyrjgRmcEw

Probably not the best possible way of implementing touch input support, but it does make the game playable on mobile.

The input scheme is adaptive with regard to the direction that pacman is going. For example, going left creates the following touch input grid:

 __________
|      |   |
|  U   |   |
|______| R |
|      |   |
|  D   |   |
|______|___|

Similarly every other direction produces a corresponding "adaptive" grid.

Tested it briefly with a mouse and seemed reasonable, testing on a real device might be warranted.

I simply cloned the project and ran zig build from the directory, I received no errors but when I tried to run the resulting executable, I received this error:

Assertion failed: ((HRESULT)(hr) >= 0) && _sapp.d3d11.swap_chain && _sapp.d3d11.device && _sapp.d3d11.device_context, file C:\prj\pacman.zig\src\sokol/sokol_app.h, line 5432

Zig version 0.8.0, Windows version 10.0.18362.30 x86-64