Hello! I'm trying to run your tester on linux and i always get this error that i can't fix even on the 42's Xubuntu VM

Is your tester supposed to be run only on mac? or is there some workaround to make it compile on linux?

As explained in this open issue, some tests are not using ft::swap, making the tests fail. I might be wrong, but I think there's no way of using std::swap with our own re-implementations.

I am getting a huge different in time between my implementation of vector::erase and the std one.

My implementation is already pretty lean:

iterator erase(iterator position)
{
    this->_alloc.destroy(&(*position));
    for (iterator it = position; it < (this->end() - 1); ++it)
        this->_alloc.construct(&(*(it)), *(it + 1));
    this->_alloc.destroy(this->_data + this->_size - 1);
    this->_size--;
    return position;
}

What seems suspicious to me is that I'm pratically getting the same times no matter how much I tweak my code. Also, I'm not getting such a huge difference in my own tests:

What seems especially suspicious is std time in your tester.

Hi!

First of all, a big thank you for this. It is by far the most complete tester regarding the types of checks done.

I find debugging a bit difficult, though. I would find very useful to have some sort of diff generation.

Thank you again anyway!

The compiler write this when i want to execute the test. And this message is the same for almost every vector test. The error seem so basic i cannot understand it. Here you can find my code, i cannot find where the issue come from.

https://github.com/kafim909/ft_containers/blob/master/vector.hpp

COMPILER :

In file included from ../vector_tests/begin().cpp:2: ../vector_tests/__service.ipp:18:15: error: no matching constructor for initialization of 'ft::vector' res2 = func2(my_vector); ^~~~~~~~~ ../vector_tests/begin().cpp:28:10: note: in instantiation of function template specialization 'run_vector_unit_test' requested here exit(run_vector_unit_test("begin()", begin_test, begin_test)); ^ 1 error generated. generated. tor_std_test, constructor_std_test)); ^ 1 error generated.

Thanks for helping me with this!

template std::vector swap_test( _vector vector ) { std::vector v; vector.assign( 1100 * _ratio, 11 ); _vector tmp( 500 * _ratio, 5 ), tmp2( 1000 * _ratio, 10 ), tmp3( 1500 * _ratio, 15 ), tmp4( 3000 * _ratio, 30 ); g_start2 = timer(); v.push_back( vector[2] ); v.push_back( vector.size() ); v.push_back( vector.capacity() ); long *adr1 = reinterpret_cast<long *>( &vector ); long *adr2 = reinterpret_cast<long *>( &tmp ); vector.swap( tmp ); if ( reinterpret_cast<long *>( &vector ) == adr1 && reinterpret_cast<long *>( &tmp ) == adr2 ) v.push_back( 1 ); v.push_back( vector[2] ); v.push_back( vector.size() ); v.push_back( vector.capacity() ); vector.swap( tmp3 ); v.push_back( vector[2] ); v.push_back( vector.size() ); v.push_back( vector.capacity() ); std::swap( vector, tmp2 ); --> ft::swap(...) v.push_back( vector[2] ); v.push_back( vector.size() ); v.push_back( vector.capacity() ); std::swap( vector, tmp4 ); --> ft::swap(...) g_end2 = timer(); v.push_back( vector[2] ); v.push_back( vector.size() ); v.push_back( vector.capacity() ); return v; }

I think sources/utilities_tests/iterator_traits.cpp file is doing wrong test!

It is doing test for std::vector's iterator types and ft::vector's iterator types is same.

but we need to test for ft::iterator_traits is doing well like this

bool iterator_traits_test() {
  std::vector<string> res;
  std::vector<string> res2;
  g_start1 = g_end1 = timer();

  res.push_back(typeid(std::iterator_traits<std::map<int, int>::iterator>::iterator_category).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::iterator>::value_type).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::iterator>::difference_type).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::iterator>::pointer).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::iterator>::reference).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::reverse_iterator>::iterator_category).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::reverse_iterator>::value_type).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::reverse_iterator>::difference_type).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::reverse_iterator>::pointer).name());
  res.push_back(typeid(std::iterator_traits<std::map<int, int>::reverse_iterator>::reference).name());

  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::iterator>::iterator_category).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::iterator>::value_type).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::iterator>::difference_type).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::iterator>::pointer).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::iterator>::reference).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::reverse_iterator>::iterator_category).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::reverse_iterator>::value_type).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::reverse_iterator>::difference_type).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::reverse_iterator>::pointer).name());
  res2.push_back(typeid(ft::iterator_traits<std::map<int, int>::reverse_iterator>::reference).name());

  return res == res2;
}