now there remains the other issue that your extension has been targeting parsing glslangValidator output not glslc and glslangValidator doesn't really seem to honor -I, -V nor make any assumptions about the shader's stage

Originally posted by @devshgraphicsprogramming in https://github.com/danielscherzer/GLSL/issues/58#issuecomment-638237281

This pull adds support for installing the extension in visual studio 2022 by splitting the project into 3 distinct projects(currently retains the old one for now, but it's not counted here); A Shared Items Project for the code that the 2 executables share(100% at the moment) A x86 Project for building the x86 vsix for vs2017-2019. A x64 Project for building the x64 vsix for vs2022(and up)

this pull also cleans up some of the code, removing whitespaces and formatting the code files to be more consistent.

feel free to try download on of the vsix build of the extension from my fork of the repo and try them! feedback is needed, and you can report issues with those builds in my fork's issues until it gets merged here.

I have an issue open for feedback too Here

Installed product versions

• Visual Studio: 2017 Community
• This extension: 0.10.111

Steps to recreate

update to lastest version

Current behavior

there is no more error tagging with squiggles, syntaxe highlight is still here and error list is still here too. I've uninstall and reinstall the add-on several time to see if it fix it or not, even with both Market place and CLI build but it seem to have nothing. tried in a new projet, also nothing.

Installed product versions

• Visual Studio 2017 Community
• This extension: 0.5.67

Description

I want to include my shader code as follows:

const GLchar* sFragmentShaderCode_ = #include "myShader.frag"

That works fine when I use a Raw string literal, which makes the first line of myShader.frag this: R"( Unfortunately, GLSL Language Integration doesn't show highlighting because of that line.

Steps to recreate

See above.

Current behavior

See above. Maybe it's not wrong, but how can I get highlighting when the first line of the shader code is R"( ?

Expected behavior

Highlight my shader code even if the first line is R"(

Installed product versions

• Visual Studio: 2017 Professional
• This extension: 0.2.36
• OS: Windows 10 Pro 64bit

Description

When assigning a vector to gl_Position, I always get the two errors:

'gl_Position': undeclared identifier
'assign': cannot convert from '4-component vector of highp float' to 'highp float'

The compiler seems to not know gl_Position, but curiously it also thinks that it's a float.

Steps to recreate

1. Use any vertex shader. E.g.:

#version 330 core

in vec3 v_position;

void main() 
{
    gl_Position = vec4(v_position, 1);
}

Current behavior

The errors from above are displayed.

Expected behavior

It should not display any errors.

Installed product versions

• Visual Studio: 2019 Professional 16.4.0 Preview 4.0
• This extension: 0.6.78

Description

Error message doing almost anything "Could not find the Microsoft.VisualC.CppClassifierProvider. Installing the C++ Visual Studio aspect should help."

Steps to recreate

1. Try and do most things (opening and viewing files)
2. Message box with error

I believe this is related to this issue but not sure if this is a bug on their end or an API change required on yours.

It would be nice if you could use environment variables in the file path of the external compiler.

The external compiler is often used to support the Vulkan and Google include extensions and the required glslangValidator is usually installed with the LunarG Vulkan SDK. Unfortunately, the version number is in the path, so the option in the GLSL extension has to be adjusted with every update.

Possible spellings could be $(EnvVar) or %EnvVar%:

$(VULKAN_SDK)\Bin\glslangValidator.exe

%VULKAN_SDK%\Bin\glslangValidator.exe

Installed product versions

• Visual Studio: [2017 Enterprise]
• This extension: [example 0.2.33]

Description

Adding .vsh or .fsh file extentions in the options leads to errors upon opening a project. (Adding other file extensions like .tcsh or .tesh works just fine). ActivityLog.xml says the file extension is registered twice. Unfortunately I was not able to find out where they were already registered. Clean install of VS2017 with C++ and Graphics tools, but no further plugins.

Steps to recreate

1. Install GLSL plugin
2. Add .vsh or .fsh to the file extensions
3. Open a project containing such files

Current behavior

Throws errors upon loading the project and does not highlight the files with the

Expected behavior

Open the project and correctly display the files (highlighting, completion, etc.)

I have created a fork of the repo Here and made a branch with the feature added as a preview if people wish to check it out first and see if it is a good fit for a pull request. it builds with no issues and can be installed(Marked as preview since the Vs2022 nugets are previews) and I am in the process of testing it so feedback is appreciated.

A few other changes I made are updating to .net4.8 and cleaning up some of the message/warnings from the complier output.

[edit 22/08/2021] I Have Since split the project into 3 to support still having vs2017 along side vs2019 in there own sub project, and vs2022 as it's own project, see the pull request Here

other than those changes the code is identical to the previous versions.

Installed product versions

• Visual Studio: 2017 Community
• This extension: 0.5.63

Description

how to set the color for texture2DRect or any redefined funcs? Like #define texLod textureLod

Installed product versions

• Visual Studio: [2017 Community]
• This extension: [0.2]

Description

This extensions says me there is an error when i write gl_VertexIndex but when i compile the shader there is no error.

Steps to recreate

1. Write gl_VertexIndex

Current behavior

It says me an error so i can't code properly.

Expected behavior

It should say me nothing..

Installed product versions

• Visual Studio: 2022 Community
• This extension: 0.11.160

Description

There is no highlighting for .frag and .vert files

Steps to recreate

1. Install VS2022 Community
2. Install the extension

Current behavior

No highlighting for .frag and .vert

Expected behavior

Highlighting for .frag and .vert files

I have a suggestion to make this extension be able to parse custom preprocessor definitions. Example: in my engine I implemented #stage definition, so I can write all pipeline shader stages in one file, but since it is "unknown preprocessor directive", I have tons of errors by extension's code analyzer.

How I would like to see it: add extension settings menu, which will contain list of custom preprocessor definitions, possibly their values or syntax, so I can write like this: #testmacro <> : <> and extension will understand, that #testmacro has its own syntax.

Installed product versions

• Visual Studio: 2022 Community
• This extension: 0.11.162

Description

It doesn't display the selected file's content and says:

An error occurred while initializing the frame's content System.ArgumentException: No EditorOptionDefinition export found for the given option name: EditingState/EditingStateEndingMargin Parameter name: optionId at Microsoft.VisualStudio.Text.EditorOptions.Implementation.EditorOptionsFactoryService.GetOptionDefinitionOrThrow(String optionId) at Microsoft.VisualStudio.Text.EditorOptions.Implementation.EditorOptions.GetOptionValue[T](String optionId) at Microsoft.VisualStudio.Text.EditorOptions.Implementation.EditorOptions.GetOptionValue[T](EditorOptionKey`1 key) at Microsoft.VisualStudio.Editor.Implementation.SimpleTextViewWindow.Init_SetSite(Object pUnkSite, Boolean isCodeWindow) at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.SetSite() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.InitializeView() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindowPane.CreateView() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindow.CreateAndAddView() at Microsoft.VisualStudio.Editor.Implementation.CompoundTextViewWindow.SetSite(Object pUnkSite) at Microsoft.VisualStudio.Shell.WindowPane.InternalSetSite(IServiceProvider p) at Microsoft.VisualStudio.Platform.WindowManagement.UIElementDocumentObject.SetSite(DocumentObjectSite site) at Microsoft.VisualStudio.Platform.WindowManagement.DocumentObjectSite.InitializeDocumentObject(Object punkView) at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.InitializeDocumentSite(Boolean creatingStubFrame, Boolean replacingStubView, Object punkView, Object punkData, IServiceProvider pServiceProvider, IVsUIHierarchy pUIHierarchy, UInt32 vsid) at Microsoft.VisualStudio.Platform.WindowManagement.WindowManagerService.CreateContentPane(FrameMoniker frameMoniker, Boolean isDocument, String lpstrMkDoc, UInt32 eCreateWindowFlags, Object punkView, Object punkData, IServiceProvider pServiceProvider, IVsUIHierarchy pUIHierarchy, UInt32 vsid, Guid rguidCmdUI, ViewGroup parent, IVsWindowFrame& ppWindowFrame)

the error code is 0x80070057

Steps to recreate

1. installed extension
2. ran visual studio
3. open source file (.cpp, .frag, .vert etc.)
4. error occurs

Current behavior

I can't see the file's contents

Expected behavior

display shader source with syntax highlighting and other source files without error

Installed product versions

• Visual Studio 2022 Community
• Extension version 0.11.160

Description

In game engines there's always complex shader system with includes. I've found two issues that make it hard to use this awesome extension:

• Extension compiles shader somewhere in the temp directory and sets working directory to temp directory so shader compiler doesn't see local includes
• Extension settings are global which make it hard to use extension with multiple solutions because the only way to specify additional include directories is to pass them via compiler arguments.

Consider the following example: we have a game project which contains a game engine submodule which has a plugin\extension system. Game engine, game itself and engine extensions can have their own shaders. Game engine, game and extensions have their own solutions. I use relative paths starting woth $(SolutionDir). I have to provide external include directories paths for each solution (e.g. path to some engine global includes) and for each folder which contains shader includes (e.g. we usually have ShaderShared.h include file which cotains uniforms). That's a lot of arguments for compiler.

I suggest to set working directory to the directory where shader is located. That should solve the first issue. Besides that I suggest to make extension settings per solution or at least to give a way to override settings on solution level.

Installed product versions

• Visual Studio: [2019 Enterprise]
• This extension: [0.11.160] (Downloaded from VS own marketplace.

Description

I simply get a red squiggly line below my push constant - which compiles and works perfectly well.

This feature would be so much helpful. For eg: Using a opening { should also add } , ( should add ) and so on and if there is a scope then there must be indentation

     void main() {
  ->    ....
     }

If you understand??