Hi, @rojer

Please, review this PR.

It implements support of Arduino Ethernet Shield (W5100) for fossa.

Note: avrsupport.h & avrsupport.cpp is just an amalgamation of avrdebug, avrlibc_compat and W5100_sockets files.

Hello. I have a serial device (CoolMaster 1000D). I want to write a web interface for it using fossa or mongoose on linux. Can you please tell how to add a tty to select/poll loop, which fossa uses.

Hi, @rojer

Please, review this PR.

It is support of CC3000 for fossa (only server - aka restful_server). This code is based on Adafruit/Texas instruments library (https://github.com/adafruit/Adafruit_CC3000_Library)

Library stores in fossa's rep unformatted (so, sometimes code style could be strange). Later I'll make an amalgamation and use clang-format against it.

Hello, Marko.

In order to split implementation I've created new branch and remove everything but message parser from it. I didn't include changes in src/modules.mk, so this PR can be safely merged with master (at least I think so): it just adds two files in /src folder. Changes in unit_test.c is not included as well.

Hi there!

First of all, I want to say: thanks for all the good work of this library. It's been an enormous help so far with the WebSockets, built-in JSON-RPC support and static file serving via HTTP. :+1:

Personally I'm a huge fan of setting a specific character set in the headers (UTF-8 in particular). This can be done by setting the charset after the MIME-type. So the Content-Type header will look like this:

Content-Type: text/html; charset=utf-8
Content-Type: application/javascript; charset=iso-8859-1
Content-Type: text/css; charset=utf-8
etc.

This is what I would like to do too in my program. However, currently I cannot find any support for setting the charset for plain text-based mime-types. Is it possible to incorporate this feature?

For example:

1. Save the charset ("utf-8") as a variable const char *charset in proto_data_http
2. add a variable int set_charset in static_builtin_mime_types[] for plain text-based types (please take a look here for my ideas)
3. if set_charset is positive, add ; charset=utf=8 to MIME-type (where charset is UTF-8, e.g.)

I would like to hear your feedback on this and of course I would be glad to help programming it.

Thanks in advance, Hefting

example multi-threaded server has Aborted (core dumped) compilation with gcc 4.9.2

cc multithreaded_restful_server.c ../../fossa.c -o multithreaded_restful_server -W -Wall -I../.. -pthread -DNS_ENABLE_THREADS 
../../fossa.c: In function ‘spawn_handling_thread’:
../../fossa.c:3134:10: warning: missing initializer for field ‘active_connections’ of ‘struct ns_mgr’ [-Wmissing-field-initializers]
   struct ns_mgr dummy = {};
          ^
In file included from ../../fossa.c:1:0:
../../fossa.h:603:25: note: ‘active_connections’ declared here
   struct ns_connection *active_connections;
                         ^

running and crash after try to connect with firefox 40.0.3 browser

oracle@ub-vm:~/Downloads/fossa-e4bd371337db61c17b809cb123b76dc061ceaf10/examples/multithreaded_restful_server$ ./multithreaded_restful_server 
Starting multi-threaded server on port 8000
epoll_ctl: Invalid argument
Aborted (core dumped)

Hi, @mmikulicic !

Please, review this PR. Since this is my first protocol added to fossa, I'm not sure that I'm right in details.

Please, take a look. (aka PTAL)

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• ns_printf ⇒ ns_send_websocket_handshake
• pthread_create ⇒ ns_start_thread

I get unresolved externals as of below when I try to compile fossa on windows with NS_ENABLE_SSL. They are related to PFS (links if NS_DISABLE_PFS defined). Lib used is oppenssl 1.0.2d. ssleay

Do I need to link to any more lib for this functionality and if so which?

Cheers /Ake

fossa.obj : error LNK2019: unresolved external symbol _BIO_new_file referenced in function _ns_use_cert 1>fossa.obj : error LNK2019: unresolved external symbol _BIO_free referenced in function _ns_use_cert 1>fossa.obj : error LNK2019: unresolved external symbol _BIO_new_mem_buf referenced in function _ns_use_cert 1>fossa.obj : error LNK2019: unresolved external symbol _DH_free referenced in function _ns_use_cert 1>fossa.obj : error LNK2019: unresolved external symbol _PEM_read_bio_DHparams referenced in function _ns_use_cert 1>.\Debug/vscphelper.dll : fatal error LNK1120: 5 unresolved externals

Configured with -b flag:

• -b /path/ - no rewriting, pass URI as is
• -b /path/=/otherpath/ - replace "/path/" prefix with "/otherpath/"
• -b /path= - strip "/path" prefix from URI

Also fix -r option handling.

To test,

Unix build:

make -C examples/restful_server
 examples/restful_server/restful_server -d /etc

Windows build:

wine make -C examples/restful_server restful_server.exe
wine examples/restful_server/restful_server.exe -d /etc/

I can't use the socket server when building my application in Release mode. The server is up but it can't get any connection nor messages. I compiled my program with gcc-8.4.0 for x86_64 and with gcc-8.3.0 for arm_32 and both compilations resulted in the same error. Hence in Release mode, I can't debug the code and using printf in each lib function didn't result in any significant help either. I guess the compiler is optimizing/removing some part of the code that it definitely shouldn't.

Latest code don't compile on windows with vs 2015. Complain about random() not available in the

if NS_DISABLE_WS_RANDOM_MASK

return 0xefbeadde; /* generated with a random number generator, I swear */

else

if (sizeof(long) >= 4) { return (uint32_t) random(); } else if (sizeof(long) == 2) { return (uint32_t) random() << 16 | (uint32_t) random(); }

endif

}

git clone and make:(Ubuntu 10.04) (https://github.com/cesanta/fossa/issues/305)

~/src/1/fossa$ git status On branch master Untracked files: (use "git add ..." to include in what will be committed)

   examples/captive_dns_server/captive_dns_server
   examples/coap_client/coap_client
   examples/coap_server/coap_server
   examples/http_client/http_client
   examples/json_rpc_server/json_rpc_server
   examples/mqtt_broker/mqtt_broker
   examples/mqtt_client/mqtt_client
   examples/netcat/nc
   examples/publish_subscribe/publish_subscribe
   test/unit_test

nothing added to commit but untracked files present (use "git add" to track)

git clone

:~/src/1/fossa$ make make[1]: Entering directory `/home/ppa/src/1/fossa/test' unit_test.c: In function 'test_mbuf': unit_test.c:98: warning: integer constant is too large for 'long' type unit_test.c:98: warning: large integer implicitly truncated to unsigned type unit_test.c:98: warning: integer constant is too large for 'long' type unit_test.c:98: warning: large integer implicitly truncated to unsigned type unit_test.c:123: warning: integer constant is too large for 'long' type unit_test.c:123: warning: large integer implicitly truncated to unsigned type unit_test.c:123: warning: integer constant is too large for 'long' type unit_test.c:123: warning: large integer implicitly truncated to unsigned type [0.000] test_mbuf [0.000] test_parse_address [0.000] test_check_ip_acl [0.000] test_connect_opts [0.000] test_connect_opts_error_string

....

cc device_side.c ../../fossa.c -I../.. -o device_side -W -Wall -DNS_ENABLE_THREADS -pthread device_side.c: In function 'generate_mjpg_data_thread_func': device_side.c:133: warning: implicit declaration of function 'WIFSIGNALED' /tmp/ccaLKefW.o: In function generate_mjpg_data_thread_func': device_side.c:(.text+0x49b): undefined reference toWIFSIGNALED' collect2: ld returned 1 exit status make[2]: *** [device_side] Error 1 make[2]: Leaving directory /home/ppa/src/1/fossa/examples/raspberry_pi_mjpeg_led' make[1]: *** [raspberry_pi_mjpeg_led/] Error 2 make[1]: Leaving directory/home/ppa/src/1/fossa/examples' make: *** [examples] Error 2

FYI @danielinux & @maximevince

The primary fossa use case is embedded. However, when modules's functionality is getting extended, we unintentionally leak functions into the core, making it fatter. We need to make sure that our development does not increase core size, unless intended.

• [ ] Disable all modules by default. Let user explicitly enable those which are needed
• [ ] Make minimal fossa build on a small board (e.g. Arduino UNO)
• [ ] Setup CI with embedded fossa build, making sure we're not bloating the code
• [ ] No big objects on stack