Hello, i've successfully compiled all the examples (amazing work btw), and run some of them on a Raspberry PI 3. The example 20 is very very slow on the raspberry pi 3, but it seems that is actually using the proper OpenGLES renderer, not a simulated one.

Do you have any clue?

Thanks

Edit: 2019-08-01 - I reopened this pull request as one commit.

First of all, I would like to thank you for producing a light-weight but great renderer. I am working in the image and video graphics field, and decided to integrate the BGFX renderer into my engine.

Additionally, I think that it would be very nice if the BGFX could be executed with the Vulkan backend everywhere (#274), so I decided to do additional implementation of the vulkan backend, and this pull request is the draft of the implementation.

Major changes

The macOS-vulkan support setting (thanks to MoltenVK!)

• KHR_SURFACE_EXTENSION_NAME and VK_IMPORT_INSTANCE_PLATFORM for BX_PLATFORM_OSX are defined.
• libvulkan.dylib would be loaded for BX_PLATFORM_OSX.
• The surface creation code is implemented by referring to renderer_mtl.mm.

Surface format

• Figure out whether VK_FORMAT_R8G8B8A8_UNORM or VK_FORMAT_R8G8B8A8_UNORM is supported, and use it for surface texture format.
• Currently depth-stencil format is fixed to VK_FORMAT_D24_UNORM_S8_UINT.

The order of steps in the initialization is arranged

• The render pass creation step is moved after the swapchain image view creation.

The number of swapchain image

• While the array size of the swapchain image is fixed to 4, the number of swapchain image provided by the vulkan device can be less than that. (e.g. android device)
• Thus, the swapchain image views, framebuffers, semaphores, and command buffers are created with the suggested number of the swapchain image for the surface.

Descriptor set binding index

• I've encountered the validation error when I tried to use the shader with texture, and the error message said that the descriptor set binding index should be different from the others.
• So I've decided to modify the SPIR-V shader compiler in order to automatically set descriptor binding index.

// shaderc_spirv.cpp, line 639
shader->setEntryPoint("main");
shader->setAutoMapBindings(true);
uint32_t bindingOffset = (stage == EShLanguage::EShLangFragment ? 48 : 0);
shader->setShiftBinding(glslang::EResUbo, bindingOffset);
shader->setShiftBinding(glslang::EResTexture, bindingOffset + 16);
shader->setShiftBinding(glslang::EResSampler, bindingOffset + 32);

• By using this code, the binding indices the UBO, texture, and sampler for a vertex shader would be started from 0, 16, 32 respectively, and those for a fragement shader would be started from 48, 64, 80.

Descriptor set layout and pipeline layout

• Because I could not find the way to convert a separated image into the combined image sampler in the vulkan, I have to bind both of image and its sampler with VkDescriptorImageInfo.
• And the other uniforms seem to be a structure and it can be feeded with VkDescriptorBufferInfo
• And all of those binding infomation should be included in the one descriptor set layout.
• So the descriptor set bindings for each shader are set in its shader creation process, and the descriptor set layout is created and cached during the program creation.
• Then the pipeline layout is created for the cached descriptor set layout. I think that it also be cached, but don't tried yet.

Uniform size for ubo structure

• While the uniform array (e.g. u_model[32]) used in the GLSL shader can be optimized during compilation, the SPIR-V compilation does not reduce its size because it combined with the other uniforms as a structure form.
• So I changed the calculation method of the size of UBO as below:

// shaderc_spirv.cpp, line 594
if (un.type != UniformType::Sampler)
	size = bx::max(size, (uint16_t)(un.regIndex + un.regCount*16));

Sampler stage index

• Some code is written for getting the samplers stage index.
• Then it is stored as a location of the uniform.
• Now a sampler uniform uses all storage for loc, regIndex, regCount in order to store stageIndex, imageBindingIndex, samplerBindingIndex, respectively.

Texture and buffer

• I referred to D3D12 renderer implementation.
• The memory of texture images and vertex buffers is allocated for device access by default.
• Thus the staging buffers are used in order to copy its contents from host memory into device memory.

Current status

• I've tested on windows 10, macOS.
• I've succeeded to execute example 01, 02, 03, 04, 06, 07, 10, 11, 12, 13, and 14, even though some examples does not correctly.
• Note that shaders in examples should be rebuilt by using the modified SPIR-V shader compiler.

Next work

• Debug text and image (the most important, I think!)
• Cube map support
• Framebuffer support
• Instancing

I'd like to listen your advise about how to implement the things above, especially debug text. Please leave the comment!

Thank you for reading!

On certain platforms where the building/running the examples requires some manual step ( like iOS/OSX or android). It would be great to have a mega example that includes all current examples and lets the user select which example to start. This way with only one setup/build/install step a user could check every example.

This app also could be uploaded to the googleplay/iOS store, so interested developers can check it.

As a proof of concept I have implemented it here: https://gist.github.com/attilaz/410a4543020da4de11c62c00ec098c77

It worked well. Only minor modification were needed in the current examples( adding #ifndef SKIP_ENTRY_IMPLEMENT_MAIN ) around ENTRY_IMPLEMENT_MAIN.

The only limitation I have found with this implementation is name collision. With certain examples I get errors like this: 's_cubeVertices' : redefinition; different subscripts.

I think this could be solved: A. putting every example code into a separate namespace. ( needs modification for examples ) B. Instead of including cpp files the project file could include every examples' cpp. (needs a genie script to generate this)

Adding a "back"/"quit" button to examples to step back to the selector screen also could be handy.

Hi. I've created a simple example in https://github.com/TamToucan/bgfx/blob/master/examples/XX-map/map.cpp

which reproduces the problem I'm having. NOTE: I am running on Windows using OPENGL (the example is hard-coded to OpenGL and the shaders have only been compiled for glsl)

The rendering does the following

1. map view - Render part of a large texture to the FBO.
2. sprite view - Renders 3 sprites to the FBO using a vertex buffer containing the 4 corners of each sprite and an index buffer to create the 6 vertices for the 2 triangles for each sprite.
3. screen view - The texture from the FBO is rendered to the screen

Everything works fine, but in the example I only perform step(2) if Space is pressed, when space isn't pressed then nothing is done using the sprite view i.e. the transient vertex buffer containing the sprite data isn't created, the sprite shader program isn't used etc.

The problem is when Space is then released I get a crash inside the ATI graphics driver DLL. I've been trying to step through the internals of BGFX, but I'm getting no where. Running with CodeXL gives

"The thread tried to read or write data that is misaligned on hardware that does not provide alignment. For example, 16-bit values must be aligned on 2-byte boundaries; 32-bit values on 4-byte boundaries, and so on."

Regards, Tam.

Hi, I have one user who consistently crashes in bgfx::init(). Do you think this might be a bug in bgfx? Of course, it's also possible the user just has bad drivers. If you think so, feel free to close. He can run other games though.

I managed to extract this info from a .dmp. I didn't include the purported argument values because they seemed to be garbage. (s_ctx NULL right after a NULL check.) The call stack looks plausible, though.

Operating system: Windows NT
                  6.1.7601 Service Pack 1
CPU: x86
     GenuineIntel family 6 model 15 stepping 11
     2 CPUs

Crash reason:  EXCEPTION_ACCESS_VIOLATION_READ
Crash address: 0x24

Thread 1:
ntdll!ZwWaitForSingleObject+0x15
KERNELBASE!WaitForSingleObjectEx+0x98
kernel32!WaitForSingleObjectExImplementation+0x75
kernel32!WaitForSingleObject+0x12
bgfx::Context::frame+0x26 [bgfx\src\bgfx.cpp @ 1412]
bgfx::Context::init+0x175 [bgfx\src\bgfx.cpp @ 1209]
bgfx::init+0xe2 [bgfx\src\bgfx.cpp @ 2384]
(...snip...)

Thread 2 (Crashed):
d3d11!CContext::ID3D11DeviceContext1_Begin_<1>+0x8
bgfx::d3d11::TimerQueryD3D11::begin+0xdf [bgfx\src\renderer_d3d11.cpp @ 4575]
bgfx::d3d11::RendererContextD3D11::submit+0x93 [bgfx\src\renderer_d3d11.cpp @ 4702]
bgfx::Context::renderFrame+0xb6 [bgfx\src\bgfx.cpp @ 1502]
bgfx::renderFrame+0x32 [bgfx\src\bgfx.cpp @ 992]
bgfx::Context::renderThread+0x5 [bgfx\src\bgfx_p.h @ 2102]
bx::Thread::threadFunc+0x25 [bx\include\bx\thread.h @ 201]
kernel32!BaseThreadInitThunk+0xe
ntdll!__RtlUserThreadStart+0x70
ntdll!_RtlUserThreadStart+0x1b

Hi,

I think I discovered some issue with the autorelease pool in the OSX Metal backend. If I call bgfx::RenderFrame() before calling bgfx::Init() (both on the same thread) to init single threaded mode, bgfx crashes inside renderer_metal.mm in the flip() function on line 1135 where the autorelease pool is released.

The console tells this: "Invalid or prematurely-freed autorelease pool".

If bgfx runs in multi threaded mode everything seems fine.

Just integrating https://github.com/Celtoys/Remotery into my code, and I noticed I would have to add the macros into the bgfx code myself if I was running multi-threaded.

I was wondering if you could provide a simple profiling hook into the render function if it's running multi-threaded?

Hi, most of the other samples work, but the hello world sample doesn't display anything other than a grey background. The metaballs example is also missing the debug text that's in the screenshot. I built the project from the command line using GNU Make, and that appeared to work without any errors. I then compiled using Visual Studio 2013. Initially it failed to compile complaining about Direct3D9 stuff, but I downloaded the 2010 DirectX SDK and set the environment variable for that, and after that it compiled.

Here's the debug output. I don't see any obvious errors occurring...

'example-00-helloworldDebug.exe' (Win32): Loaded 'D:\Dropbox\Work\Game Dev\Libs\bgfx\.build\win64_vs2013\bin\example-00-helloworldDebug.exe'. Symbols loaded.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\ntdll.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\kernel32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\KernelBase.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\gdi32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\user32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\imm32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\msctf.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\msvcrt.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\XInput9_1_0.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\uxtheme.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\combase.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\rpcrt4.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Program Files\Common Files\microsoft shared\ink\tiptsf.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\oleaut32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\dwmapi.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\ole32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\sechost.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\kernel.appcore.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\cryptbase.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\bcryptprimitives.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\oleacc.dll'. Cannot find or open the PDB file.
..\..\..\src\bgfx.cpp(1977): BGFX Init...
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\XInput1_4.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\cfgmgr32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\devobj.dll'. Cannot find or open the PDB file.
..\..\..\src\bgfx.cpp(959): BGFX Creating rendering thread.
d:\dropbox\work\game dev\libs\bgfx\src\bgfx_p.h(1913): BGFX render thread start
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\d3d11.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\dxgi.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\d3d9.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\version.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\clbcatq.dll'. Cannot find or open the PDB file.
..\..\..\src\renderer_d3d11.cpp(521): BGFX Adapter #0
..\..\..\src\renderer_d3d11.cpp(525): BGFX  Description: NVIDIA GeForce GTX 670
..\..\..\src\renderer_d3d11.cpp(531): BGFX  VendorId: 0x000010de, DeviceId: 0x00001189, SubSysId: 0x35421458, Revision: 0x000000a1
..\..\..\src\renderer_d3d11.cpp(536): BGFX  Memory: 2082140160 (video), 0 (system), 2147807232 (shared)
..\..\..\src\renderer_d3d11.cpp(521): BGFX Adapter #1
..\..\..\src\renderer_d3d11.cpp(525): BGFX  Description: Microsoft Basic Render Driver
..\..\..\src\renderer_d3d11.cpp(531): BGFX  VendorId: 0x00001414, DeviceId: 0x0000008c, SubSysId: 0x00000000, Revision: 0x00000000
..\..\..\src\renderer_d3d11.cpp(536): BGFX  Memory: 0 (video), 0 (system), 268435456 (shared)
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\dxgidebug.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\nvwgf2umx.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\psapi.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\advapi32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\bcrypt.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\shell32.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\shlwapi.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\SHCore.dll'. Cannot find or open the PDB file.
The thread 0x680c has exited with code 0 (0x0).
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\nvspcap64.dll'. Cannot find or open the PDB file.
'example-00-helloworldDebug.exe' (Win32): Loaded 'C:\Windows\System32\d3d11_2sdklayers.dll'. Cannot find or open the PDB file.
..\..\..\src\renderer_d3d11.cpp(601): BGFX D3D device 11.3, hr 0
..\..\..\src\bgfx.cpp(262): BGFX Graphics debugger is present.
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE1FFB0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
D3D11 INFO: Destroy ID3D11Buffer: Name="unnamed", Addr=0x000000510BE1FFB0 [ STATE_CREATION INFO #2097230: DESTROY_BUFFER]
D3D11 INFO: Create ID3D11RenderTargetView: Name="unnamed", Addr=0x000000510BE20030, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097243: CREATE_RENDERTARGETVIEW]
D3D11 INFO: Create ID3D11Texture2D: Name="unnamed", Addr=0x000000510BE1E6E0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097234: CREATE_TEXTURE2D]
D3D11 INFO: Create ID3D11DepthStencilView: Name="unnamed", Addr=0x000000510BE1E250, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097246: CREATE_DEPTHSTENCILVIEW]
..\..\..\src\bgfx.cpp(895): BGFX Supported capabilities (Direct3D 11):
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_TEXTURE_COMPARE_LEQUAL
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_TEXTURE_COMPARE_ALL
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_TEXTURE_3D
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_VERTEX_ATTRIB_HALF
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_INSTANCING
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_RENDERER_MULTITHREADED
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_FRAGMENT_DEPTH
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_BLEND_INDEPENDENT
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_COMPUTE
..\..\..\src\bgfx.cpp(900): BGFX    BGFX_CAPS_SWAP_CHAIN
..\..\..\src\bgfx.cpp(904): BGFX Supported texture formats:
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC1
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC2
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC3
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC4
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC5
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC6H
..\..\..\src\bgfx.cpp(914): BGFX    [x] BC7
..\..\..\src\bgfx.cpp(914): BGFX    [*] ETC1
..\..\..\src\bgfx.cpp(914): BGFX    [*] ETC2
..\..\..\src\bgfx.cpp(914): BGFX    [*] ETC2A
..\..\..\src\bgfx.cpp(914): BGFX    [*] ETC2A1
..\..\..\src\bgfx.cpp(914): BGFX    [ ] PTC12
..\..\..\src\bgfx.cpp(914): BGFX    [*] PTC14
..\..\..\src\bgfx.cpp(914): BGFX    [ ] PTC12A
..\..\..\src\bgfx.cpp(914): BGFX    [*] PTC14A
..\..\..\src\bgfx.cpp(914): BGFX    [ ] PTC22
..\..\..\src\bgfx.cpp(914): BGFX    [ ] PTC24
..\..\..\src\bgfx.cpp(914): BGFX    [x] R1
..\..\..\src\bgfx.cpp(914): BGFX    [x] R8
..\..\..\src\bgfx.cpp(914): BGFX    [x] R16
..\..\..\src\bgfx.cpp(914): BGFX    [x] R16F
..\..\..\src\bgfx.cpp(914): BGFX    [x] R32
..\..\..\src\bgfx.cpp(914): BGFX    [x] R32F
..\..\..\src\bgfx.cpp(914): BGFX    [x] RG8
..\..\..\src\bgfx.cpp(914): BGFX    [x] RG16
D3D11 INFO: Create ID3D11Texture2D: Name="unnamed", Addr=0x000000510BE45C10, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097234: CREATE_TEXTURE2D]
..\..\..\src\bgfx.cpp(914): BGFX    [x] RG16F
..\..\..\src\bgfx.cpp(914): BGFX    [x] RG32
..\..\..\src\bgfx.cpp(914): BGFX    [x] RG32F
..\..\..\src\bgfx.cpp(914): BGFX    [x] BGRA8
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGBA16
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGBA16F
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGBA32
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGBA32F
..\..\..\src\bgfx.cpp(914): BGFX    [x] R5G6B5
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGBA4
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGB5A1
..\..\..\src\bgfx.cpp(914): BGFX    [x] RGB10A2
..\..\..\src\bgfx.cpp(914): BGFX    [x] R11G11B10F
..\..\..\src\bgfx.cpp(914): BGFX    [x] D16
..\..\..\src\bgfx.cpp(914): BGFX    [x] D24
..\..\..\src\bgfx.cpp(914): BGFX    [x] D24S8
..\..\..\src\bgfx.cpp(914): BGFX    [x] D32
..\..\..\src\bgfx.cpp(914): BGFX    [x] D16F
..\..\..\src\bgfx.cpp(914): BGFX    [x] D24F
..\..\..\src\bgfx.cpp(914): BGFX    [x] D32F
..\..\..\src\bgfx.cpp(914): BGFX    [x] D0S8
..\..\..\src\bgfx.cpp(919): BGFX Max FB attachments: 8
d:\dropbox\work\game dev\libs\bgfx\src\bgfx_p.h(2930): BGFX Creating uniform (handle   0) bgfx_clear_color
D3D11 INFO: Create ID3D11Sampler: Name="unnamed", Addr=0x000000510BE07220, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097267: CREATE_SAMPLER]
..\..\..\src\renderer_d3d11.cpp(2615): BGFX Texture   0: R8 (requested: R8), 2048x24.
D3D11 INFO: Create ID3D11Texture2D: Name="unnamed", Addr=0x000000510BE0B710, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097234: CREATE_TEXTURE2D]
D3D11 INFO: Create ID3D11ShaderResourceView: Name="unnamed", Addr=0x000000510BE0ED20, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097240: CREATE_SHADERRESOURCEVIEW]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Vertex Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     predefined: u_modelViewProj (mat4), num  0, r.index 2528, r.count  4
D3D11 INFO: Create ID3D11VertexShader: Name="unnamed", Addr=0x000000510BE6F560, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097249: CREATE_VERTEXSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE729F0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 0
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BE35B60, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
vertexdecl acb2facc (92a03374), stride 28
    attr 0 - Attrib::Position, num 3, type 3, norm 0, asint 0, offset 0
    attr 4 - Attrib::Color0, num 4, type 0, norm 1, asint 0, offset 12
    attr 5 - Attrib::Color1, num 4, type 0, norm 1, asint 0, offset 16
    attr 8 - Attrib::TexCoord0, num 2, type 3, norm 0, asint 0, offset 20
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE44760, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE39B10, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Vertex Shader consts 0
D3D11 INFO: Create ID3D11VertexShader: Name="unnamed", Addr=0x000000510BE410D0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097249: CREATE_VERTEXSHADER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BEDFA90, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510E5C2480, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BE4AB60, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE4AF30, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BE4BF10, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE48F50, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BEA5B10, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BEA08C0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BEA1A00, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BEDE000, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BE798C0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BE7A420, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BE7AC10, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BED88D0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\renderer_d3d11.cpp(2424): BGFX Fragment Shader consts 1
..\..\..\src\renderer_d3d11.cpp(2485): BGFX     user: bgfx_clear_color (vec2), num  8, r.index   0, r.count  8
D3D11 INFO: Create ID3D11PixelShader: Name="unnamed", Addr=0x000000510BED1B90, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097261: CREATE_PIXELSHADER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BED2790, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
vertexdecl 623c7ad8 (54fc4dc5), stride 12
    attr 0 - Attrib::Position, num 3, type 3, norm 0, asint 0, offset 0
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BEBD370, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510E6B4F70, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BED7640, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
..\..\..\src\bgfx.cpp(2013): BGFX Init complete.
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BED8280, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
D3D11 INFO: Create ID3D11Buffer: Name="unnamed", Addr=0x000000510BEA4EB0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097228: CREATE_BUFFER]
D3D11 INFO: Destroy ID3D11RenderTargetView: Name="unnamed", Addr=0x000000510BE20030 [ STATE_CREATION INFO #2097245: DESTROY_RENDERTARGETVIEW]
D3D11 INFO: Destroy ID3D11Texture2D: Name="unnamed", Addr=0x000000510BE170E0 [ STATE_CREATION INFO #2097236: DESTROY_TEXTURE2D]
D3D11 INFO: Create ID3D11Texture2D: Name="unnamed", Addr=0x000000510BE170E0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097234: CREATE_TEXTURE2D]
D3D11 INFO: Create ID3D11RenderTargetView: Name="unnamed", Addr=0x000000510BEB2710, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097243: CREATE_RENDERTARGETVIEW]
D3D11 INFO: Create ID3D11Texture2D: Name="unnamed", Addr=0x000000510BEB0FA0, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097234: CREATE_TEXTURE2D]
D3D11 INFO: Create ID3D11DepthStencilView: Name="unnamed", Addr=0x000000510BEB1550, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097246: CREATE_DEPTHSTENCILVIEW]
D3D11 INFO: Create ID3D11BlendState: Name="unnamed", Addr=0x000000510BEC2760, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097270: CREATE_BLENDSTATE]
D3D11 INFO: Create ID3D11DepthStencilState: Name="unnamed", Addr=0x000000510BEB2930, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097273: CREATE_DEPTHSTENCILSTATE]
D3D11 INFO: Create ID3D11RasterizerState: Name="unnamed", Addr=0x000000510BEB2D80, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097276: CREATE_RASTERIZERSTATE]
D3D11 INFO: Create ID3D11DepthStencilState: Name="unnamed", Addr=0x000000510BEB6160, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097273: CREATE_DEPTHSTENCILSTATE]
D3D11 INFO: Create ID3D11InputLayout: Name="unnamed", Addr=0x000000510BE4E330, ExtRef=1, IntRef=0 [ STATE_CREATION INFO #2097264: CREATE_INPUTLAYOUT]
D3D11 INFO: Destroy ID3D11DepthStencilView: Name="unnamed", Addr=0x000000510BE1E250 [ STATE_CREATION INFO #2097248: DESTROY_DEPTHSTENCILVIEW]
D3D11 INFO: Destroy ID3D11Texture2D: Name="unnamed", Addr=0x000000510BE1E6E0 [ STATE_CREATION INFO #2097236: DESTROY_TEXTURE2D]

This addresses a subtle bug when the sequence of blit operations contains 2 consecutive copies like so: A -> B, C -> A (src of a blit becomes dst of next blit) A -> B, B -> C (dst of a blit becomes src of next blit) A -> B, B -> A (dst and src of blit are swapped in the next one)

The last case is necessary to implement blitting part of an image (A) into itself (using B as intermediate). The code as currently written triggers a validation error because B is transitioned back to its original layout (instead of staying src layout) in the second blit.

Hi there, I'm testing GLFW's new transparent windows feature with bgfx and there's something weird going on with the alpha:

Notice that nothing is 100% opaque for some reason. I'm testing this on Arch Linux using glfw's current master and this patch.

Any ideas?

A simple conversion and stripping down of example 01 to use C99 and SDL2 (and removing the actual rendering parts, as they have not yet been properly converted) fails to run, and causes glClear() to throw a 0x506 error in the rendering thread.

2015-03-19 00:36:00.624 Test[13709:421801] ../../../src/bgfx.cpp(2025): BGFX Init complete.
2015-03-19 00:36:00.625 Test[13709:421887] vertexdecl ccbfe30d (b9cddbd5), stride 16
2015-03-19 00:36:00.625 Test[13709:421887]  attr 0 - Attrib::Position, num 3, type 3, norm 0, asint 0, offset 0
2015-03-19 00:36:00.625 Test[13709:421887]  attr 4 - Attrib::Color0, num 4, type 0, norm 1, asint 0, offset 12
2015-03-19 00:36:00.625 Test[13709:421887] ../../../src/renderer_gl.cpp(2678): BGFX WARN Unknown enum? 506
2015-03-19 00:36:00.626 Test[13709:421887] ../../../src/renderer_gl.cpp(2410): BGFX CHECK glClear(flags); GL error 0x506: <GLenum?>
2015-03-19 00:36:00.626 Test[13709:421887] ../../../src/renderer_gl.cpp(2678): BGFX WARN Unknown enum? 506

Test code here: http://wakaba.c3.cx/stuff/Test.zip

Contains a very primitive Makefile, just run "make" then "./Test".

Describe the bug This shader

#include <bgfx_shader.sh>
 
void main()
{
	gl_FragColor = vec4(gl_PrimitiveID,0,0,1);
}

compiled to the metal backend with the following flags results in Abort trap: 6: shaderc -f shader.fsh -o fragment.bin -i bgfx/src --type fragment --platform osx --varyingdef varying.def.sc --profile metal --debug

To Reproduce Steps to reproduce the behavior:

1. Compile the shader above using the command line
2. Observe the crash
3. Retry for the DirectX or Vulkan backends - the compile will succeed

Expected behavior shaderc should print an error message containing the compile error, because this shader uses a feature (gl_PrimitiveID) that is not supported on the default shaderc metal version of 1.0.

Additional context shaderc does not crash if the --preprocess flag is passed.

When compiling shaderc in debug mode and attaching a debugger, the crash occurs when executing shaderc_metal.cpp:629

std::string source = msl.compile();

The error occurs inside spirv-cross (spirv_cross_error_handling.hpp:57):

#ifdef SPIRV_CROSS_EXCEPTIONS_TO_ASSERTIONS
#if !defined(_MSC_VER) || defined(__clang__)
[[noreturn]]
#elif defined(_MSC_VER)
__declspec(noreturn)
#endif
inline void
report_and_abort(const std::string &msg)
{
#ifdef NDEBUG
	(void)msg;
#else
	fprintf(stderr, "There was a compiler error: %s\n", msg.c_str());
#endif
	fflush(stderr);
	abort();        // error here
}

It prints There was a compiler error: PrimitiveId on macOS requires MSL 2.2. but only if shaderc is compiled in debug mode. In release, you only get Abort trap: 6.

One possible fix is to disable the SPIRV_CROSS_EXCEPTIONS_TO_ASSERTIONS define, which means that even in release if shaderc crashes in spirv-cross, the error message will print: libc++abi: terminating with uncaught exception of type spirv_cross::CompilerError: PrimitiveId on macOS requires MSL 2.2.

Describe the bug I have a simple fs shader like this:

$input v_texcoord0
#include <bgfx_shader.sh>
SAMPLER2D(s_tex, 0);

void main()
{
    vec4 color = texture2D(s_tex, v_texcoord0);
	gl_FragColor = color;
}

After shader successful compile, and do:

bgfx::ShaderHandle handle = bgfx::createShader(...);

bgfx::UniformHandle_t u[16];
int n = bgfx::getShaderUniforms(handle, u, 16); //it will reture 2, and I expect it return 

for (int ii = 0; ii < n; ++ii)
{
  bgfx::UniformInfo info;
  bgfx::getUniformInfo(u[ii], &info);
  print("name:%s, type:%d, num:%d", info.name, info.type, info.num);  // it will print 2 same result
}

I saw the code in shaderc: https://github.com/bkaradzic/bgfx/blob/master/tools/shaderc/shaderc_hlsl.cpp#L517

It check D3D_SIT_SAMPLER and D3D_SIT_TEXTURE.

Because, SAMPLER2D defined in HLSL as two uniform: https://github.com/bkaradzic/bgfx/blob/master/src/bgfx_shader.sh#L401 (here will generate two uniform: s_texSampler, s_texTexture)

so, that check will enter twice: https://github.com/bkaradzic/bgfx/blob/master/tools/shaderc/shaderc_hlsl.cpp#L517

and will generate 2 uniforms with the same name for texture: https://github.com/bkaradzic/bgfx/blob/master/tools/shaderc/shaderc_hlsl.cpp#L526

In runtime, uniform in bgfx is hashed by uniform name, so it just only one uniform generated.

But bgfx::getShaderUniforms and will always return 2, but actually it only one uniform.

I think that is a bug for shaderc.

Is just only check D3D_SIT_TEXTURE here, is the bug fixed? https://github.com/bkaradzic/bgfx/blob/master/tools/shaderc/shaderc_hlsl.cpp#L517

Hello! I stumbled upon what I think is a bug: when RenderDoc is loaded, the backend is set to Direct3D 11, and I try to fullscreen my game, I get these messages in the log, and the backbuffer is indeed not resized, but is the previous size just stretched to fill the screen:

[TRACE] /bgfx/src/renderer_d3d11.cpp:2479 : BGFX ASSERT m_dxgi.resizeBuffers(m_swapChain, m_scd) FAILED 0x887a0001
[FATAL] /bgfx/src/renderer_d3d11.cpp:2479 {0} : m_dxgi.resizeBuffers(m_swapChain, m_scd) FAILED 0x887a0001

(this should look something like this)

This only happens with Direct3D 11, I tested with 9 and 12, they are both fine, and so is OpenGL and Vulkan. To set fullscreen mode, I just call glfwSetWindowMonitor:

const GLFWvidmode* videoMode = glfwGetVideoMode(primaryMonitor);
glfwSetWindowMonitor(window, primaryMonitor, 0, 0, videoMode->width, videoMode->height,
        videoMode->refreshRate);

Bug description During the startup of my MacOS application (bgfx with separate API thread) when calling bgfx::renderFrame() in the main thread, the app sporadically (maybe 50% chance) crashes.

Stack traces Main thread:

libsystem_kernel.dylib!__pthread_kill (Unknown Source:0)
libsystem_pthread.dylib!pthread_kill (Unknown Source:0)
libsystem_c.dylib!abort (Unknown Source:0)
libsystem_c.dylib!__assert_rtn (Unknown Source:0)
Metal!MTLReportFailure.cold.1 (Unknown Source:0)
Metal!MTLReportFailure (Unknown Source:0)
Metal!-[MTLIOAccelCommandBuffer commit] (Unknown Source:0)
AMDRadeonX6000MTLDriver!-[GFXAAMD_MtlCmdBuffer commit] (Unknown Source:0)
AMDRadeonX6000MTLDriver!-[GFX10_MtlCmdBuffer commit] (Unknown Source:0)
libbase.dylib!bgfx::mtl::CommandBuffer::commit() (/path/to/app/thirdparty/bgfx/bgfx/src/renderer_mtl.h:187)
libbase.dylib!bgfx::mtl::CommandQueueMtl::kick(bool, bool) (/path/to/app/thirdparty/bgfx/bgfx/src/renderer_mtl.mm:3556)
libbase.dylib!bgfx::mtl::RendererContextMtl::flip() (/path/to/app/thirdparty/bgfx/bgfx/src/renderer_mtl.mm:1325)
libbase.dylib!bgfx::Context::flip() (/path/to/app/thirdparty/bgfx/bgfx/src/bgfx.cpp:2385)
libbase.dylib!bgfx::Context::renderFrame(int) (/path/to/app/thirdparty/bgfx/bgfx/src/bgfx.cpp:2432)
libbase.dylib!bgfx::renderFrame(int) (/path/to/app/thirdparty/bgfx/bgfx/src/bgfx.cpp:1480)
libbase.dylib! appns::Game::updateMainThread() (/path/to/app/base/src/game.cpp:268)
libbase.dylib! appns::Game::run() (/path/to/app/base/src/game.cpp:217)
app!main (/path/to/app/game/src/app.cpp:37)
libdyld.dylib!start (Unknown Source:0)
libdyld.dylib!start (Unknown Source:0)

API thread:

libsystem_kernel.dylib!semaphore_wait_trap (Unknown Source:0)
libdispatch.dylib!_dispatch_sema4_wait (Unknown Source:0)
libdispatch.dylib!_dispatch_semaphore_wait_slow (Unknown Source:0)
libbase.dylib!bx::Semaphore::wait(int) (/path/to/app/thirdparty/bgfx/bx/src/semaphore.cpp:108)
libbase.dylib!bgfx::Context::renderSemWait() (/path/to/app/thirdparty/bgfx/bgfx/src/bgfx_p.h:5062)
libbase.dylib!bgfx::Context::frame(bool) (/path/to/app/thirdparty/bgfx/bgfx/src/bgfx.cpp:2310)
libbase.dylib!bgfx::frame(bool) (/path/to/app/thirdparty/bgfx/bgfx/src/bgfx.cpp:4030)
libbase.dylib!appns::Game::processFrame(appns::GameManager&) (/path/to/app/base/src/game.cpp:336)
libbase.dylib!appns::Game::threadFunc() (/path/to/app/base/src/game.cpp:382)
libbase.dylib!decltype(*(std::__1::forward<appns::Game*>(fp0)).*fp()) std::__1::__invoke<void (appns::Game::*)(), appns::Game*, void>(void (appns::Game::*&&)(), appns::Game*&&) (/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/type_traits:3635)
libbase.dylib!void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (appns::Game::*)(), appns::Game*, 2ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (appns::Game::*)(), appns::Game*>&, std::__1::__tuple_indices<2ul>) (/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/thread:286)
libbase.dylib!void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (appns::Game::*)(), appns::Game*> >(void*) (/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include/c++/v1/thread:297)
libsystem_pthread.dylib!_pthread_start (Unknown Source:0)
libsystem_pthread.dylib!thread_start (Unknown Source:0)

SIGABRT in renderer_mtl.h at

void commit()
{
	[m_obj commit];
}

Additional context Device: MacBook Pro 2019 (Intel) with MacOS Big Sur I am using the latest master revision of bgfx.

Do you maybe have some hints what could go wrong here?

Discussed in https://github.com/bkaradzic/bgfx/discussions/2759

void setVertexBuffer(uint8_t _stream, const TransientVertexBuffer *_tvb, uint32_t _startVertex, uint32_t _numVertices, VertexLayoutHandle _layoutHandle = BGFX_INVALID_HANDLE)

stream.m_startVertex   = _tvb->startVertex + _startVertex;
stream.m_handle        = _tvb->handle;
stream.m_layoutHandle  = isValid(_layoutHandle) ? _layoutHandle : _tvb->layoutHandle;
m_numVertices[_stream] = bx::min(bx::uint32_imax(0, _tvb->size/_tvb->stride - _startVertex), _numVertices);

Currently the only way to submit indirect draws is specify the start and count as parameters to the overload of bgfx::submit that handles indirect drawing. If the start and/or count are generated on the gpu in a compute shader, there is currently no way to submit them. An additional overload for bgfx::submit that takes a buffer for the start and count alongside the indirect buffer could allow this to be possible.