This 'floor' function is useful to adjust x, y float coordinates to the left most near integer for x, and top most near integer for y (instead of rounding towards 0). This function was included to solve issue aseprite/aseprite#2891

Example of use:

gfx::RectF boundsF(-0.25, -0.75, 1, 2);
gfx::Rect bounds = boundsF.floor();
bounds = (-1, -1, 1, 2)

When 'floor' is not used:

gfx::RectF boundsF(-0.25, -0.75, 1, 2);
gfx::Rect bounds = boundsF;
bounds = (0, 0, 1, 2)

When attempting to compile Aseprite, compilation fails due to the following error:

FAILED: laf/base/CMakeFiles/laf-base.dir/platform.cpp.o 
/usr/bin/c++ -DCMARK_STATIC_DEFINE -DHAVE_CONFIG_H -DLAF_LINUX -DLAF_SKIA -DNDEBUG -DPNG_NO_MMX_CODE -I/home/lmt/Stuff/aseprite/third_party/zlib -I/home/lmt/Stuff/aseprite/build/third_party/zlib -I/home/lmt/Stuff/aseprite/third_party/libpng -I/home/lmt/Stuff/aseprite/build/third_party/libpng -I/home/lmt/Stuff/aseprite/third_party/libwebp/src -I/home/lmt/Stuff/aseprite/third_party/tinyxml -I/home/lmt/Stuff/aseprite/third_party/pixman/pixman -I/home/lmt/Stuff/aseprite/build -I/home/lmt/Stuff/aseprite/third_party/giflib -I/home/lmt/Stuff/aseprite/third_party/jpeg -I/home/lmt/Stuff/aseprite/third_party/curl/include -I/home/lmt/Stuff/aseprite/third_party/simpleini -I/home/lmt/Stuff/aseprite/laf -I/home/lmt/Stuff/aseprite/build/laf -I/home/lmt/Stuff/aseprite/src -I/home/lmt/Stuff/aseprite/laf/third_party/stringencoders/src -O2 -g -DNDEBUG -std=c++14 -MD -MT laf/base/CMakeFiles/laf-base.dir/platform.cpp.o -MF laf/base/CMakeFiles/laf-base.dir/platform.cpp.o.d -o laf/base/CMakeFiles/laf-base.dir/platform.cpp.o -c /home/lmt/Stuff/aseprite/laf/base/platform.cpp
In file included from /home/lmt/Stuff/aseprite/laf/base/platform.cpp:11:
/home/lmt/Stuff/aseprite/laf/base/platform.h:56:59: error: static assertion failed: Invalid identification of CPU architecture
   56 |   static_assert((arch == Arch::x86 && sizeof(void*) == 4) ||
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
   57 |                 ((arch == Arch::x64 ||
      |                 ~~~~~~~~~~~~~~~~~~~~~~                     
   58 |                   arch == Arch::arm64) && sizeof(void*) == 8),
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[600/1554] Building CXX object laf/base/CMakeFiles/laf-base.dir/program_options.cpp.o
ninja: build stopped: subcommand failed.

If I were to guess, this is due to my system reporting aarch64 instead of arm64.

% uname -m
aarch64

My OS is Arch Linux ARM running on the Pinebook Pro.

This PR replaces the use of WideCharToMultiByte and MultiByteToWideChar to convert to and from utf8 strings by the use of the C++11 standard conversion functions.

One thing to note is that the int parameter of to_utf8 was removed, which breaks the compatibility with previous versions of the library. Not sure if we should keep it and adapt the function to work as before.

WARNING: C++17 deprecates the codecvt header...so...maybe this PR doesn't worth it.

Running Aseprite batch mode (using -b) as part of a headless asset build process was causing it to segfault in XInput::~XInput() because m_xi was uninitialized. Forcing zero initialization fixes it.

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

Instead of calling SetCursor(), swap the cursor reference on the window class. This aims to address https://github.com/aseprite/aseprite/issues/2713 Where SetCursor() results in decreased responsiveness as usage time progresses and persists even after closing and reopening the program.

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

After pthread_join() all allocated to thread resources are freed, so pthread_detach() after pthread_join() will results in undefined behavior with SIGSERV on some libc implementations (like MUSL). According to pthread_detach(3), "Either pthread_join(3) or pthread_detach() should be called for each thread that an application creates".

I agree that my contributions are licensed under the MIT License. You can find a copy of this license at https://opensource.org/licenses/MIT

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

I have simply added strerror to each function which throws an error to get a more detailed error message.

In macOS, if the user's filesystem is case-sensitive, then laf CAN'T locate /System/Library/Frameworks/OpenGL.framework/, which results in link failures. (aseprite/aseprite#1776)

This is because cmake/FindSkia.cmake tries to locate /System/Library/Frameworks/opengl.framework/. (Notice the lowercase "opengl" instead of "OpenGL"), and this commit fixes such error on macOS with a case-sensitive filesystem.

Tested on Macbook Pro Retina 2014 with Mojave + APFS (case-sensitive):

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

On Retina displays view/window coordinates are logical points not pixels and window.backingScaleFactor represents how many pixels are covered by single coordinate point.

This change effectively makes LAF UI 2x smaller on Retina displays, but allows drawing at native Retina resolution.

A picture is worth a thousand words: (NOTE: Click on the image to see it on full 2x/Retina scale)

Picture above depicts Aseprite using 400% scale on Retina and using TTF font instead of bitmap font.

I understand this change may be completely irrelevant for most of the Aseprite users using default UI settings, but if you want to use TTF font this change actually makes all TTF fonts look crisp on macOS Retina displays. And I prefer to have TTF font on my Retina display rather than default bitmap font, that I find hard to read 🙄

I agree that my contributions are licensed under the Laf license, and agree to future changes to the licensing.

Hi! Hope this can be of a little help (^ ^;)

It is a not-so-elegant workaround — I cannot find much information on how UCKeyTranslate() works, and this is the only way I can get the outcome correct so far. For now it seems that UCKeyTranslate() ignores the Caps Lock flag without Shift, and reads it with Shift, hence always disabling its function. I don't know the reason behind it, and I might, might be terribly wrong… I'd appreciate if anyone can provide a deeper insight into it!

Btw, this can fix aseprite/aseprite#1876.

The rationale behind this proposal is a bug that resulted from the use of the parse function in Aseprite. It so happened that the position of arguments is sensitive in some instances. For example, in cases where values without any associated options (e.g file names) come before some options, Aseprite opens the file(s), parse and process the opened file(s) before moving on to processing the other arguments. In some of these cases, the options provided via the CLI may be what is supposed to drive how the file is opened, parsed and processed. However, if the file is eagerly processed before the arguments, it results in some hard-to-debug bugs. This PR allows the user have two options:

• get access to the CLI values/options as-is
• move the option-less values to the end of "queue"

This second option delays the eagerness to open/process option-less values until all driving forces are properly taken care of. If, from Aseprite, we could have direct mutating access to the underlying values and options parsed, there would not have been a need for this PR but (rightly so) the interface exposed is immutable -- thus why I think this PR may be needed.

PS: I am not so sure the name of this function (sortedParse) is the right name for it, but as at the time of making this amendment, this is the only name I could think of.

ADDENDUM: According to this comment, this PR may not be necessary as the Aseprite opened issue isn't really a bug but a feature.

Review keyboard events and codes. Rename KeyScancode to VKey or something like that our KeyScancode is a virtual keycode in reality.

Also check what compatibility we can offer with web keycodes:

• https://developer.mozilla.org/en-US/docs/Web/API/UI_Events/Keyboard_event_code_values
• https://w3c.github.io/uievents/tools/key-event-viewer.html

find_library() is not a proper way for finding OpenGL libraries.
On Windows, SKIA_OPENGL_LIBRARY got "SKIA_OPENGL_LIBRARY-NOTFOUND"
without using VS-Dev-CMD.

See discussions here:
    https://gitlab.kitware.com/cmake/cmake/-/issues/19804
    https://gitlab.kitware.com/cmake/cmake/-/issues/20226

Use find_package(OpenGL) and OpenGL::GL instead.

On Windows systems with non-English locales, the wide strings may cause
"Error C2001: Newline in constant".

2 solutions:
    Save the file with UTF-8 with BOM (byte-order mark).
    Specify UTF-8 charset for compilation. Used by this commit.

See discussions here:
    https://github.com/libusb/libusb/issues/207#issuecomment-288664124

I agree that my contributions are licensed under the MIT License. You can find a copy of this license at https://opensource.org/licenses/MIT

Just yesterday I was investigating about the possibility to enable UTF-8 support on the console (using SetConsoleOutputCP(CP_UTF8)): https://github.com/aseprite/laf/commit/ad8cf4929f5effab88cc393b7d9534d32a65de8d

But I'm not sure if this should be done by default. Even more, we could add support to use ANSI version of functions which can support UTF-8 directly (if we embed a special manifest file): https://docs.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page#set-a-process-code-page-to-utf-8

In this way we could avoid the from_utf8/to_utf8 conversions on each Win32 API call (https://docs.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page#-a-vs--w-apis).

Hi!

This change, in short, implements base::copy_file function based on the idea of copying and pasting memory blocks. I've also changed the functions (move, copy and delete file) that throw exceptions unnecessarily to return bool type. (It needs clarify that I'm not an expert :sweat_smile:)

Add a couple of events to detect when the user deactivate the app (focus other app). In this way we can stop some timers (e.g. a blinking text cursor).