Due to the limitations of the Ace of Spades v0.75 protocol, everything calculates on client-side. In today's world with "mass" online servers, it's unacceptable to give players so much control over the game. For example, it's possible to bypass max damage value for each weapon and kill everyone with one shot, even using SMG from the other end of the map. For example OpenSpades rifle damage values for v0.75 protocol:

https://github.com/yvt/openspades/blob/8bdaeb06c116693ef617357bfb350847bc50b8b8/Sources/Client/Weapon.cpp#L212-L216

It's also possible to change the spread and reload speed, as well as the delay between shots:

https://github.com/yvt/openspades/blob/8bdaeb06c116693ef617357bfb350847bc50b8b8/Sources/Client/Weapon.cpp#L223

https://github.com/yvt/openspades/blob/8bdaeb06c116693ef617357bfb350847bc50b8b8/Sources/Client/Weapon.cpp#L207

https://github.com/yvt/openspades/blob/8bdaeb06c116693ef617357bfb350847bc50b8b8/Sources/Client/Weapon.cpp#L204

I'm sure it would be great to create some limits, at least the max damage for each weapon, accordingly to the OpenSpades or protocol (if defined). Vulnerability demonstration on a local SpadesX server (d812a40): (buggy, due to client-server packet processing limitations and very low delay)

https://user-images.githubusercontent.com/28919772/182958995-807c48e0-8977-4be2-b263-e7ca4bc2fb2d.mp4

Description:

• Any player can troll the console using ANSI Code, like: \033[2J or \033[31;5m. (Maybe can be fixed using iscntrl()?)

How to reproduce:

• Start the server, join and send a message with any ANSI code or just set your nickname to it.

Well, it's functional and it compiles and runs perfectly and without warnings on Windows, I haven't tested it on Linux distros or on MacOS because I don't have it in my hands, but I would be grateful if someone could talk later if there was any problem compiling/running on Linux/MacOS.

The only defect is in the console, which in Windows the escape characters are different, so the text output looks like this:

I'll fix this and do a PR when I can.

Made these changes before I found out that the config file together with map are located in the source directory, though they aren't copied to the build directory. What a dumbass!

Anyway, I think that having a fallback for the config values is a great feature.

Also, while rewriting config reading routines, I've found these lines of code:

https://github.com/SpadesX/SpadesX/blob/9a5b9f10d8f13c0e0f5910f2d92d8dc8660cf304/Source/Server.c#L180-L185

Is it supposed to read only 2 elements from the 3 element array? Or is it just me having an amount of braincells that is roughly equal to the size of said arrays?

I'm trying to configure the server on Windows but the git submodule command doesn't work, the command only brings the libmapvxl library, and nothing else

Follow the image below:

Whit this version of SpadesX (https://aos.party/jenkins/job/SpadesX/lastSuccessfulBuild/artifact/build/) when you put this symbols in your name when you enter in SpadesX your name now is Limbo. I think my name should appear ignoring those symbols because if I change the color of my name they wouldn't know which team I'm from red or blue.

And if you put in periodic_messages or welcome_messages this symbols dont apper in red like if you copy and paste in the chat that text.

simbols and config.zip

Fixes:

• Ensures the development of multi-map support will work with the default maps out of the box.

Changes proposed in this pull request:

• Adding Maps repo to Extern.

• [x] - Movement in server
• [x] - Fall damage
• [x] - Grenades
• [x] - Grenades player damage
• [x] - Fix the damn ID bug
• [x] - Implement actual gameplay (intel pickup etc.)
• [x] - Add ban command
• [x] - Normalize vectors to prevent speed movement hacks.
• [x] - Floating block detection.
• [x] - Map split sending
• [x] - Fix invisible players on joining
• [x] - Make players not die on new user joining (libvxl_write takes way too long to fixing causing physics to go out of sync too much making players get fall damage).
• [x] - Grenade floating block destroying

More to be added later.

Describe the bug I tried to connect to a server without port forwarding using this build on 12/31/2022 (https://aos.party/jenkins/job/SpadesX/lastSuccessfulBuild/artifact/build/zip/build.zip) with this link aos://16777343 and this other aos://192.168.0.6:32887 in NucetoSpades 0.5 | v7.7.7 but it logged me out using any of the links instead OpenSpades 0.1.3 let me log in with any of the links. Im using Windows 10 Error Text (Screenshot)

OpenSpades has wonderful features from UI to graphics, why not implement some of them?

Would be nice, because OpenSpades development is very slow, even to fix bugs/crashes.

Description:

• Can't get or capture the intel when tent/intel is in the water (if you not crouch on it).

How to Reproduce:

• Start the server using a map with water, where the intel can spawn on there. Join in the server and try to get the intel without crouching.

Client used: Voxlap (tried to use openspades, but my os keeps dropping packets) Map used: https://aos.party/view/9

Hello. Thanks for a wonderful app! Really tiny and minor security issue here.

From what I see in your server you use C standard rand to generate random data, like coordinates for game objects: intel and player respawn points.

As it is known, libc uses linear congruential pseudo-random number generator (PRNG) that can be easily cracked given some inputs.

So for example when doing some of the cups on this game, one command can achieve an unfair advantage knowing where the intel will be spawned and where the players' spawnpoints will be generated - being able to plan their offensive beforehand.

As for the proposed solution: you may use some more cryptosecure PRNG algos, for example Mersenne Twister PRNG or any other. For example you can see tiny implementation here.

Is your feature request related to a problem? Please describe. This probably is related to #47

Describe the solution you'd like Adding a maps folder, then add an option to config for "auto_rotation", that will read all maps into maps folder then adding it to rotation, overwriting the currently rotation setted on config.

Describe alternatives you've considered Using the #47 combined with the above idea.

Is your feature request related to a problem? Please describe. SpadesX has many features, from configurations to anti-cheating etc, but lack of documentation on what features SpadesX has will make it's use harder by the community & may hamper it's adoption.

Describe the solution you'd like Adding documentation of the features SpadesX has & how to use them when they allow for customization or such.

Describe alternatives you've considered We could decide not to document the features but then people wouldn't know what SpadesX can do & they wouldn't want to use it.

Additional context Looking at previous commits & issues as well as PRs might help find the features SpadesX has.

Is your feature request related to a problem? Please describe. Many maps are designed with water damage in mind but right now SpadesX doesn't support it, which makes those maps, well, problematic.

Describe the solution you'd like It would be nice to add a water damage option in the map configurations allowing sysadmins to active it for specific maps & specify the inflicted damage in the map configurations.

Describe alternatives you've considered We could simply not add this but many maps would then be problematic since their designs are based around this feature & even some gamemodes require this feature.

Additional context This is probably a good first issue for a first time contributor since it's relatively easy to implement.

Is your feature request related to a problem? Please describe. People often have to manually build the software, update it & install it which requires a lot of manual commands. For less technical people or those that are more lazy, this can be cumbersome & eat up a lot of time.

Describe the solution you'd like It would be ideal to add the following scripts to help automated standard "workflows" that people have to do:

• [ ] Install script
• [ ] Build script
• [x] ~~Update script~~

Describe alternatives you've considered Running the commands manually is an option or making rudimentary script too, but properly made scripts would ensure an easier learning curve when it comes to using SpadesX.

Additional context @Haxk20 Pointed out that he wanted properly built scripts for this in PR #25 .

Is your feature request related to a problem? Please describe. We currently only support an array of maps hardcoded in the configuration & have 1 map located in the configuration of SpadesX. However most people running a server will want to avoid modifying the configuration to enter 100+ maps in it, so it would be preferable to add support for the Maps repo which was created to solve this issue: https://github.com/SpadesX/Maps .

Describe the solution you'd like Adding support for the Maps repo & linking the repo in the SpadesX repo so maps are no longer kept in the main repository of SpadesX but rather referenced and managed in another.

Describe alternatives you've considered We could keep maps in the current repo, but this would clutter it & centralize the software too much.

Additional context The Maps repo was created in advance expecting this in the future.