Maciej notified me about discussion on SOCI at Linkedin C++ Professionals Group, where folks discussed that SOCI still suffers from potential of throwing from destructor while another exception is handled.

Maciej suggested to fix it by checking std::uncaught_exception() in ref_counted_statement_base::dec_ref(), and if it returns true, the final_action() should not be called to avoid _any_ interactions with database.

The new version uses consistent spelling that matches the name of then module file (Soci instead of SOCI). In addition it delegates the handling of individual components to the standard cmake function and adds support for querying the SOCI version (from the version.h header file).

Hello, I'm writing on behalf of the MacPorts package management system. We are trying to update our port of Oracle Instant Client from 10.2.0.4.0 to 11.2.0.3.0, but doing this causes soci to fail to build with Oracle support. I tested version 3.1.0 and 176805b886929d7f7df4f93b1eb987e6f4be0a1e from git with the same result. This is the error message:

ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) for architecture x86_64

We get the same error when trying to build TOra 2.1.3 with Oracle support.

Here is the full build log. I'm on OS X 10.8.2 compiling with Xcode 4.6's version of clang ("Apple LLVM version 4.2 (clang-425.0.24) (based on LLVM 3.2svn)").

Due to unsupported default param usage in macros and no qualified given _WIN32_WINNT version the test apps will not compile with some of Microsoft compilers. Exception Features used are only available if a minimum version is set due to conditional enabling in windows.h file (and sub required files)

I can't seem to be able to add soci as a subproject.

I have tried with ExternalProject_Add, and FetchContent but I can't figure out why I keep getting:

CMake Error at src/test_app/CMakeLists.txt:21 (add_dependencies):
  The dependency target "soci" of target "test_app" does not exist.

Project description

My project structure is the following:

└── src
    ├── CMakeLists.txt
    ├── cmake
    │   ├── soci.cmake
    │   └── spdlog.cmake
    ├── test_app
    │   └── CMakeLists.txt
    └── (...)

src/CMakeLists.txt

cmake_minimum_required(VERSION 3.11)

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

include(cmake/spdlog.cmake)
include(cmake/soci.cmake)

add_subdirectory(test_app)

src/test_app/CMakeLists.txt

cmake_minimum_required(VERSION 3.11)

project(test_app LANGUAGES CXX)

add_executable(test_app main.cpp)

target_link_libraries(test_app PRIVATE
    spdlog
    SOCI::core
)

add_dependencies(test_app spdlog soci)

spdlog.cmake

cmake_minimum_required(VERSION 3.11)

message(STATUS "Extern: spdlog v1.4.2")

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

include(FetchContent)

FetchContent_Declare( spdlog
    GIT_REPOSITORY https://github.com/gabime/spdlog
    GIT_TAG v1.4.2
    GIT_SHALLOW ON
)
FetchContent_GetProperties(spdlog)
if(NOT spdlog_POPULATED)
    set(SPDLOG_BUILD_EXAMPLE OFF)
    set(SPDLOG_BUILD_EXAMPLE_HO OFF)
    set(SPDLOG_BUILD_TESTS OFF)
    set(SPDLOG_BUILD_TESTS_HO OFF)
    set(SPDLOG_BUILD_BENCH OFF)
    set(SPDLOG_SANITIZE_ADDRESS OFF)
    set(SPDLOG_INSTALL ON)
    set(SPDLOG_FMT_EXTERNAL OFF)
    FetchContent_Populate(spdlog)
    add_subdirectory(
        ${spdlog_SOURCE_DIR}
        ${spdlog_BINARY_DIR}
        EXCLUDE_FROM_ALL)
endif()

soci.cmake

cmake_minimum_required(VERSION 3.11)

message(STATUS "Extern: SOCI pre4.0+git_blksail")

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

include(FetchContent)

FetchContent_Declare( soci
    GIT_REPOSITORY https://github.com/SOCI/soci
    GIT_TAG master
    GIT_SHALLOW ON
)
FetchContent_GetProperties(soci)
if(NOT soci_POPULATED)
    set(SOCI_STATIC ON)
    set(SOCI_SHARED ON)
    set(SOCI_TESTS OFF)
    # set(SOCI_ASAN OFF)
    set(SOCI_CXX11 ON)
    set(SOCI_LIBDIR lib)
    set(WITH_SQLITE3 ON)
    set(WITH_POSTGRESQL ON)
    set(WITH_BOOST OFF)
    set(WITH_DB2 OFF)
    set(WITH_ODBC OFF)
    set(WITH_ORACLE OFF)
    set(WITH_MYSQL OFF)
    set(SOCI_EMPTY OFF)
    FetchContent_Populate(soci)
    add_subdirectory(
        ${soci_SOURCE_DIR}
        ${soci_BINARY_DIR}
        EXCLUDE_FROM_ALL)
endif()

Replace type_ptr by shared_ptr that can be easily replaced by boost::shared_ptr

Solve some issues encountered using sqlite3 backend

Not tested with any other backend

1. Fixed a bug in preparing a vector of strings for binding. The current implementation inserted an extra white character to the end of each string. This error shows up in SQL Server, not in MySQL (via ODBC).
2. Added support for long long.
3. Added two search paths to FindODBC.cmake.

When developing with soci I tried to use the following:

//tried to insert null as second parameter
sql << "insert into test values( :int, :str )", use(1), use("",i_null); 

which was not supported because use indicator was only implemented for non const scenario.

I have also tried to call use with const char instead of std::string:

 //This was also not supported
sql << "insert into test values( :str )", use("Hello");

So I wrote some additional templates and functions in use.h to support the following cases: 1.) dbNull() function to use whenever we need to insert null value into database 2.) Support for const char* type 3.) Support for const char[N] type

In order to enable the following scenarios I needed to modify use_container template to support some additional cases so bool isDataOwner template argument is added in order to detect whether use_container holds a referenced value or holds a copy of the value passed to use function.

With this PR additional use scenarios are possible:

//use const char[N] directly 
sql << "insert into test values(:str)", use("Hello");

//use const char* directly
const char* value = "Hello";
sql << "insert into test values(:str)", use(value);

// use dbNull() instead of explicit indicator
sql << "insert into test values(:str)", dbNull();
// alternative to dbNull( value type is ignored in this case)
sql << "insert into test values(:str)", use("",i_null);

With the most recent master checkout (70085e8a0a6d0d) building with mingw fails now at the very first file. Although I already got one ticket ( #338 ) about building problems with mingw, I have opened this one, because I assume this is just a minor, different, one line correction bug.

C:\Users\klm\Downloads\soci_build>"C:\Program Files (x86)\Dev-Cpp\MinGW64\bin\mi
ngw32-make.exe"
Scanning dependencies of target soci_core
[  1%] Building CXX object src/core/CMakeFiles/soci_core.dir/backend-loader.cpp.
obj
C:\Users\klm\Downloads\soci\src\core\backend-loader.cpp:1:0: error: -fPIC ignore
d for target (all code is position independent) [-Werror]
 //
 ^
cc1plus.exe: all warnings being treated as errors
src\core\CMakeFiles\soci_core.dir\build.make:54: recipe for target 'src/core/CMa
keFiles/soci_core.dir/backend-loader.cpp.obj' failed
mingw32-make[2]: *** [src/core/CMakeFiles/soci_core.dir/backend-loader.cpp.obj]
Error 1
CMakeFiles\Makefile2:125: recipe for target 'src/core/CMakeFiles/soci_core.dir/a
ll' failed
mingw32-make[1]: *** [src/core/CMakeFiles/soci_core.dir/all] Error 2
Makefile:126: recipe for target 'all' failed
mingw32-make: *** [all] Error 2

Here is the fix for the lack of info when calling statement::get_affected_rows() after bulk operations using postgresql backend. The other backends seem to already provide this info under this kind of use but I don't have the means to confirm that. The tests for get_affected_rows might confirm that.

This is similar to #238 but completes it by

1. Doing the same thing in the other direction, i.e. when writing doubles to the database and not reading them.
2. Doing the same changes in mysql and sqlite3 backends in addition to the postgresql one.