I needed this patch for LuaDist to build on linux (and I assume everywhere else). It looks like Lua 5.2.1 added the constant LUAI_MAXSHORTLEN, which was missing from src/luaconf.h.in. This patch just pulls in the relevant lines, and allows lua to compile.

Reviewing the update to Lua 5.2.1 more generally, it looks like the update of src/luaconf.h.in undid some LuaDist-specific stuff and missed some other vanilla Lua updates. I started to make a more general patch, but decided that I didn't know how to handle the LuaDist-specific stuff. For instance, are we supposed to let cmake or luaconf.h configure the platform-specific path/directory variables?

Signed integer overflow is undefined behavior in C. In this commit we patch a signed integer check in ltablib.c in the function unpack.

This patch may need to be modified under the constraints of two operations

ltablib.c:140
i = luaL_optint(L, 2, 1)

ltablib.c:141
e = luaL_opt(L, luaL_checkint, 3, luaL_len(L, 1)

Here, we assume i and e can be any value in its given type, int. If this is true, we must check for some special cases. If i is INT_MIN, we can't just take the negative value of it, as -INT_MIN = INT_MAX+1 (theoretically) which is undefined behavior.

The original check against the value of

n = e - i + 1

was

n <= 0

to check for signed integer overflow. Signed integer overflow is undefined behavior.

I ran cppcheck on luaDist/lua and it found these errors: loadlib_rel.c 202 resourceLeak error Resource leak: fd loadlib_rel.c 193 uninitvar error Uninitialized variable: n

First one was in the #else and second one in the #elif defined(APPLE)

Fixes lua.dll being generated without public symbols by the Visual Studio compiler;

• when building a DLL you either need a DEF file listing the public symbols or use __declspec(export) in the public symbols.
• when linking to a DLL you only need to use __declspec(import) when referencing data, since lua only exports functions it isn't needed for the other targets.

Tested compilation in the following dev environments: (Windows 7)

• Visual Studio 10 x86 + cmake 2.8.8
• Visual Studio 10 x64 + cmake 2.8.8
• MinGW + gcc 4.6.2 + cmake 2.8.5
• MSYS + MinGW + gcc 4.6.2 + cmake 2.8.5
• Cygwin + gcc 4.5.3 + cmake 2.8.7

I am using CMake 2.8.8 to build LuaDist and found that it rejects commands if they are on the same line. This pull request allows cmake to complete without errors.

upgrade to lua-5.3.3. i removed loadlib_rel from src, let lua process it (with env var or coded in script). and install_test and install_example are also removed.

The new option "LUA_LINK_MSVCRT_STATIC" enables adding compile option "/MT" (or "/MTd" for Debug configuration) for Visual Studio generator. Without this option, all binaries will have dynamic linkage to "MSVCR120.dll" or something.

The default remains building liblua as a shared library because BUILD_SHARED_LIBS is set to ON in dist.cmake. However, this patch makes it possible to build statically by changing this variable.

It looks as though 5.2 accidentally dropped the included lua.hpp file from install_header. 5.1.5 still has it. This file is required for C++ projects using Lua.

There is a .orig file in the luadist lua repo.

This is a file created by the git merge system. You almost certainly checked it to git by accident. It's not in the Lua 5.1.5 official release.

Sometimes I run a script to make sure I'm not accidentally leaving any orig files around in my repo. It freaks out out on my luadist remote because of the orig file in there.

Probably best to just delete it.

Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.18950. The C compiler identification is MSVC 19.23.28105.4 Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe -- works Detecting C compiler ABI info Detecting C compiler ABI info - done Detecting C compile features Detecting C compile features - done DIST_NAME: lua DIST_VERSION: 5.3.2 DIST_LICENSE: MIT/X11 DIST_AUTHOR: Roberto Ierusalimschy, Waldemar Celes, Luiz Henrique de Figueiredo DIST_MAINTAINER: Peter Drahoš DIST_URL: http://www.lua.org DIST_DESC: Lua is a powerful, fast, light-weight, embeddable scripting language. DIST_DEPENDS: Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) Could NOT find readline (missing: READLINE_LIBRARY READLINE_INCLUDE_DIR) Configuring done Generating done