VTK fails to build during compilation by gcc-4.9 with the following message:

CMakeFiles/vtkFiltersParallelMPI.dir/vtkDistributedDataFilter.cxx.o: In function `memset': /usr/include/x86_64-linux-gnu/bits/string3.h:81: warning: memset used with constant zero length parameter; this could be due to transposed parameters collect2: error: ld returned 1 exit status

This patch sets if-condition before all "memsets" in vtkDistributedDataFilter and checkes, whether the number of bytes to be set by memset is more than 0 to escape this error.

If I understand correctly. The function of SetMarkVisitedPointIds() is, that you can reteive a list of point id's that correlates to the selected, hence visited cell data of the filter input. In the current version of the filter, one only gets the visited order of the points and not their original id's. This is because the "this->PointMap[pts[i]]" entry is filled using the "PointNumber" variable, rather than the actual point id. So one basically gets the order of the point in the filter output, rather than the expected selected point id's of the input.

This extension to vtkDiscreteMarchingCubes makes it possible to let vtkDiscreteMarchingCubes also create vtkPointData Scalars containing the label value of the neighbouring voxel in a label image. This then allows to remove regions of the resulting mesh that are adjacent to specific other label meshes. For example a label image that was created by running a watershed on a distance map followed by masking with the original binary segmentation, a common procedure to separate regions in the segmentation at constrictions (see e.g. Beare and Lehmann (2006) The watershed transform in ITK - discussion and new developments, http://hdl.handle.net/1926/202). Such a label image is shown in Fig. 1.

Fig. 1 A label image that separates a segmentation at constrictions and also contains a background label (0, rendered fully transparent). The cursor is on label 21 (light purple) which is adjacent to label 19 (dark pink):

When creating meshes for each foreground label from such a label image the meshes are closed at the constrictions where the separation was introduced, see 3D view in Fig. 1 and Fig. 2.

Fig. 2 Meshes generated by vtkDiscreteMarchingCubes for the label image shown above, coloured differently and smoothed with vtkWindowedSincPolyDataFilter. Note the capping at constrictions:

With the contributed extension to vtkDiscreteMarchingCubes the resulting mesh contains additional scalar data for the points that holds the label value of the adjacent label. A simple threshold that extracts the regions of the meshes that are adjacent to the background label (0) then makes it possible to remove the capping at constrictions, see Fig. 3.

Fig. 3 Result only displaying those regions of the meshes that were adjacent to the background label. Note that the capping is removed compared to Fig. 2:

For example looking at label 19 and 21 (extracted by a simple threshold on the cell scalars generated by vtkDiscreteMarchingCubes) which are adjacent to each other but mostly separated by the background label, see Fig. 4.

Fig. 4 Showing only the meshes of label 21 (light grey) and 19 (dark grey). Regions of the mesh of label 21 are coloured if adjacent to other labels, e.g. red where 19 and 21 touch, i.e. where the separation took place:

Fig. 5 Views of label 21 only, coloured as in Fig. 4:

An additional threshold on the point scalars then removes the capping at the separation, see Fig 6.

Fig. 6 Capping removed from label 21:

An advantage of this kind of capping removal is that it is even possible after the mesh was modified by other filters, e.g. smoothed by vtkWindowedSincPolyDataFilter. However, in most cases the resulting meshes are not connected on the open border edges any more, i.e. there will be gaps between them. The vtkCoplanarSurfaceExtractor (Grothausmann (2014) Extracting Intersections of Coplanar Surfaces (Boolean-operation on touching meshes), http://hdl.handle.net/10380/3504) can be used to avoid such gaps.

1. IO/FFMPEG/vtkFFMPEGWriter.cxx ffmpeg 3.x compatibility

2. Rendering/GL2PSOpenGL2/vtkOpenGLGL2PSHelperImpl.cxx gl2psAddPolyPrimitive function parameters

Cheers Pei

Results: https://github.com/cclauss/VTK/actions

$ flake8 . --count --select=E9,F63,F7 --show-source --statistics

[ ... ]
15    E999 SyntaxError: invalid syntax
15

https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead, these tests focus on runtime safety and correctness:

• E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST). Often these issues are a sign of unused code or code that has not been ported to Python 3. These would be compile-time errors in a compiled language but in a dynamic language like Python, they result in the script halting/crashing on the user.
• F63 tests are usually about the confusion between identity and equality in Python. Use ==/!= to compare str, bytes, and int literals is the classic case. These are areas where a == b is True but a is b is False (or vice versa). Python >= 3.8 will raise SyntaxWarnings on these instances.
• F7 tests logic errors and syntax errors in type hints
• F82 tests are almost always undefined names which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3. These also would be compile-time errors in a compiled language but in Python, a NameError is raised which will halt/crash the script on the user.

Thanks for your interest in contributing to VTK! The GitHub repository is a mirror provided for convenience, but VTK does not use GitHub pull requests for contribution. Please see

https://gitlab.kitware.com/vtk/vtk/-/tree/master/CONTRIBUTING.md

for contribution instructions. GitHub OAuth may be used to sign in.

Having changed the build options to VTK_USE_SYSTEM_AUTOBAHN=YES VTK_USE_SYSTEM_TWISTED=YES VTK_USE_SYSTEM_ZOPE=YES I discovered that Web/JavaScript/CMakeLists.txt is missing an include(vtkPythonPackages) for the copy_files_recursive definition.

If the user clicks in a plot that has an invalid (0,0) range, then in vtkContextScene::ProcessItem that is called after mouse events, the mapped mouse position becomes NaN, due to invalid matrix in the ContextScene's transform. This NaN position is then added to the function as a control point with an invalid NaN value. This fix makes sure this does not happen, by clamping the NaN values to minimum bounds on x axis, and 0 on y axis (any value comparison returns false if an operand is NaN, so need to check explicitly).

Thanks for your interest in contributing to VTK! The GitHub repository is a mirror provided for convenience, but VTK does not use GitHub pull requests for contribution. Please see

https://gitlab.kitware.com/vtk/vtk/tree/master/CONTRIBUTING.md

for contribution instructions. GitHub OAuth may be used to sign in.

addendum PR to #38 VTK Gitlab Issue: https://gitlab.kitware.com/vtk/vtk/issues/16994 Gitlab PR: https://gitlab.kitware.com/vtk/vtk/merge_requests/2562 CC @cquammen @cory-quammen

fix typo

Thanks for your interest in contributing to VTK! The GitHub repository is a mirror provided for convenience, but VTK does not use GitHub pull requests for contribution. Please see

https://gitlab.kitware.com/vtk/vtk/-/tree/master/CONTRIBUTING.md

for contribution instructions. GitHub OAuth may be used to sign in.

Linking against the rendering backend is not done for the examples in the Infovis directory. At runtime, this leads to a seg-fault:

Generic Warning: In /home/manuel/work/99_temp/VTK-8.1.0/Rendering/Core/vtkRenderer.cxx, line 55
Error: no override found for 'vtkRenderer'.

Generic Warning: In /home/manuel/work/99_temp/VTK-8.1.0/Rendering/Core/vtkRenderWindow.cxx, line 43
Error: no override found for 'vtkRenderWindow'.


Program received signal SIGSEGV, Segmentation fault.
0x00007ffff749821b in vtkRenderViewBase::vtkRenderViewBase (this=0x5555557a0180)
    at /home/manuel/work/99_temp/VTK-8.1.0/Views/Core/vtkRenderViewBase.cxx:33
33        this->RenderWindow->AddRenderer(this->Renderer);

Thanks for your interest in contributing to VTK! The GitHub repository is a mirror provided for convenience, but VTK does not use GitHub pull requests for contribution. Please see

https://gitlab.kitware.com/vtk/vtk/tree/master/CONTRIBUTING.md

for contribution instructions. GitHub OAuth may be used to sign in.

Hi all, I'd like to add the click and drag action in the ChartXY. This is part of an update for 3DSlicer to use vtkPlots. @jcfr

https://github.com/Slicer/Slicer/pull/770 https://www.dropbox.com/s/g08jzgacjxy54dm/videoPlot.mkv?dl=0

The miss initialization of member variable DataSet in function vtkAreaPicker::Initialize will cause crash of PCL program randomly when empty area picking of QVTKOpenGLNativeWidget which holding a pcl::visualization::PCLVisualizer as actual visualizer.

The crash will happen if: step1: picking a subset of cloud points holding by PCLVisualizer. step2: remove this subet set from the PCLVisualizer. step3: picking the region without any cloud points the dangling member variable DataSet will romdonly cause the if condition at line 174 of pcl::visualization::PointPickingCallback::performAreaPick become true. Then the dangling points->GetPointData() will cause crash.

Thanks for your interest in contributing to VTK! The GitHub repository is a mirror provided for convenience, but VTK does not use GitHub pull requests for contribution. Please see

https://gitlab.kitware.com/vtk/vtk/-/tree/master/CONTRIBUTING.md

for contribution instructions. GitHub OAuth may be used to sign in.

After executing the SetFileNames method, the DICOM file is not loaded, and the judging FilesNames variable is added, but it is not elegant.

Thanks for your interest in contributing to VTK! The GitHub repository is a mirror provided for convenience, but VTK does not use GitHub pull requests for contribution. Please see

https://gitlab.kitware.com/vtk/vtk/-/tree/master/CONTRIBUTING.md

for contribution instructions. GitHub OAuth may be used to sign in.