Version/Branch of Dear ImGui: Version: Dear IMGUI 1.69 WIP Branch: addons

Back-end/Renderer/Compiler/OS Back-ends: win32 + gl3w Compiler: Visual C++ 2010 Operating System: Windows 7 X64

My Issue/Question: Visual C++ 2010 hangs when trying to compile main2.cpp in addons_examples Command line used is: cl /I . /I .. /I ..\addons /DIMGUI_INCLUDE_IMGUI_USER_H /DIMGUI_INCLUDE_IMGUI_USER_INL /DIMGUI_USE_WINAPI_BINDING /DIMGUI_USE_GL3W /DIMIMPL_SHADER_GL3 main2.cpp

main.cpp however compiles fine and I can generate the executable with this: cl /Feimguiaddon.exe /I . /I .. /I ..\addons /DIMGUI_INCLUDE_IMGUI_USER_H /DIMGUI_INCLUDE_IMGUI_USER_INL /DIMGUI_USE_WINAPI_BINDING /DIMGUI_USE_GL3W /DIMIMPL_SHADER_GL3 gl3w.c ..\imgui.cpp ..\imgui_demo.cpp ..\imgui_draw.cpp imgui_impl_win32.cpp main.cpp version.lib winmm.lib shell32.lib gdi32.lib ole32.lib advapi32.lib oleaut32.lib Opengl32.lib

Screenshots/Video Standalone, minimal, complete and verifiable example: _(see ```

Since dear imgui v1.60, calling CreateContext is required as the static global context has been removed. The purpose of this PR is to reflect that design decision in the imguidock addon.

No new API calls were added. I have reused the existing CreateDockContext SetCurrentDockContext and DestroyDockContext functions:

// A dock context needs to be present.
ImGui::DockContext *dockCtx = ImGui::CreateDockContext();
ImGui::SetCurrentDockContext(dockCtx);

// Context cleanup (will also set the current context to null):
ImGui::DestroyDockContext(dockCtx);

I have added this same example to the header usage code.

In case anybody forgets to set up a context, I have sprinkled IM_ASSERT before all g_dock dereferences so that any null pointer dereference issues easier to debug.

This would benefit the people who are hotloading code.

Hi Flix01,

Please, I'm trying DateChooser and is really delicious. Nice looking calendar that respects the leap year (28-29 February), but has enough serious errors. When I want to view two calendars side by side so I will not see me neither. Respectively button displays an actual calendar but did not. Maybe it's a BUG or bad I use it myself but you ought to know about it. Ted does not know what the council ...: - / I am not sufficiently powerful computer for uploading video screen but here is my code:

        ImGui::PushID("dateFrom");
        ImGui::Text("%s", "Paper will be published from:");
        static tm dateFrom = ImGui::GetCurrentDate();
        ImGui::DateChooser("##dateFrom",dateFrom);
        ImGui::PopID();

        ImGui::PushID("dateTo");
        ImGui::Text("%s", "Paper will be published only to:");
        static tm dateTo = ImGui::GetCurrentDate();
        ImGui::DateChooser("##dateTo",dateTo);
        ImGui::PopID();

Ala Google translate

Hello! I'm planning use your NodeGraphEditor in my graduation work as a part of a cellular automata GUI I'm developing. First of all, thanks for open your code, it's a nice and versatile 'widget'. I'm still a noob in imgui, so maybe I haven't see the solution to this, but seems like the function (passed in addFieldEnum()) that returns the name of a selected index, must be static (as your APPLE/ LEMON/ ORANGE example). Once my application allows the user to define in execution time some objects that will appear as options in a FieldEnum, I can't define it statically.

So, there is a way to do this? Would be great if I can use your NodeGraphEditor on my work :)

I am trying to open dialog box on pressing ImGui::MenuItem or by simple bool variable, but it doesn't work.

// Inside a ImGui window:
const bool browseButtonPressed = ImGui::Button("...");                          // we need a trigger boolean variable
static ImGuiFs::Dialog dlg;                                                     // one per dialog (and must be static)
const char* chosenPath = dlg.chooseFileDialog(browseButtonPressed);             // see other dialog types and the full list of arguments for advanced usage
if (strlen(chosenPath)>0) {
    // A path (chosenPath) has been chosen RIGHT NOW. However we can retrieve it later more comfortably using: dlg.getChosenPath()
}
if (strlen(dlg.getChosenPath())>0) {
    ImGui::Text("Chosen file: \"%s\"",dlg.getChosenPath());
}

// If you want to copy the (valid) returned path somewhere, you can use something like:
static char myPath[ImGuiFs::MAX_PATH_BYTES];
if (strlen(dlg.getChosenPath())>0) {
    strcpy(myPath,dlg.getChosenPath());
}

VS2013 to compile addons,but unble to compile correctly,turn on as below error "error C3861: 'snprintf': identifier not found"

i had added codes in imguilistview.h as below:

if _MSC_VER

define snprintf _snprintf

endif

recompile,but still unble to compile correctly,turn on as below error:

pls help me to compile it correctly using vs2013?

Upgraded my imgui submodule for the first time in a while and the dock splits aren't draggable!

Affects 54509c59590c721e54ac7459ec84497766c64049, the revision I'm currently using in my project. (I am a bit behind! I will be upgrading, just not yet. Dealing with the dear imgui input changes will mean a bit of work.)

Also affects 008d358ea2bf61fb07a63b34a8f72e2f8906dc64 (current head revision), I think, as I can reproduce it in Chrome with https://rawgit.com/Flix01/imgui/imgui_with_addons/examples/addons_examples/html/main.html

After a bit of poking about it looks like the invisible buttons (e.g., https://github.com/Flix01/imgui/blob/54509c59590c721e54ac7459ec84497766c64049/addons/imguidock/imguidock.cpp#L362) are never getting classed as hovered, even when the mouse is over them.

I'm going to attempt to fix this, but I thought I'd raise an issue anyway. I haven't been paying much attention to recent dear imgui changes, so maybe it's actually something pretty obvious...

Thanks,

--Tom

Would it be possible to allow the user to specify the month names and day names? This would be useful when the application is using a language other than english.

Hello Flix01, Please, could you advise how to use imguipdfviewer? I tried to spice things up as follows:

        static ImGui::PdfViewer pdf;
        pdf.loadFromFile(ResourceManager::getInstance()->createAssetsPath("sldb2011_zv.pdf").c_str());
        pdf.render(ImVec2(800, 600));

But nothing - Segmentation fault: 139 ...

I want to use imguidock in visual studio.

I used the following code in the main loop:

// Windowed:
ImGui::SetNextWindowSize(ImVec2(500, 500),ImGuiCond_Once);        
if (ImGui::Begin("imguidock window (= lumix engine's dock system)",NULL,ImGuiWindowFlags_NoScrollbar)) {
        ImGui::BeginDockspace();
        static char tmp[128];
        for (int i=0;i<10;i++)  {
                sprintf(tmp,"Dock %d",i);
                if (i==9) ImGui::SetNextDock(ImGuiDockSlot_Bottom);// optional
                if(ImGui::BeginDock(tmp))  {
                    ImGui::Text("Content of dock window %d goes here",i);
                }
            ImGui::EndDock();
        }
        ImGui::EndDockspace();
 }
 ImGui::End();

but I got the following errors:

Severity	Code	Description	Project	File	Line	Suppression State
Error (active)		namespace "ImGui" has no member "BeginDockspace"	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	141	
Error (active)		identifier "sprintf" is undefined	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	144	
Error (active)		namespace "ImGui" has no member "SetNextDock"	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	145	
Error (active)		identifier "ImGuiDockSlot_Bottom" is undefined	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	145	
Error (active)		namespace "ImGui" has no member "BeginDock"	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	146	
Error (active)		namespace "ImGui" has no member "EndDock"	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	149	
Error (active)		namespace "ImGui" has no member "EndDockspace"	example_win32_directx9	d:\Demo\Flix01-imgui\examples\example_win32_directx9\main.cpp	151	
Error	C2039	'BeginDockspace': is not a member of 'ImGui'	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	141	
Error	C3861	'BeginDockspace': identifier not found	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	141	
Error	C3861	'sprintf': identifier not found	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	144	
Error	C2039	'SetNextDock': is not a member of 'ImGui'	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	145	
Error	C2065	'ImGuiDockSlot_Bottom': undeclared identifier	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	145	
Error	C3861	'SetNextDock': identifier not found	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	145	
Error	C2039	'BeginDock': is not a member of 'ImGui'	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	146	
Error	C3861	'BeginDock': identifier not found	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	146	
Error	C2039	'EndDock': is not a member of 'ImGui'	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	149	
Error	C3861	'EndDock': identifier not found	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	149	
Error	C2039	'EndDockspace': is not a member of 'ImGui'	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	151	
Error	C3861	'EndDockspace': identifier not found	example_win32_directx9	d:\demo\flix01-imgui\examples\example_win32_directx9\main.cpp	151	

What can I do to recognize the addons file？ Thanks

I've triggered by incommon usage a memory use after free by having a nodegrapheditor in an own class as member and moving my object into a std-vector. the nodegrapheditor inherits from TabLabel which has pointer-members to label, tooltip and userText. I think my sequence to trigger the error is: create nodegrapheditor and by that a tablabel with a label-string. now I move this nodegrapheditor into the vector which calls the (implicit) copy-constructor of tablabel which copies the pointers, afterwards the old object gets deleted and calls the MemFree-functions, but the pointers are still used in the copied object and are now unsafe to use.

I've written a copy-constructor and a copy assignment operator to fix it:

    TabLabel(const TabLabel &other) {
        label = tooltip = userText = NULL;
        userPtr = other.userPtr;
        userInt = other.userInt;
        closable = other.closable;
        draggable = other.draggable;
        mustCloseNextFrame = other.mustCloseNextFrame;
        mustSelectNextFrame = other.mustSelectNextFrame;
        wndFlags = other.wndFlags;
        modified = other.modified;
        if(other.label) {
            label = (char*)ImGui::MemAlloc(strlen(other.label)+2);
            strcpy(label, other.label);
        }
        if(other.tooltip) {
            tooltip = (char*)ImGui::MemAlloc(strlen(other.tooltip)+1);
            strcpy(tooltip, other.tooltip);
        }
        if(other.userText) {
            userText = (char*)ImGui::MemAlloc(strlen(other.userText)+1);
            strcpy(userText, other.userText);
        }
    }
    TabLabel &operator=(const TabLabel &other) {
        if(this != &other) {
            label = tooltip = userText = NULL;
            userPtr = other.userPtr;
            userInt = other.userInt;
            closable = other.closable;
            draggable = other.draggable;
            mustCloseNextFrame = other.mustCloseNextFrame;
            mustSelectNextFrame = other.mustSelectNextFrame;
            wndFlags = other.wndFlags;
            modified = other.modified;
            if(other.label) {
                label = (char*)ImGui::MemAlloc(strlen(other.label)+2);
                strcpy(label, other.label);
            }
            if(other.tooltip) {
                tooltip = (char*)ImGui::MemAlloc(strlen(other.tooltip)+1);
                strcpy(tooltip, other.tooltip);
            }
            if(other.userText) {
                userText = (char*)ImGui::MemAlloc(strlen(other.userText)+1);
                strcpy(userText, other.userText);
            }
        }
        return *this;
    }

with that included I have no longer the memory usage after free in my codebase....

In order to change titlebar background color,I hope to provide titlebar drawing function as like ImWindow(https://github.com/thennequin/ImWindow.git branch:titlebar)

Hello good evening, I'm having problems compiling your lib in my project, a good part of the implementations are compiling correctly in my MINGW compiler on a Windows machine.

However, adding #include "imguifilesystem.h" in the main.cpp file generates several errors like:

/usr/share/mingw-w64/include/minwindef.h:142:17: error: 'typedef float FLOAT' redeclared as different kind of symbol
/usr/share/mingw-w64/include/winnt.h:598:16: error: 'typedef BYTE BOOLEAN' redeclared as different kind of symbol  typedef BYTE BOOLEAN;
/usr/share/mingw-w64/include/winnt.h:3651:7: error: 'BOOLEAN' does not name a type BOOLEAN EffectiveOnly;

I'm including your lib in Cmake as follows:

set (IMGUI_INCLUDE_DIRS
  $ {CMAKE_CURRENT_SOURCE_DIR} / dependencies / imgui /
  $ {CMAKE_CURRENT_SOURCE_DIR} / dependencies / imgui / addons
  $ {CMAKE_CURRENT_SOURCE_DIR} / dependencies / imgui / addons / imguifilesystem)

set (IMGUI_LIBRARY imgui)

set (IMGUI_USE_MINIZIP OFF CACHE BOOL "IMGUI_USE_MINIZIP")
add_definitions (-DYES_IMGUIADDONS_ALL)

INCLUDE_DIRECTORIES (
    $ {CMAKE_CURRENT_SOURCE_DIR} / imgui / addons /
    $ {CMAKE_CURRENT_SOURCE_DIR} / imgui /
    $ {CMAKE_CURRENT_SOURCE_DIR} / imgui / addons / imguifilesystem /
)

add_library (imgui STATIC
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/imgui.h
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/imgui.cpp
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/imgui_demo.cpp
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/imgui_draw.cpp
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/addons/imgui_user.h
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/addons/imguifilesystem/dirent_portable.h
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/addons/imguifilesystem/imguifilesystem.h
    $ {CMAKE_CURRENT_SOURCE_DIR} /imgui/addons/imguifilesystem/imguifilesystem.cpp
    )

How can I proceed with a solution? Thank you for your cooperation.

I use ImGui as a dll by setting IMGUI_API to either export or import symbols appropriately - currently the addons are unusable for me because the interface (forward declarations of functions in headers) is not annotated with IMGUI_API accordingly.

My operating system is Windows 10 64-bits and the system's language is chinese. Here I have a folder, its cotents show like these: When I use the IMGUIFs::Dialog and enter this folder, I got:

It seems that:

1. All files or directries with non-ASCII name are not listed;
2. Files with long name are shrinked.

Both 1 and 2 are caused by using of API scandir. I hadn't known this API before. But when I debug into the Directory::GetFiles and Directory::GetDirectories I make sure it is the causing reason.

(By the way, I got compiler error when I compiler filesystem.cpp under Visual Studio 2015 X64 model. I fix it by adding #ifdef _WIN32 #include <Windows.h> #endif piror to the first include directive in this file.)

For myself, I modified the filesystem.cpp to resolve this as following: Add supporting header and API:

#ifdef IMGUI_FILESYSTEM_USE_STD_FILESYSTEM
#include <experimental\filesystem> // VS-builtin experimental library for c++17
#include <boost\locale.hpp> // encoding related
/* the so-called `exec_char_enc` is a kind of encoding that C++'s specified compiler use in C++ standard API such as printf std::cout and so on. When you write "IMGUI", the string has this encoding. ` */
inline std::string to_exec_char_enc(
	const std::string &text,
	const std::string &fromencoding)
{
	return boost::locale::conv::between(text, "GB2312", fromencoding);
}

inline std::string u8_to_exec_char_enc(
	const std::string &text)
{
	return to_exec_char_enc(text, "UTF-8");
}
#endif

Subsitute the code fragments in Directory::GetFiles or Directory::GetDirectorys by:

#ifdef IMGUI_FILESYSTEM_USE_STD_FILESYSTEM
namespace fs = std::experimental::filesystem;
		{
			auto srcdir = u8_to_exec_char_enc(directoryName);
			result.clear();
			if (pOptionalNamesOut)
				pOptionalNamesOut->clear();
			fs::path rootpath(srcdir);
			std::error_code errc;
			auto r = fs::directory_iterator(rootpath, errc);
			if (errc)
				return;
			for (auto &item : r)
			{
				if (item.status().type() == fs::file_type::directory) // or, fs::file_type::regular_file
				{
					auto stdstr = item.path().u8string();
					String::PushBack(result, stdstr.c_str());
					auto fnamepath = item.path().filename().u8string();
					if (pOptionalNamesOut)
						String::PushBack(*pOptionalNamesOut, fnamepath.c_str());
				}
			}
			return;
		}
#endif

The result:

Hope this helps. ------ Leslie.

As I read status of current implementation is not good, but I did some improvements for "BadCodeEditor" (not another one) and I want to reimplement folding in this method but I don't really understand the structure of that, could you explain please?

I got the dialog to pop up and show the current dir. but the opengl window frame the dialog is being drawn on is following the mouse motion I make. it wont stay still like the demo window where you can interact with the examples. how do I fix this?