==> cmake . -DPUGIXML_INCLUDE_DIR=/usr/local/opt/pugixml/include -DPUGIXML_LIBRARY=/usr/local/opt/pugixml/lib -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/wdc/1.0.2 -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev
-- [hunter] Initializing Hunter workspace (4ba5c303245faed28548d4a47f496cf645cf67ed)
-- [hunter]   https://github.com/designerror/hunter/archive/v0.18.14.23.tar.gz
-- [hunter]   -> /tmp/wdc-20170724-88622-1vd10v/webdav-client-cpp-1.0.2/.brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30
-- The C compiler identification is AppleClang 8.1.0.8020042
-- The CXX compiler identification is AppleClang 8.1.0.8020042
-- Check for working C compiler: /usr/local/Homebrew/Library/Homebrew/shims/super/clang
-- Check for working C compiler: /usr/local/Homebrew/Library/Homebrew/shims/super/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/local/Homebrew/Library/Homebrew/shims/super/clang++
-- Check for working CXX compiler: /usr/local/Homebrew/Library/Homebrew/shims/super/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- [hunter] Calculating Config-SHA1
-- [hunter] Calculating Toolchain-SHA1

[hunter ** FATAL ERROR **] No toolchain info generated
[hunter ** FATAL ERROR **] [Directory:/tmp/wdc-20170724-88622-1vd10v/webdav-client-cpp-1.0.2/_3rdParty/Hunter/toolchain]

------------------------------ WIKI -------------------------------
    https://github.com/ruslo/hunter/wiki/error.no.toolchain.info
-------------------------------------------------------------------

CMake Error at /tmp/wdc-20170724-88622-1vd10v/webdav-client-cpp-1.0.2/.brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_wiki.cmake:12 (message):
Call Stack (most recent call first):
  /tmp/wdc-20170724-88622-1vd10v/webdav-client-cpp-1.0.2/.brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_fatal_error.cmake:20 (hunter_wiki)
  CMakeLists.txt:132 (hunter_fatal_error)



[hunter ** INTERNAL **] Generate failed: exit with code 1
[hunter ** INTERNAL **] [Directory:/tmp/wdc-20170724-88622-1vd10v/webdav-client-cpp-1.0.2]

------------------------------ WIKI -------------------------------
    https://github.com/ruslo/hunter/wiki/error.internal
-------------------------------------------------------------------

CMake Error at .brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_wiki.cmake:12 (message):
Call Stack (most recent call first):
  .brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_internal_error.cmake:13 (hunter_wiki)
  .brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_calculate_toolchain_sha1.cmake:98 (hunter_internal_error)
  .brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_apply_gate_settings.cmake:106 (hunter_calculate_toolchain_sha1)
  .brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_finalize.cmake:66 (hunter_apply_gate_settings)
  .brew_home/.hunter/_Base/Download/Hunter/0.18.14/4ba5c30/Unpacked/cmake/modules/hunter_add_package.cmake:23 (hunter_finalize)
  CMakeLists.txt:45 (hunter_add_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/wdc-20170724-88622-1vd10v/webdav-client-cpp-1.0.2/CMakeFiles/CMakeOutput.log".

https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/5205/version=sierra/console

I'm using an URL with a subdirectory as webdav_hostname (http://mynas.../temp) There is a check in the ::info method (client.cpp:515) verifying that resource_path and target_path are equal: if (resource_path_without_sep.compare(target_path_without_sep) == 0) { They differ in my case: target_path_without_sep: /empty_directory/ resource_path_without_sep: /temp/empty_directory/ Hence ::info returns an empty dict_t.

After making a backup, nothing appears in my Webdav share (running on a self-hosted FreeNAS). The octoprint.log says:

TypeError: can only concatenate str (not "tuple") to str
2021-03-02 19:58:18,187 - octoprint.plugins.backup - INFO - Creating backup zip at /home/pi/.octoprint/data/backup/.octoprint-backup-20210302-195818.zip (excluded: uploads)...
2021-03-02 19:58:18,280 - octoprint.plugins.backup - INFO - ... done creating backup zip.
2021-03-02 19:58:18,289 - octoprint.plugins.webdavbackup - INFO - Backup /home/pi/.octoprint/data/backup/octoprint-backup-20210302-195818.zip created, will now attempt to upload to http://192.168.50.59:8080/OctoPiBackup/
2021-03-02 19:58:18,341 - octoprint.plugin - ERROR - Error while calling plugin webdavbackup
Traceback (most recent call last):
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_webdavbackup/__init__.py", line 78, in on_event
    dav_free = davclient.free()
  File "/home/pi/oprint/lib/python3.7/site-packages/webdav3/client.py", line 66, in _wrapper
    res = fn(self, *args, **kw)
  File "/home/pi/oprint/lib/python3.7/site-packages/webdav3/client.py", line 277, in free
    return WebDavXmlUtils.parse_free_space_response(response.content, self.webdav.hostname)
  File "/home/pi/oprint/lib/python3.7/site-packages/webdav3/client.py", line 946, in parse_free_space_response
    raise MethodNotSupported(name='free', server=hostname)
webdav3.exceptions.MethodNotSupported: Method 'free' not supported for http://192.168.50.59:8080/OctoPiBackup

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/plugin/__init__.py", line 271, in call_plugin
    result = getattr(plugin, method)(*args, **kwargs)
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/__init__.py", line 1890, in wrapper
    return f(*args, **kwargs)
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_webdavbackup/__init__.py", line 106, in on_event
    self._logger.error("An unexpected WebDAV error was encountered: " + exception.args)
TypeError: can only concatenate str (not "tuple") to str
2021-03-02 19:59:05,441 - octoprint.server.util.sockjs - INFO - Client connection closed: ::ffff:192.168.50.123

Any ideas what's causing this, or whether it's a problem with my Webdav config or the plugin? Thank you for your help!

What's the intention for the code here: https://github.com/CloudPolis/webdav-client-cpp/blob/d1bbbf939b39cb7f17acaefe5e0ccce658325faa/sources/client.cpp#L453

If target_path = /test/example/, target_path_without_sep will be equal to target_path. If target_path = /test/example, target_path_without_sep will be /test/. But I guess the intention was:

auto target_path_without_sep = target_urn.path();
if( !target_path_without_sep.empty() && target_path_without_sep.back() == '/' )
     target_path_without_sep.resize(target_path_without_sep.length() - 1);

If a path ends with a slash the parent() method probably does not return what is expected. Example: Path("test/some_path/").parent().path() will return "test/some_path/".

By changing https://github.com/CloudPolis/webdav-client-cpp/blob/3af8c9c7cec55be201c93f6bd4720818db6e7f50/sources/urn.cpp#L140

to auto last_separate_position = m_path.rfind(Path::separate, m_path.length() - 2); it should be ok I guess.

I needed to add "-pthread" to CMAKE_CXX_FLAGS in CMakeLists.txt to get the tests linking (tests/check): 'set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC -pthread")' Without -pthread, I got the following error from the linker: libwdc.a(client.cpp.o): In functionstd::thread::thread<WebDAV::Client::async_download(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::function<void (bool)>, std::function<int (void*, unsigned long, unsigned long, unsigned long, unsigned long)>) const::{lambda()#1}>(WebDAV::Client::async_download(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::function<void (bool)>, std::function<int (void*, unsigned long, unsigned long, unsigned long, unsigned long)>) const::{lambda()#1}&&)': client.cpp:(.text+0x51a5): undefined reference topthread_create'

-> I'm using Ubuntu 17.04 with gcc 6.3.0 See also https://stackoverflow.com/questions/34933042/undefined-reference-to-pthread-create-error-when-making-c11-application-with

If m_path contains URL, which ends with '/', there is infinite recursion. Check.

P.S. The second commit changes nothing, made only for starting tests. P.P.S. There is problem on 2 last tests (Mac OS) with "cmake .. -DBUILD_TESTS:BOOL=$BUILD_TESTS -DHOME_PUGIXML="/usr/local" && make", don't know why. P.P.P.S. Update mkdir.cpp - wrong names of variables.

Passing the parameters by reference to the std::thread object probably will result in a crash for most users, if they don't take care that those parameters have to be valid and constant for the whole thread lifetime.

https://github.com/CloudPolis/webdav-client-cpp/blob/5a92c825e84ba0a3d1907b8cbdaeee7fa3079bb5/sources/client.cpp#L556

Instead of capturing the parameters with a lambda expression it would be probably better to pass the parameters as a thread local copy, e.g. by passing the function parameters as parameters to the thread instance.

I'm not sure if this is an issue of the ::list method or the tests. The tests checking the number of directory entries fails, because I'm getting 1 directory more than expected. E.g. tests/list.cpp returns 11 entries, and 10 is the expected value: /temp/dir_with_files_and_dirs/ /temp/dir_with_files_and_dirs/file5 /temp/dir_with_files_and_dirs/file2 /temp/dir_with_files_and_dirs/file4 /temp/dir_with_files_and_dirs/dir1/ /temp/dir_with_files_and_dirs/dir4/ /temp/dir_with_files_and_dirs/dir3/ /temp/dir_with_files_and_dirs/file1 /temp/dir_with_files_and_dirs/dir5/ /temp/dir_with_files_and_dirs/dir2/ /temp/dir_with_files_and_dirs/file3

Having a QNAP NAS as WebDAV server where Apache is installed. PROPFIND requests returns a respond like this: [...] <D:response xmlns:lp1="DAV:"> <D:href>/temp/dir_with_files_and_dirs/</D:href> <D:propstat> <D:prop> lp1:resourcetype<D:collection/></lp1:resourcetype> </D:prop> [...] So we get "D" instead of "d" and "lp1:resourcetype" instead of "d:resourcetype" This is not handled correctly by webdav-client-cpp, e.g. in the ::info method. For an example of a PROPFIND respond see also http://people.apache.org/~thorsten/proposal/docs/components/repository/webdav.html

Nice code example here: https://stackoverflow.com/questions/21162186/pugixml-parse-namespace-with-prefix-mapping-and-without-prefix-mappig

When trying to create a directory recursively when there is no internet connection available, the call to create_directory runs in an endless loop. The check call will fail, because of the recursive flag being true, another call to create_directory will be done that again runs into create_directory and so on:

https://github.com/CloudPolis/webdav-client-cpp/blob/fafcb660a79ff34079e6063b5abb3e8d13aa84bd/sources/client.cpp#L595

By adding a check if the parent directory is unequal to the original directory this can be avoided:

auto remote_parent_directory = directory_urn.parent().path();
if( remote_parent_directory == remote_directory )
     return false;
bool is_created = this->create_directory(remote_parent_directory, response, true);
if (!is_created) return false;

Hi. My name is Sinan I new Learn C++ Programing i use C++ Builder i work to your project webdav-client.cpp

[bcc32 Error] client.hpp(34): E2070 Invalid use of namespace 'progress_t' Full parser context client.hpp(33): namespace WebDAV my little need your help thank you please help me

Returned 'dict_t' from Client::info() has always size zero. I am connecting to an owncload server and the rest seems to work (I can create directories and upload files).